* [Qemu-trivial] configure: enable kvm on x32
@ 2015-03-12 6:13 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2015-03-12 6:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, 778737
Here's a trivial change to enable kvm on x32 architecture.
I'm not 100% sure the result works correctly in all cases,
but this is a good start and in theory everything should
work.
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/configure b/configure
index 47048f0..d2e626e 100755
--- a/configure
+++ b/configure
@@ -5164,7 +5164,9 @@ case "$target_name" in
\( "$target_name" = "ppcemb" -a "$cpu" = "ppc64" \) -o \
\( "$target_name" = "mipsel" -a "$cpu" = "mips" \) -o \
\( "$target_name" = "x86_64" -a "$cpu" = "i386" \) -o \
- \( "$target_name" = "i386" -a "$cpu" = "x86_64" \) \) ; then
+ \( "$target_name" = "i386" -a "$cpu" = "x86_64" \) -o \
+ \( "$target_name" = "x86_64" -a "$cpu" = "x32" \) -o \
+ \( "$target_name" = "i386" -a "$cpu" = "x32" \) \) ; then
echo "CONFIG_KVM=y" >> $config_target_mak
if test "$vhost_net" = "yes" ; then
echo "CONFIG_VHOST_NET=y" >> $config_target_mak
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] configure: enable kvm on x32
@ 2015-03-12 6:13 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2015-03-12 6:13 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, 778737
Here's a trivial change to enable kvm on x32 architecture.
I'm not 100% sure the result works correctly in all cases,
but this is a good start and in theory everything should
work.
Signed-off-by: Adam Borowski <kilobyte@angband.pl>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
diff --git a/configure b/configure
index 47048f0..d2e626e 100755
--- a/configure
+++ b/configure
@@ -5164,7 +5164,9 @@ case "$target_name" in
\( "$target_name" = "ppcemb" -a "$cpu" = "ppc64" \) -o \
\( "$target_name" = "mipsel" -a "$cpu" = "mips" \) -o \
\( "$target_name" = "x86_64" -a "$cpu" = "i386" \) -o \
- \( "$target_name" = "i386" -a "$cpu" = "x86_64" \) \) ; then
+ \( "$target_name" = "i386" -a "$cpu" = "x86_64" \) -o \
+ \( "$target_name" = "x86_64" -a "$cpu" = "x32" \) -o \
+ \( "$target_name" = "i386" -a "$cpu" = "x32" \) \) ; then
echo "CONFIG_KVM=y" >> $config_target_mak
if test "$vhost_net" = "yes" ; then
echo "CONFIG_VHOST_NET=y" >> $config_target_mak
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] configure: enable kvm on x32
2015-03-12 6:13 ` [Qemu-devel] " Michael Tokarev
@ 2015-03-12 7:16 ` Peter Maydell
-1 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2015-03-12 7:16 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, 778737, qemu-devel
On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Here's a trivial change to enable kvm on x32 architecture.
> I'm not 100% sure the result works correctly in all cases,
> but this is a good start and in theory everything should
> work.
Given the pessimism expressed in this comment, perhaps
we should delay this to 2.4 and when it's had more
testing?
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] configure: enable kvm on x32
@ 2015-03-12 7:16 ` Peter Maydell
0 siblings, 0 replies; 8+ messages in thread
From: Peter Maydell @ 2015-03-12 7:16 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, 778737, qemu-devel
On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
> Here's a trivial change to enable kvm on x32 architecture.
> I'm not 100% sure the result works correctly in all cases,
> but this is a good start and in theory everything should
> work.
Given the pessimism expressed in this comment, perhaps
we should delay this to 2.4 and when it's had more
testing?
-- PMM
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] configure: enable kvm on x32
2015-03-12 7:16 ` Peter Maydell
@ 2015-03-12 8:06 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2015-03-12 8:06 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, 778737, qemu-devel
12.03.2015 10:16, Peter Maydell wrote:
> On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Here's a trivial change to enable kvm on x32 architecture.
>> I'm not 100% sure the result works correctly in all cases,
>> but this is a good start and in theory everything should
>> work.
>
> Given the pessimism expressed in this comment, perhaps
> we should delay this to 2.4 and when it's had more
> testing?
There's no pessimism really. It is a new arch for kvm, so
_something_ might not work. In practice it works fairy well,
see https://bugs.debian.org/778737 -- at least debian can
be installed in x32 kvm.
And we don't lose anything really because it is a new arch.
That's why it was Cc'd -trivial.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] configure: enable kvm on x32
@ 2015-03-12 8:06 ` Michael Tokarev
0 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2015-03-12 8:06 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, 778737, qemu-devel
12.03.2015 10:16, Peter Maydell wrote:
> On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> Here's a trivial change to enable kvm on x32 architecture.
>> I'm not 100% sure the result works correctly in all cases,
>> but this is a good start and in theory everything should
>> work.
>
> Given the pessimism expressed in this comment, perhaps
> we should delay this to 2.4 and when it's had more
> testing?
There's no pessimism really. It is a new arch for kvm, so
_something_ might not work. In practice it works fairy well,
see https://bugs.debian.org/778737 -- at least debian can
be installed in x32 kvm.
And we don't lose anything really because it is a new arch.
That's why it was Cc'd -trivial.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] configure: enable kvm on x32
2015-03-12 8:06 ` [Qemu-devel] " Michael Tokarev
@ 2015-03-12 14:18 ` Paolo Bonzini
-1 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2015-03-12 14:18 UTC (permalink / raw)
To: Michael Tokarev, Peter Maydell; +Cc: qemu-trivial, 778737, qemu-devel
On 12/03/2015 09:06, Michael Tokarev wrote:
> 12.03.2015 10:16, Peter Maydell wrote:
>> On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
>>> Here's a trivial change to enable kvm on x32 architecture.
>>> I'm not 100% sure the result works correctly in all cases,
>>> but this is a good start and in theory everything should
>>> work.
>>
>> Given the pessimism expressed in this comment, perhaps
>> we should delay this to 2.4 and when it's had more
>> testing?
>
> There's no pessimism really. It is a new arch for kvm, so
> _something_ might not work. In practice it works fairy well,
> see https://bugs.debian.org/778737 -- at least debian can
> be installed in x32 kvm.
>
> And we don't lose anything really because it is a new arch.
>
> That's why it was Cc'd -trivial.
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
... but I'm not going to test it.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] configure: enable kvm on x32
@ 2015-03-12 14:18 ` Paolo Bonzini
0 siblings, 0 replies; 8+ messages in thread
From: Paolo Bonzini @ 2015-03-12 14:18 UTC (permalink / raw)
To: Michael Tokarev, Peter Maydell; +Cc: qemu-trivial, 778737, qemu-devel
On 12/03/2015 09:06, Michael Tokarev wrote:
> 12.03.2015 10:16, Peter Maydell wrote:
>> On 12 March 2015 at 06:13, Michael Tokarev <mjt@tls.msk.ru> wrote:
>>> Here's a trivial change to enable kvm on x32 architecture.
>>> I'm not 100% sure the result works correctly in all cases,
>>> but this is a good start and in theory everything should
>>> work.
>>
>> Given the pessimism expressed in this comment, perhaps
>> we should delay this to 2.4 and when it's had more
>> testing?
>
> There's no pessimism really. It is a new arch for kvm, so
> _something_ might not work. In practice it works fairy well,
> see https://bugs.debian.org/778737 -- at least debian can
> be installed in x32 kvm.
>
> And we don't lose anything really because it is a new arch.
>
> That's why it was Cc'd -trivial.
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
... but I'm not going to test it.
Paolo
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-03-12 14:19 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-12 6:13 [Qemu-trivial] configure: enable kvm on x32 Michael Tokarev
2015-03-12 6:13 ` [Qemu-devel] " Michael Tokarev
2015-03-12 7:16 ` [Qemu-trivial] " Peter Maydell
2015-03-12 7:16 ` Peter Maydell
2015-03-12 8:06 ` [Qemu-trivial] " Michael Tokarev
2015-03-12 8:06 ` [Qemu-devel] " Michael Tokarev
2015-03-12 14:18 ` [Qemu-trivial] " Paolo Bonzini
2015-03-12 14:18 ` [Qemu-devel] " Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.