From: fabrice.gasnier@st.com (Fabrice Gasnier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: l2c: Fix prefetch settings dt parsing
Date: Thu, 12 Mar 2015 17:12:37 +0100 [thread overview]
Message-ID: <5501BAF5.5050306@st.com> (raw)
In-Reply-To: <20150312145712.GT8656@n2100.arm.linux.org.uk>
Hi Russel,
I just sent a V3 to follow your remark.
If this is ok, l'll add it to your patch system.
Thanks for your review.
BR,
Fabrice
On 03/12/2015 03:57 PM, Russell King - ARM Linux wrote:
> On Tue, Mar 10, 2015 at 09:59:01AM +0100, Fabrice GASNIER wrote:
>> Allow prefetch settings overriding by device tree, in case
>> l2x0_cache_size_of_parse() returns value, prefetch tuning
>> properties are silently ignored. E.g. arm,double-linefill* and
>> arm,prefetch*.
>> This happens for example, when "cache-size" or "cache-sets"
>> properties haven't been filled in l2c dt node.
>>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>> Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
> Patch is okay, but I think the commit message needs to be better :)
>
> "Allow device tree to override the L2C prefetch settings, even when
> l2x0_cache_size_of_parse() fails to parse the cache geometry due to (eg)
> missing "cache-size" or "cache-sets" properties."
>
> I think with something along those lines, the patch can be put in my
> patch system for when I next get around to applying some kernel patches
> instead of reading email. :)
>
> Thanks.
>
WARNING: multiple messages have this Message-ID (diff)
From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Tony Lindgren <tony@atomide.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Linus Walleij <linus.walleij@linaro.org>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Tomasz Figa <t.figa@samsung.com>, Arnd Bergmann <arnd@arndb.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <tomasz.figa@gmail.com>
Subject: Re: [PATCH v2] ARM: l2c: Fix prefetch settings dt parsing
Date: Thu, 12 Mar 2015 17:12:37 +0100 [thread overview]
Message-ID: <5501BAF5.5050306@st.com> (raw)
In-Reply-To: <20150312145712.GT8656@n2100.arm.linux.org.uk>
Hi Russel,
I just sent a V3 to follow your remark.
If this is ok, l'll add it to your patch system.
Thanks for your review.
BR,
Fabrice
On 03/12/2015 03:57 PM, Russell King - ARM Linux wrote:
> On Tue, Mar 10, 2015 at 09:59:01AM +0100, Fabrice GASNIER wrote:
>> Allow prefetch settings overriding by device tree, in case
>> l2x0_cache_size_of_parse() returns value, prefetch tuning
>> properties are silently ignored. E.g. arm,double-linefill* and
>> arm,prefetch*.
>> This happens for example, when "cache-size" or "cache-sets"
>> properties haven't been filled in l2c dt node.
>>
>> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
>> Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>
> Patch is okay, but I think the commit message needs to be better :)
>
> "Allow device tree to override the L2C prefetch settings, even when
> l2x0_cache_size_of_parse() fails to parse the cache geometry due to (eg)
> missing "cache-size" or "cache-sets" properties."
>
> I think with something along those lines, the patch can be put in my
> patch system for when I next get around to applying some kernel patches
> instead of reading email. :)
>
> Thanks.
>
next prev parent reply other threads:[~2015-03-12 16:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 8:59 [PATCH v2] ARM: l2c: Fix prefetch settings dt parsing Fabrice GASNIER
2015-03-10 8:59 ` Fabrice GASNIER
2015-03-12 14:57 ` Russell King - ARM Linux
2015-03-12 14:57 ` Russell King - ARM Linux
2015-03-12 16:12 ` Fabrice Gasnier [this message]
2015-03-12 16:12 ` Fabrice Gasnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5501BAF5.5050306@st.com \
--to=fabrice.gasnier@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.