All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	<qemu-devel@nongnu.org>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com,
	qemu-trivial@nongnu.org, mjt@tls.msk.ru,
	peter.huangpeng@huawei.com, shannon.zhao@linaro.org,
	pbonzini@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access
Date: Fri, 13 Mar 2015 17:43:52 +0800	[thread overview]
Message-ID: <5502B158.6060905@huawei.com> (raw)
In-Reply-To: <87zj7h9u2o.fsf@linux.vnet.ibm.com>

On 2015/3/13 16:31, Aneesh Kumar K.V wrote:
> Shannon Zhao <zhaoshenglong@huawei.com> writes:
> 
>> It's detected by coverity. Fix out-of-bounds access of the function mp_dacl_listxattr.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>>  hw/9pfs/virtio-9p-posix-acl.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c
>> index 803d9d9..09dad07 100644
>> --- a/hw/9pfs/virtio-9p-posix-acl.c
>> +++ b/hw/9pfs/virtio-9p-posix-acl.c
>> @@ -114,7 +114,7 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
>>      }
>>
>>      /* len includes the trailing NUL */
>> -    memcpy(value, ACL_ACCESS, len);
>> +    memcpy(value, ACL_DEFAULT, len);
>>      return 0;
>>  }
> 
> Applied.
> 
Thanks :-)

> Thanks
> -aneesh
> 
> 
> .
> 



WARNING: multiple messages have this Message-ID (diff)
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com,
	qemu-trivial@nongnu.org, mjt@tls.msk.ru,
	peter.huangpeng@huawei.com, shannon.zhao@linaro.org,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access
Date: Fri, 13 Mar 2015 17:43:52 +0800	[thread overview]
Message-ID: <5502B158.6060905@huawei.com> (raw)
In-Reply-To: <87zj7h9u2o.fsf@linux.vnet.ibm.com>

On 2015/3/13 16:31, Aneesh Kumar K.V wrote:
> Shannon Zhao <zhaoshenglong@huawei.com> writes:
> 
>> It's detected by coverity. Fix out-of-bounds access of the function mp_dacl_listxattr.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>>  hw/9pfs/virtio-9p-posix-acl.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/hw/9pfs/virtio-9p-posix-acl.c b/hw/9pfs/virtio-9p-posix-acl.c
>> index 803d9d9..09dad07 100644
>> --- a/hw/9pfs/virtio-9p-posix-acl.c
>> +++ b/hw/9pfs/virtio-9p-posix-acl.c
>> @@ -114,7 +114,7 @@ static ssize_t mp_dacl_listxattr(FsContext *ctx, const char *path,
>>      }
>>
>>      /* len includes the trailing NUL */
>> -    memcpy(value, ACL_ACCESS, len);
>> +    memcpy(value, ACL_DEFAULT, len);
>>      return 0;
>>  }
> 
> Applied.
> 
Thanks :-)

> Thanks
> -aneesh
> 
> 
> .
> 

  reply	other threads:[~2015-03-13 13:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  5:48 [Qemu-trivial] [PATCH] hw/9pfs/virtio-9p-posix-acl: Fix out-of-bounds access Shannon Zhao
2015-03-13  5:48 ` [Qemu-devel] " Shannon Zhao
2015-03-13  8:31 ` [Qemu-trivial] " Aneesh Kumar K.V
2015-03-13  8:31   ` [Qemu-devel] " Aneesh Kumar K.V
2015-03-13  9:43   ` Shannon Zhao [this message]
2015-03-13  9:43     ` Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5502B158.6060905@huawei.com \
    --to=zhaoshenglong@huawei.com \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=hangaohuai@huawei.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.