* [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property @ 2015-03-12 21:14 ` Marek Belisko 0 siblings, 0 replies; 16+ messages in thread From: Marek Belisko @ 2015-03-12 21:14 UTC (permalink / raw) To: bcousson, tony, peter.ujfalusi Cc: eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns, Marek Belisko ti,codec in not parsed in omap-twl4030 sound driver. It's not necessary to specify this property in DT because ti,twl4030-audio which ti,codec was pointing to by phandle is mfd driver and device for ASoC ic created w/o any DT property (codec name is hardcoded in ASoC driver). Please see reply [1] from Peter Ujfalusi. [1]: http://comments.gmane.org/gmane.linux.ports.arm.omap/124273 Marek Belisko (2): ARM: dts: omap3: Remove all references to ti,codec property Documentation: omap-twl4030: Remove ti,codec property Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- arch/arm/boot/dts/omap3-beagle-xm.dts | 1 - arch/arm/boot/dts/omap3-beagle.dts | 1 - arch/arm/boot/dts/omap3-cm-t3x30.dtsi | 1 - arch/arm/boot/dts/omap3-devkit8000.dts | 1 - arch/arm/boot/dts/omap3-gta04.dtsi | 1 - arch/arm/boot/dts/omap3-igep.dtsi | 1 - arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 1 - arch/arm/boot/dts/omap3-overo-base.dtsi | 1 - arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - 10 files changed, 11 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property @ 2015-03-12 21:14 ` Marek Belisko 0 siblings, 0 replies; 16+ messages in thread From: Marek Belisko @ 2015-03-12 21:14 UTC (permalink / raw) To: linux-arm-kernel ti,codec in not parsed in omap-twl4030 sound driver. It's not necessary to specify this property in DT because ti,twl4030-audio which ti,codec was pointing to by phandle is mfd driver and device for ASoC ic created w/o any DT property (codec name is hardcoded in ASoC driver). Please see reply [1] from Peter Ujfalusi. [1]: http://comments.gmane.org/gmane.linux.ports.arm.omap/124273 Marek Belisko (2): ARM: dts: omap3: Remove all references to ti,codec property Documentation: omap-twl4030: Remove ti,codec property Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- arch/arm/boot/dts/omap3-beagle-xm.dts | 1 - arch/arm/boot/dts/omap3-beagle.dts | 1 - arch/arm/boot/dts/omap3-cm-t3x30.dtsi | 1 - arch/arm/boot/dts/omap3-devkit8000.dts | 1 - arch/arm/boot/dts/omap3-gta04.dtsi | 1 - arch/arm/boot/dts/omap3-igep.dtsi | 1 - arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 1 - arch/arm/boot/dts/omap3-overo-base.dtsi | 1 - arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - 10 files changed, 11 deletions(-) -- 1.9.1 ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: omap3: Remove all references to ti,codec property 2015-03-12 21:14 ` Marek Belisko @ 2015-03-12 21:14 ` Marek Belisko -1 siblings, 0 replies; 16+ messages in thread From: Marek Belisko @ 2015-03-12 21:14 UTC (permalink / raw) To: bcousson, tony, peter.ujfalusi Cc: eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns, Marek Belisko ti,codec property is not used (parsed) in omap-twl4030 driver. The ti,twl4030-audio which ti,codec points by phandle is mfd driver and device for ASoC codec is created w/o DT compatible string. Removing all references in DT files. Signed-off-by: Marek Belisko <marek@goldelico.com> --- arch/arm/boot/dts/omap3-beagle-xm.dts | 1 - arch/arm/boot/dts/omap3-beagle.dts | 1 - arch/arm/boot/dts/omap3-cm-t3x30.dtsi | 1 - arch/arm/boot/dts/omap3-devkit8000.dts | 1 - arch/arm/boot/dts/omap3-gta04.dtsi | 1 - arch/arm/boot/dts/omap3-igep.dtsi | 1 - arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 1 - arch/arm/boot/dts/omap3-overo-base.dtsi | 1 - arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - 9 files changed, 9 deletions(-) diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts index 25f7b0a..da1464b 100644 --- a/arch/arm/boot/dts/omap3-beagle-xm.dts +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts @@ -60,7 +60,6 @@ ti,model = "omap3beagle"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; gpio_keys { diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts index c792391..4d30eaf 100644 --- a/arch/arm/boot/dts/omap3-beagle.dts +++ b/arch/arm/boot/dts/omap3-beagle.dts @@ -71,7 +71,6 @@ ti,model = "omap3beagle"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; gpio_keys { diff --git a/arch/arm/boot/dts/omap3-cm-t3x30.dtsi b/arch/arm/boot/dts/omap3-cm-t3x30.dtsi index d9e92b6..046cd77 100644 --- a/arch/arm/boot/dts/omap3-cm-t3x30.dtsi +++ b/arch/arm/boot/dts/omap3-cm-t3x30.dtsi @@ -16,7 +16,6 @@ ti,model = "cm-t35"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; }; diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts index 169037e..134d3f2 100644 --- a/arch/arm/boot/dts/omap3-devkit8000.dts +++ b/arch/arm/boot/dts/omap3-devkit8000.dts @@ -48,7 +48,6 @@ ti,model = "devkit8000"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; ti,audio-routing = "Ext Spk", "PREDRIVEL", "Ext Spk", "PREDRIVER", diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi index fb3a696..b9f6881 100644 --- a/arch/arm/boot/dts/omap3-gta04.dtsi +++ b/arch/arm/boot/dts/omap3-gta04.dtsi @@ -46,7 +46,6 @@ ti,model = "gta04"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; spi_lcd { diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi index 8a63ad2..d5e5cd4 100644 --- a/arch/arm/boot/dts/omap3-igep.dtsi +++ b/arch/arm/boot/dts/omap3-igep.dtsi @@ -22,7 +22,6 @@ compatible = "ti,omap-twl4030"; ti,model = "igep2"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; vdd33: regulator-vdd33 { diff --git a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi index e81fb65..e631333 100644 --- a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi +++ b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi @@ -38,7 +38,6 @@ ti,model = "lilly-a83x"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; reg_vcc3: vcc3 { diff --git a/arch/arm/boot/dts/omap3-overo-base.dtsi b/arch/arm/boot/dts/omap3-overo-base.dtsi index d36bf02..18e1649 100644 --- a/arch/arm/boot/dts/omap3-overo-base.dtsi +++ b/arch/arm/boot/dts/omap3-overo-base.dtsi @@ -27,7 +27,6 @@ ti,model = "overo"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; /* HS USB Port 2 Power */ diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi index e89820a..b3b24a5 100644 --- a/arch/arm/boot/dts/omap3-tao3530.dtsi +++ b/arch/arm/boot/dts/omap3-tao3530.dtsi @@ -45,7 +45,6 @@ /* McBSP2 is used for onboard sound, same as on beagle */ ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; /* Regulator to enable/switch the vcc of the Wifi module */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: dts: omap3: Remove all references to ti, codec property @ 2015-03-12 21:14 ` Marek Belisko 0 siblings, 0 replies; 16+ messages in thread From: Marek Belisko @ 2015-03-12 21:14 UTC (permalink / raw) To: linux-arm-kernel ti,codec property is not used (parsed) in omap-twl4030 driver. The ti,twl4030-audio which ti,codec points by phandle is mfd driver and device for ASoC codec is created w/o DT compatible string. Removing all references in DT files. Signed-off-by: Marek Belisko <marek@goldelico.com> --- arch/arm/boot/dts/omap3-beagle-xm.dts | 1 - arch/arm/boot/dts/omap3-beagle.dts | 1 - arch/arm/boot/dts/omap3-cm-t3x30.dtsi | 1 - arch/arm/boot/dts/omap3-devkit8000.dts | 1 - arch/arm/boot/dts/omap3-gta04.dtsi | 1 - arch/arm/boot/dts/omap3-igep.dtsi | 1 - arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 1 - arch/arm/boot/dts/omap3-overo-base.dtsi | 1 - arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - 9 files changed, 9 deletions(-) diff --git a/arch/arm/boot/dts/omap3-beagle-xm.dts b/arch/arm/boot/dts/omap3-beagle-xm.dts index 25f7b0a..da1464b 100644 --- a/arch/arm/boot/dts/omap3-beagle-xm.dts +++ b/arch/arm/boot/dts/omap3-beagle-xm.dts @@ -60,7 +60,6 @@ ti,model = "omap3beagle"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; gpio_keys { diff --git a/arch/arm/boot/dts/omap3-beagle.dts b/arch/arm/boot/dts/omap3-beagle.dts index c792391..4d30eaf 100644 --- a/arch/arm/boot/dts/omap3-beagle.dts +++ b/arch/arm/boot/dts/omap3-beagle.dts @@ -71,7 +71,6 @@ ti,model = "omap3beagle"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; gpio_keys { diff --git a/arch/arm/boot/dts/omap3-cm-t3x30.dtsi b/arch/arm/boot/dts/omap3-cm-t3x30.dtsi index d9e92b6..046cd77 100644 --- a/arch/arm/boot/dts/omap3-cm-t3x30.dtsi +++ b/arch/arm/boot/dts/omap3-cm-t3x30.dtsi @@ -16,7 +16,6 @@ ti,model = "cm-t35"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; }; diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts index 169037e..134d3f2 100644 --- a/arch/arm/boot/dts/omap3-devkit8000.dts +++ b/arch/arm/boot/dts/omap3-devkit8000.dts @@ -48,7 +48,6 @@ ti,model = "devkit8000"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; ti,audio-routing = "Ext Spk", "PREDRIVEL", "Ext Spk", "PREDRIVER", diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi index fb3a696..b9f6881 100644 --- a/arch/arm/boot/dts/omap3-gta04.dtsi +++ b/arch/arm/boot/dts/omap3-gta04.dtsi @@ -46,7 +46,6 @@ ti,model = "gta04"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; spi_lcd { diff --git a/arch/arm/boot/dts/omap3-igep.dtsi b/arch/arm/boot/dts/omap3-igep.dtsi index 8a63ad2..d5e5cd4 100644 --- a/arch/arm/boot/dts/omap3-igep.dtsi +++ b/arch/arm/boot/dts/omap3-igep.dtsi @@ -22,7 +22,6 @@ compatible = "ti,omap-twl4030"; ti,model = "igep2"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; vdd33: regulator-vdd33 { diff --git a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi index e81fb65..e631333 100644 --- a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi +++ b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi @@ -38,7 +38,6 @@ ti,model = "lilly-a83x"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; reg_vcc3: vcc3 { diff --git a/arch/arm/boot/dts/omap3-overo-base.dtsi b/arch/arm/boot/dts/omap3-overo-base.dtsi index d36bf02..18e1649 100644 --- a/arch/arm/boot/dts/omap3-overo-base.dtsi +++ b/arch/arm/boot/dts/omap3-overo-base.dtsi @@ -27,7 +27,6 @@ ti,model = "overo"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; /* HS USB Port 2 Power */ diff --git a/arch/arm/boot/dts/omap3-tao3530.dtsi b/arch/arm/boot/dts/omap3-tao3530.dtsi index e89820a..b3b24a5 100644 --- a/arch/arm/boot/dts/omap3-tao3530.dtsi +++ b/arch/arm/boot/dts/omap3-tao3530.dtsi @@ -45,7 +45,6 @@ /* McBSP2 is used for onboard sound, same as on beagle */ ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; /* Regulator to enable/switch the vcc of the Wifi module */ -- 1.9.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property 2015-03-12 21:14 ` Marek Belisko @ 2015-03-12 21:14 ` Marek Belisko -1 siblings, 0 replies; 16+ messages in thread From: Marek Belisko @ 2015-03-12 21:14 UTC (permalink / raw) To: bcousson, tony, peter.ujfalusi Cc: eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns, Marek Belisko ti,codec property is not necessary anymore thus removing references from documentation. Signed-off-by: Marek Belisko <marek@goldelico.com> --- Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt index 1ab6bc8..656165f 100644 --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt @@ -4,7 +4,6 @@ Required properties: - compatible: "ti,omap-twl4030" - ti,model: Name of the sound card (for example "omap3beagle") - ti,mcbsp: phandle for the McBSP node -- ti,codec: phandle for the twl4030 audio node Optional properties: - ti,mcbsp-voice: phandle for the McBSP node connected to the voice port of twl @@ -59,5 +58,4 @@ sound { ti,model = "omap3beagle"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property @ 2015-03-12 21:14 ` Marek Belisko 0 siblings, 0 replies; 16+ messages in thread From: Marek Belisko @ 2015-03-12 21:14 UTC (permalink / raw) To: linux-arm-kernel ti,codec property is not necessary anymore thus removing references from documentation. Signed-off-by: Marek Belisko <marek@goldelico.com> --- Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- 1 file changed, 2 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt index 1ab6bc8..656165f 100644 --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt @@ -4,7 +4,6 @@ Required properties: - compatible: "ti,omap-twl4030" - ti,model: Name of the sound card (for example "omap3beagle") - ti,mcbsp: phandle for the McBSP node -- ti,codec: phandle for the twl4030 audio node Optional properties: - ti,mcbsp-voice: phandle for the McBSP node connected to the voice port of twl @@ -59,5 +58,4 @@ sound { ti,model = "omap3beagle"; ti,mcbsp = <&mcbsp2>; - ti,codec = <&twl_audio>; }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property 2015-03-12 21:14 ` Marek Belisko @ 2015-03-13 11:05 ` Arnd Bergmann -1 siblings, 0 replies; 16+ messages in thread From: Arnd Bergmann @ 2015-03-13 11:05 UTC (permalink / raw) To: Marek Belisko Cc: bcousson, tony, peter.ujfalusi, eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: > diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt > index 1ab6bc8..656165f 100644 > --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt > +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt > @@ -4,7 +4,6 @@ Required properties: > - compatible: "ti,omap-twl4030" > - ti,model: Name of the sound card (for example "omap3beagle") > - ti,mcbsp: phandle for the McBSP node > -- ti,codec: phandle for the twl4030 audio node As this was a required property, are you sure that no other operating system uses it? Even if not, you should probably change it to be an optional property, so that the existing dtbs do not become noncompliant after the change. Arnd ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property @ 2015-03-13 11:05 ` Arnd Bergmann 0 siblings, 0 replies; 16+ messages in thread From: Arnd Bergmann @ 2015-03-13 11:05 UTC (permalink / raw) To: linux-arm-kernel On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: > diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt > index 1ab6bc8..656165f 100644 > --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt > +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt > @@ -4,7 +4,6 @@ Required properties: > - compatible: "ti,omap-twl4030" > - ti,model: Name of the sound card (for example "omap3beagle") > - ti,mcbsp: phandle for the McBSP node > -- ti,codec: phandle for the twl4030 audio node As this was a required property, are you sure that no other operating system uses it? Even if not, you should probably change it to be an optional property, so that the existing dtbs do not become noncompliant after the change. Arnd ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property 2015-03-13 11:05 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property Arnd Bergmann (?) @ 2015-03-13 11:48 ` Peter Ujfalusi -1 siblings, 0 replies; 16+ messages in thread From: Peter Ujfalusi @ 2015-03-13 11:48 UTC (permalink / raw) To: Arnd Bergmann, Marek Belisko Cc: bcousson, tony, eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns On 03/13/2015 01:05 PM, Arnd Bergmann wrote: > On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> index 1ab6bc8..656165f 100644 >> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> @@ -4,7 +4,6 @@ Required properties: >> - compatible: "ti,omap-twl4030" >> - ti,model: Name of the sound card (for example "omap3beagle") >> - ti,mcbsp: phandle for the McBSP node >> -- ti,codec: phandle for the twl4030 audio node > > As this was a required property, are you sure that no other operating system > uses it? > > Even if not, you should probably change it to be an optional property, so > that the existing dtbs do not become noncompliant after the change. After I sent my Ack, I also started to think about the same thing. It is better to change it to optional. -- Péter ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property @ 2015-03-13 11:48 ` Peter Ujfalusi 0 siblings, 0 replies; 16+ messages in thread From: Peter Ujfalusi @ 2015-03-13 11:48 UTC (permalink / raw) To: Arnd Bergmann, Marek Belisko Cc: bcousson, tony, eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns On 03/13/2015 01:05 PM, Arnd Bergmann wrote: > On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> index 1ab6bc8..656165f 100644 >> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> @@ -4,7 +4,6 @@ Required properties: >> - compatible: "ti,omap-twl4030" >> - ti,model: Name of the sound card (for example "omap3beagle") >> - ti,mcbsp: phandle for the McBSP node >> -- ti,codec: phandle for the twl4030 audio node > > As this was a required property, are you sure that no other operating system > uses it? > > Even if not, you should probably change it to be an optional property, so > that the existing dtbs do not become noncompliant after the change. After I sent my Ack, I also started to think about the same thing. It is better to change it to optional. -- Péter ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property @ 2015-03-13 11:48 ` Peter Ujfalusi 0 siblings, 0 replies; 16+ messages in thread From: Peter Ujfalusi @ 2015-03-13 11:48 UTC (permalink / raw) To: linux-arm-kernel On 03/13/2015 01:05 PM, Arnd Bergmann wrote: > On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> index 1ab6bc8..656165f 100644 >> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >> @@ -4,7 +4,6 @@ Required properties: >> - compatible: "ti,omap-twl4030" >> - ti,model: Name of the sound card (for example "omap3beagle") >> - ti,mcbsp: phandle for the McBSP node >> -- ti,codec: phandle for the twl4030 audio node > > As this was a required property, are you sure that no other operating system > uses it? > > Even if not, you should probably change it to be an optional property, so > that the existing dtbs do not become noncompliant after the change. After I sent my Ack, I also started to think about the same thing. It is better to change it to optional. -- P?ter ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property 2015-03-13 11:48 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property Peter Ujfalusi @ 2015-03-13 11:50 ` Belisko Marek -1 siblings, 0 replies; 16+ messages in thread From: Belisko Marek @ 2015-03-13 11:50 UTC (permalink / raw) To: Peter Ujfalusi Cc: Arnd Bergmann, Benoit Cousson, Tony Lindgren, eballetbo, javier, devicetree@vger.kernel.org, LKML, linux-omap@vger.kernel.org, linux-arm-kernel, jarkko.nikula, Dr. H. Nikolaus Schaller On Fri, Mar 13, 2015 at 12:48 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > On 03/13/2015 01:05 PM, Arnd Bergmann wrote: >> On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >>> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> index 1ab6bc8..656165f 100644 >>> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> @@ -4,7 +4,6 @@ Required properties: >>> - compatible: "ti,omap-twl4030" >>> - ti,model: Name of the sound card (for example "omap3beagle") >>> - ti,mcbsp: phandle for the McBSP node >>> -- ti,codec: phandle for the twl4030 audio node >> >> As this was a required property, are you sure that no other operating system >> uses it? >> >> Even if not, you should probably change it to be an optional property, so >> that the existing dtbs do not become noncompliant after the change. > > After I sent my Ack, I also started to think about the same thing. It is > better to change it to optional. OK will do and post v2. Thanks. > > -- > Péter BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property @ 2015-03-13 11:50 ` Belisko Marek 0 siblings, 0 replies; 16+ messages in thread From: Belisko Marek @ 2015-03-13 11:50 UTC (permalink / raw) To: linux-arm-kernel On Fri, Mar 13, 2015 at 12:48 PM, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: > On 03/13/2015 01:05 PM, Arnd Bergmann wrote: >> On Thursday 12 March 2015 22:14:59 Marek Belisko wrote: >>> diff --git a/Documentation/devicetree/bindings/sound/omap-twl4030.txt b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> index 1ab6bc8..656165f 100644 >>> --- a/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> +++ b/Documentation/devicetree/bindings/sound/omap-twl4030.txt >>> @@ -4,7 +4,6 @@ Required properties: >>> - compatible: "ti,omap-twl4030" >>> - ti,model: Name of the sound card (for example "omap3beagle") >>> - ti,mcbsp: phandle for the McBSP node >>> -- ti,codec: phandle for the twl4030 audio node >> >> As this was a required property, are you sure that no other operating system >> uses it? >> >> Even if not, you should probably change it to be an optional property, so >> that the existing dtbs do not become noncompliant after the change. > > After I sent my Ack, I also started to think about the same thing. It is > better to change it to optional. OK will do and post v2. Thanks. > > -- > P?ter BR, marek -- as simple and primitive as possible ------------------------------------------------- Marek Belisko - OPEN-NANDRA Freelance Developer Ruska Nova Ves 219 | Presov, 08005 Slovak Republic Tel: +421 915 052 184 skype: marekwhite twitter: #opennandra web: http://open-nandra.com ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property 2015-03-12 21:14 ` Marek Belisko (?) @ 2015-03-13 7:09 ` Peter Ujfalusi -1 siblings, 0 replies; 16+ messages in thread From: Peter Ujfalusi @ 2015-03-13 7:09 UTC (permalink / raw) To: Marek Belisko, bcousson, tony Cc: eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns On 03/12/2015 11:14 PM, Marek Belisko wrote: > ti,codec in not parsed in omap-twl4030 sound driver. It's not necessary > to specify this property in DT because ti,twl4030-audio which ti,codec > was pointing to by phandle is mfd driver and device for ASoC ic created w/o > any DT property (codec name is hardcoded in ASoC driver). All: Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Please see reply [1] from Peter Ujfalusi. > > [1]: http://comments.gmane.org/gmane.linux.ports.arm.omap/124273 > > Marek Belisko (2): > ARM: dts: omap3: Remove all references to ti,codec property > Documentation: omap-twl4030: Remove ti,codec property > > Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- > arch/arm/boot/dts/omap3-beagle-xm.dts | 1 - > arch/arm/boot/dts/omap3-beagle.dts | 1 - > arch/arm/boot/dts/omap3-cm-t3x30.dtsi | 1 - > arch/arm/boot/dts/omap3-devkit8000.dts | 1 - > arch/arm/boot/dts/omap3-gta04.dtsi | 1 - > arch/arm/boot/dts/omap3-igep.dtsi | 1 - > arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 1 - > arch/arm/boot/dts/omap3-overo-base.dtsi | 1 - > arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - > 10 files changed, 11 deletions(-) > -- Péter ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property @ 2015-03-13 7:09 ` Peter Ujfalusi 0 siblings, 0 replies; 16+ messages in thread From: Peter Ujfalusi @ 2015-03-13 7:09 UTC (permalink / raw) To: Marek Belisko, bcousson, tony Cc: eballetbo, javier, devicetree, linux-kernel, linux-omap, linux-arm-kernel, jarkko.nikula, hns On 03/12/2015 11:14 PM, Marek Belisko wrote: > ti,codec in not parsed in omap-twl4030 sound driver. It's not necessary > to specify this property in DT because ti,twl4030-audio which ti,codec > was pointing to by phandle is mfd driver and device for ASoC ic created w/o > any DT property (codec name is hardcoded in ASoC driver). All: Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Please see reply [1] from Peter Ujfalusi. > > [1]: http://comments.gmane.org/gmane.linux.ports.arm.omap/124273 > > Marek Belisko (2): > ARM: dts: omap3: Remove all references to ti,codec property > Documentation: omap-twl4030: Remove ti,codec property > > Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- > arch/arm/boot/dts/omap3-beagle-xm.dts | 1 - > arch/arm/boot/dts/omap3-beagle.dts | 1 - > arch/arm/boot/dts/omap3-cm-t3x30.dtsi | 1 - > arch/arm/boot/dts/omap3-devkit8000.dts | 1 - > arch/arm/boot/dts/omap3-gta04.dtsi | 1 - > arch/arm/boot/dts/omap3-igep.dtsi | 1 - > arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 1 - > arch/arm/boot/dts/omap3-overo-base.dtsi | 1 - > arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - > 10 files changed, 11 deletions(-) > -- Péter ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property @ 2015-03-13 7:09 ` Peter Ujfalusi 0 siblings, 0 replies; 16+ messages in thread From: Peter Ujfalusi @ 2015-03-13 7:09 UTC (permalink / raw) To: linux-arm-kernel On 03/12/2015 11:14 PM, Marek Belisko wrote: > ti,codec in not parsed in omap-twl4030 sound driver. It's not necessary > to specify this property in DT because ti,twl4030-audio which ti,codec > was pointing to by phandle is mfd driver and device for ASoC ic created w/o > any DT property (codec name is hardcoded in ASoC driver). All: Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com> > > Please see reply [1] from Peter Ujfalusi. > > [1]: http://comments.gmane.org/gmane.linux.ports.arm.omap/124273 > > Marek Belisko (2): > ARM: dts: omap3: Remove all references to ti,codec property > Documentation: omap-twl4030: Remove ti,codec property > > Documentation/devicetree/bindings/sound/omap-twl4030.txt | 2 -- > arch/arm/boot/dts/omap3-beagle-xm.dts | 1 - > arch/arm/boot/dts/omap3-beagle.dts | 1 - > arch/arm/boot/dts/omap3-cm-t3x30.dtsi | 1 - > arch/arm/boot/dts/omap3-devkit8000.dts | 1 - > arch/arm/boot/dts/omap3-gta04.dtsi | 1 - > arch/arm/boot/dts/omap3-igep.dtsi | 1 - > arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 1 - > arch/arm/boot/dts/omap3-overo-base.dtsi | 1 - > arch/arm/boot/dts/omap3-tao3530.dtsi | 1 - > 10 files changed, 11 deletions(-) > -- P?ter ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2015-03-13 11:50 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-03-12 21:14 [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property Marek Belisko 2015-03-12 21:14 ` Marek Belisko 2015-03-12 21:14 ` [PATCH 1/2] ARM: dts: omap3: Remove all references to " Marek Belisko 2015-03-12 21:14 ` [PATCH 1/2] ARM: dts: omap3: Remove all references to ti, codec property Marek Belisko 2015-03-12 21:14 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property Marek Belisko 2015-03-12 21:14 ` Marek Belisko 2015-03-13 11:05 ` Arnd Bergmann 2015-03-13 11:05 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property Arnd Bergmann 2015-03-13 11:48 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property Peter Ujfalusi 2015-03-13 11:48 ` Peter Ujfalusi 2015-03-13 11:48 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property Peter Ujfalusi 2015-03-13 11:50 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti,codec property Belisko Marek 2015-03-13 11:50 ` [PATCH 2/2] Documentation: omap-twl4030: Remove ti, codec property Belisko Marek 2015-03-13 7:09 ` [PATCH 0/2] ARM: devicetree: Remove unused ti,codec property Peter Ujfalusi 2015-03-13 7:09 ` Peter Ujfalusi 2015-03-13 7:09 ` Peter Ujfalusi
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.