* [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL
@ 2015-03-09 21:44 Fabio Estevam
2015-03-09 23:44 ` Tom Rini
2015-03-13 12:47 ` Stefano Babic
0 siblings, 2 replies; 6+ messages in thread
From: Fabio Estevam @ 2015-03-09 21:44 UTC (permalink / raw)
To: u-boot
From: Fabio Estevam <fabio.estevam@freescale.com>
Since commit ad8aae82b20ac6a ("mx6sabre: Enable User Mass Storage") SPL target
does not boot anymore due to the increased spl image size.
Only enable USB Mass Storage for the non-SPL target.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
include/configs/mx6sabre_common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
index f0e37f0..9417729 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -278,6 +278,7 @@
#define CONFIG_IMX_HDMI
#define CONFIG_IMX_VIDEO_SKIP
+#ifndef CONFIG_SPL
#define CONFIG_CI_UDC
#define CONFIG_USBD_HS
#define CONFIG_USB_GADGET_DUALSPEED
@@ -291,5 +292,6 @@
#define CONFIG_G_DNL_VENDOR_NUM 0x0525
#define CONFIG_G_DNL_PRODUCT_NUM 0xa4a5
#define CONFIG_G_DNL_MANUFACTURER "FSL"
+#endif
#endif /* __MX6QSABRE_COMMON_CONFIG_H */
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL
2015-03-09 21:44 [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL Fabio Estevam
@ 2015-03-09 23:44 ` Tom Rini
2015-03-09 23:52 ` Fabio Estevam
2015-03-13 12:47 ` Stefano Babic
1 sibling, 1 reply; 6+ messages in thread
From: Tom Rini @ 2015-03-09 23:44 UTC (permalink / raw)
To: u-boot
On Mon, Mar 09, 2015 at 06:44:39PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit ad8aae82b20ac6a ("mx6sabre: Enable User Mass Storage") SPL target
> does not boot anymore due to the increased spl image size.
>
> Only enable USB Mass Storage for the non-SPL target.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Please do a follow up commit that makes use of the existing size checks
to avoid this problem in the future, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150309/63cde84c/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL
2015-03-09 23:44 ` Tom Rini
@ 2015-03-09 23:52 ` Fabio Estevam
2015-03-10 0:02 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Fabio Estevam @ 2015-03-09 23:52 UTC (permalink / raw)
To: u-boot
Hi Tom,
On Mon, Mar 9, 2015 at 8:44 PM, Tom Rini <trini@konsulko.com> wrote:
> On Mon, Mar 09, 2015 at 06:44:39PM -0300, Fabio Estevam wrote:
>
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Since commit ad8aae82b20ac6a ("mx6sabre: Enable User Mass Storage") SPL target
>> does not boot anymore due to the increased spl image size.
>>
>> Only enable USB Mass Storage for the non-SPL target.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Reviewed-by: Tom Rini <trini@konsulko.com>
>
> Please do a follow up commit that makes use of the existing size checks
> to avoid this problem in the future, thanks!
Yes, it would be useful. Could you please point me to the existing
size checks function, so that I can learn about it?
Thanks,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL
2015-03-09 23:52 ` Fabio Estevam
@ 2015-03-10 0:02 ` Tom Rini
2015-03-10 0:09 ` Fabio Estevam
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2015-03-10 0:02 UTC (permalink / raw)
To: u-boot
On Mon, Mar 09, 2015 at 08:52:52PM -0300, Fabio Estevam wrote:
> Hi Tom,
>
> On Mon, Mar 9, 2015 at 8:44 PM, Tom Rini <trini@konsulko.com> wrote:
> > On Mon, Mar 09, 2015 at 06:44:39PM -0300, Fabio Estevam wrote:
> >
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> Since commit ad8aae82b20ac6a ("mx6sabre: Enable User Mass Storage") SPL target
> >> does not boot anymore due to the increased spl image size.
> >>
> >> Only enable USB Mass Storage for the non-SPL target.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> >
> > Please do a follow up commit that makes use of the existing size checks
> > to avoid this problem in the future, thanks!
>
> Yes, it would be useful. Could you please point me to the existing
> size checks function, so that I can learn about it?
CONFIG_SPL_MAX_SIZE and CONFIG_SPL_MAX_BSS_SIZE or
CONFIG_SPL_MAX_FOOTPRINT are what you want for i.MX6 and documented in
README. I'm not quite sure of all the details on i.MX6 right now so I
can't say for sure which group it falls into. On TI ARMv7 parts for
example we get access to DDR by the time we need BSS, so BSS is in DDR
and our limit there is semi artificial but CONFIG_SPL_MAX_SIZE (since
the binary is loaded into SRAM of a limited area) is not. On some TI
Davinci platforms we use CONFIG_SPL_MAX_FOOTPRINT since both BSS and the
binary must be in a limited RAM area.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20150309/5f5438ca/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL
2015-03-10 0:02 ` Tom Rini
@ 2015-03-10 0:09 ` Fabio Estevam
0 siblings, 0 replies; 6+ messages in thread
From: Fabio Estevam @ 2015-03-10 0:09 UTC (permalink / raw)
To: u-boot
On Mon, Mar 9, 2015 at 9:02 PM, Tom Rini <trini@konsulko.com> wrote:
> CONFIG_SPL_MAX_SIZE and CONFIG_SPL_MAX_BSS_SIZE or
> CONFIG_SPL_MAX_FOOTPRINT are what you want for i.MX6 and documented in
> README. I'm not quite sure of all the details on i.MX6 right now so I
> can't say for sure which group it falls into. On TI ARMv7 parts for
> example we get access to DDR by the time we need BSS, so BSS is in DDR
> and our limit there is semi artificial but CONFIG_SPL_MAX_SIZE (since
> the binary is loaded into SRAM of a limited area) is not. On some TI
> Davinci platforms we use CONFIG_SPL_MAX_FOOTPRINT since both BSS and the
> binary must be in a limited RAM area.
Thanks, Tom. I will take a look at these options.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL
2015-03-09 21:44 [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL Fabio Estevam
2015-03-09 23:44 ` Tom Rini
@ 2015-03-13 12:47 ` Stefano Babic
1 sibling, 0 replies; 6+ messages in thread
From: Stefano Babic @ 2015-03-13 12:47 UTC (permalink / raw)
To: u-boot
On 09/03/2015 22:44, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
>
> Since commit ad8aae82b20ac6a ("mx6sabre: Enable User Mass Storage") SPL target
> does not boot anymore due to the increased spl image size.
>
> Only enable USB Mass Storage for the non-SPL target.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-13 12:47 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-09 21:44 [U-Boot] [PATCH] mx6sabre: Do not enable UMS with SPL Fabio Estevam
2015-03-09 23:44 ` Tom Rini
2015-03-09 23:52 ` Fabio Estevam
2015-03-10 0:02 ` Tom Rini
2015-03-10 0:09 ` Fabio Estevam
2015-03-13 12:47 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.