From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Xiubo Li <lixiubo@cmss.chinamobile.com>, mtosatti@redhat.com
Cc: gleb@kernel.org, pbonzini@redhat.com, tglx@linutronix.de,
mingo@redhat.com, hpa@zytor.com, kvm@vger.kernel.org
Subject: Re: [PATCH 3/3] KVM: For the symbols used locally only should be static type.
Date: Fri, 13 Mar 2015 14:37:29 +0100 [thread overview]
Message-ID: <5502E819.7010609@de.ibm.com> (raw)
In-Reply-To: <1426239586-1369-4-git-send-email-lixiubo@cmss.chinamobile.com>
Am 13.03.2015 um 10:39 schrieb Xiubo Li:
> This patch fix the following sparse warnings:
>
> for file virt/kvm/kvm_main.c:
> warning: symbol 'halt_poll_ns' was not declared. Should it be static?
>
> Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
> ---
> virt/kvm/kvm_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index a109370..a23d2ba 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -66,7 +66,7 @@
> MODULE_AUTHOR("Qumranet");
> MODULE_LICENSE("GPL");
>
> -unsigned int halt_poll_ns = 0;
> +static unsigned int halt_poll_ns;
> module_param(halt_poll_ns, uint, S_IRUGO | S_IWUSR);
>
> /*
>
This change is already part of kvm/queue
https://git.kernel.org/cgit/virt/kvm/kvm.git/commit/?h=queue&id=0fa9778895635ab3824caf34fd573562dd2b999c
next prev parent reply other threads:[~2015-03-13 13:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-13 9:39 [PATCH 0/3] KVM: Fix sparse warnings Xiubo Li
2015-03-13 9:39 ` [PATCH 1/3] KVM: X86: Avoid using plain integer as NULL pointer warning Xiubo Li
2015-03-13 9:39 ` [PATCH 2/3] KVM: X86: For the symbols used locally only should be static type Xiubo Li
2015-03-13 9:39 ` [PATCH 3/3] KVM: " Xiubo Li
2015-03-13 13:37 ` Christian Borntraeger [this message]
2015-03-16 0:45 ` [PATCH 3/3] KVM: For the symbols used locally only should bestatic type Xiubo Li
2015-03-18 1:39 ` [PATCH 0/3] KVM: Fix sparse warnings Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5502E819.7010609@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=lixiubo@cmss.chinamobile.com \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.