* [Qemu-trivial] [PATCH] pci-assign: Fix warning from coverity (argument cannot be negative)
@ 2015-03-14 8:57 ` Stefan Weil
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2015-03-14 8:57 UTC (permalink / raw)
To: QEMU Trivial; +Cc: Stefan Weil, QEMU Developer
Coverity warns because function monitor_fd_param can return a negative
value which might be passed to function read.
This won't happen because dev->config_fd will only be negative (-1)
when local_err is set.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/i386/kvm/pci-assign.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index 9db7c77..f3d145b 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-assign.c
@@ -554,7 +554,7 @@ static void get_real_device(AssignedDevice *pci_dev, Error **errp)
if (pci_dev->configfd_name && *pci_dev->configfd_name) {
dev->config_fd = monitor_fd_param(cur_mon, pci_dev->configfd_name,
&local_err);
- if (local_err) {
+ if (dev->config_fd < 0) {
error_propagate(errp, local_err);
return;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH] pci-assign: Fix warning from coverity (argument cannot be negative)
@ 2015-03-14 8:57 ` Stefan Weil
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2015-03-14 8:57 UTC (permalink / raw)
To: QEMU Trivial; +Cc: Stefan Weil, QEMU Developer
Coverity warns because function monitor_fd_param can return a negative
value which might be passed to function read.
This won't happen because dev->config_fd will only be negative (-1)
when local_err is set.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/i386/kvm/pci-assign.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
index 9db7c77..f3d145b 100644
--- a/hw/i386/kvm/pci-assign.c
+++ b/hw/i386/kvm/pci-assign.c
@@ -554,7 +554,7 @@ static void get_real_device(AssignedDevice *pci_dev, Error **errp)
if (pci_dev->configfd_name && *pci_dev->configfd_name) {
dev->config_fd = monitor_fd_param(cur_mon, pci_dev->configfd_name,
&local_err);
- if (local_err) {
+ if (dev->config_fd < 0) {
error_propagate(errp, local_err);
return;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] pci-assign: Fix warning from coverity (argument cannot be negative)
2015-03-14 8:57 ` [Qemu-devel] " Stefan Weil
@ 2015-03-14 10:23 ` Shannon Zhao
-1 siblings, 0 replies; 4+ messages in thread
From: Shannon Zhao @ 2015-03-14 10:23 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial; +Cc: QEMU Developer
On 2015/3/14 16:57, Stefan Weil wrote:
> Coverity warns because function monitor_fd_param can return a negative
> value which might be passed to function read.
>
> This won't happen because dev->config_fd will only be negative (-1)
> when local_err is set.
Yes.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/i386/kvm/pci-assign.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index 9db7c77..f3d145b 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -554,7 +554,7 @@ static void get_real_device(AssignedDevice *pci_dev, Error **errp)
> if (pci_dev->configfd_name && *pci_dev->configfd_name) {
> dev->config_fd = monitor_fd_param(cur_mon, pci_dev->configfd_name,
> &local_err);
> - if (local_err) {
> + if (dev->config_fd < 0) {
> error_propagate(errp, local_err);
> return;
> }
>
This fix the coverity warning of dev->config_id. I'm not sure that this may introduce
another warning of not checking local_err.
--
Thanks,
Shannon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] pci-assign: Fix warning from coverity (argument cannot be negative)
@ 2015-03-14 10:23 ` Shannon Zhao
0 siblings, 0 replies; 4+ messages in thread
From: Shannon Zhao @ 2015-03-14 10:23 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial; +Cc: QEMU Developer
On 2015/3/14 16:57, Stefan Weil wrote:
> Coverity warns because function monitor_fd_param can return a negative
> value which might be passed to function read.
>
> This won't happen because dev->config_fd will only be negative (-1)
> when local_err is set.
Yes.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> hw/i386/kvm/pci-assign.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/kvm/pci-assign.c b/hw/i386/kvm/pci-assign.c
> index 9db7c77..f3d145b 100644
> --- a/hw/i386/kvm/pci-assign.c
> +++ b/hw/i386/kvm/pci-assign.c
> @@ -554,7 +554,7 @@ static void get_real_device(AssignedDevice *pci_dev, Error **errp)
> if (pci_dev->configfd_name && *pci_dev->configfd_name) {
> dev->config_fd = monitor_fd_param(cur_mon, pci_dev->configfd_name,
> &local_err);
> - if (local_err) {
> + if (dev->config_fd < 0) {
> error_propagate(errp, local_err);
> return;
> }
>
This fix the coverity warning of dev->config_id. I'm not sure that this may introduce
another warning of not checking local_err.
--
Thanks,
Shannon
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-14 10:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-14 8:57 [Qemu-trivial] [PATCH] pci-assign: Fix warning from coverity (argument cannot be negative) Stefan Weil
2015-03-14 8:57 ` [Qemu-devel] " Stefan Weil
2015-03-14 10:23 ` [Qemu-trivial] " Shannon Zhao
2015-03-14 10:23 ` Shannon Zhao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.