From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, Stefan Weil <sw@weilnetz.de>,
Shannon Zhao <zhaoshenglong@huawei.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
hangaohuai@huawei.com, peter.huangpeng@huawei.com,
shannon.zhao@linaro.org
Subject: Re: [Qemu-trivial] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity
Date: Sun, 15 Mar 2015 15:11:48 +0100 [thread overview]
Message-ID: <55059324.8030202@redhat.com> (raw)
In-Reply-To: <55055DBA.9040804@msgid.tls.msk.ru>
On 15/03/2015 11:23, Michael Tokarev wrote:
> Or, alternatively, to keep this `data' pointer in sdp to use it in
> bt_l2cap_sdp_close_ch().
Yes.
>> > In any case, it seems simpler to just leave this code aside.
> How many times this code is called?
>
> We have many many places in qemu where resources are allocated once
> at startup and never freed just because there's no need to.
Well, in this case the bug in bt_l2cap_sdp_close_ch is much worse than a
resource leak. But bluetooth is not the utmost priority in QEMU
development...
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>, Stefan Weil <sw@weilnetz.de>,
Shannon Zhao <zhaoshenglong@huawei.com>,
qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
hangaohuai@huawei.com, peter.huangpeng@huawei.com,
shannon.zhao@linaro.org
Subject: Re: [Qemu-devel] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity
Date: Sun, 15 Mar 2015 15:11:48 +0100 [thread overview]
Message-ID: <55059324.8030202@redhat.com> (raw)
In-Reply-To: <55055DBA.9040804@msgid.tls.msk.ru>
On 15/03/2015 11:23, Michael Tokarev wrote:
> Or, alternatively, to keep this `data' pointer in sdp to use it in
> bt_l2cap_sdp_close_ch().
Yes.
>> > In any case, it seems simpler to just leave this code aside.
> How many times this code is called?
>
> We have many many places in qemu where resources are allocated once
> at startup and never freed just because there's no need to.
Well, in this case the bug in bt_l2cap_sdp_close_ch is much worse than a
resource leak. But bluetooth is not the utmost priority in QEMU
development...
Paolo
next prev parent reply other threads:[~2015-03-15 14:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 9:47 [Qemu-trivial] [PATCH] hw/bt/sdp: Fix resource leak detect by coverity Shannon Zhao
2015-03-14 9:47 ` [Qemu-devel] " Shannon Zhao
2015-03-14 10:07 ` [Qemu-trivial] " Stefan Weil
2015-03-14 10:07 ` Stefan Weil
2015-03-15 9:21 ` [Qemu-trivial] " Paolo Bonzini
2015-03-15 9:21 ` [Qemu-devel] " Paolo Bonzini
2015-03-15 10:23 ` [Qemu-trivial] " Michael Tokarev
2015-03-15 10:23 ` [Qemu-devel] " Michael Tokarev
2015-03-15 14:11 ` Paolo Bonzini [this message]
2015-03-15 14:11 ` Paolo Bonzini
2015-03-16 7:29 ` [Qemu-trivial] " Markus Armbruster
2015-03-16 7:29 ` Markus Armbruster
2015-03-16 8:13 ` [Qemu-trivial] " Paolo Bonzini
2015-03-16 8:13 ` [Qemu-devel] " Paolo Bonzini
-- strict thread matches above, loose matches on Subject: below --
2015-03-14 3:42 [Qemu-trivial] " Shannon Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55059324.8030202@redhat.com \
--to=pbonzini@redhat.com \
--cc=hangaohuai@huawei.com \
--cc=mjt@tls.msk.ru \
--cc=peter.huangpeng@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=shannon.zhao@linaro.org \
--cc=sw@weilnetz.de \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.