From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] serial: sh-sci: Add overrun handling of SCIFA and SCIFB
Date: Sun, 15 Mar 2015 15:28:12 +0000 [thread overview]
Message-ID: <5505A50C.70802@cogentembedded.com> (raw)
In-Reply-To: <1426429695-2993-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 3/15/2015 5:28 PM, Yoshihiro Kaneko wrote:
> From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> SCIFA and SCIFB can detect the overrun, but it does not support.
> This adds overrun handling of SCIFA and SCIFB.
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
> tree.
> drivers/tty/serial/sh-sci.c | 34 +++++++++++++++++++++++-----------
> 1 file changed, 23 insertions(+), 11 deletions(-)
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 5b50c79..d165b21 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -844,14 +844,26 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
> struct tty_port *tport = &port->state->port;
> struct sci_port *s = to_sci_port(port);
> struct plat_sci_reg *reg;
> - int copied = 0;
> + int copied = 0, offset;
> + u16 status, bit;
> +
> + if (port->type = PORT_SCIF || port->type = PORT_HSCIF)
> + offset = SCLSR;
> + else if (port->type = PORT_SCIFA || port->type = PORT_SCIFB)
> + offset = SCxSR;
> + else
> + return 0;
This is asking to be a *switch* statement instead.
[...]
> @@ -1005,7 +1016,10 @@ static irqreturn_t sci_mpxed_interrupt(int irq, void *ptr)
> ssr_status = serial_port_in(port, SCxSR);
> scr_status = serial_port_in(port, SCSCR);
> if (port->type = PORT_SCIF || port->type = PORT_HSCIF)
> - slr_status = serial_port_in(port, SCLSR);
> + orer_status = serial_port_in(port, SCLSR);
> + else if (port->type = PORT_SCIFA || port->type = PORT_SCIFB)
> + orer_status = ssr_status;
This one too...
[...]
WBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] serial: sh-sci: Add overrun handling of SCIFA and SCIFB
Date: Sun, 15 Mar 2015 18:28:12 +0300 [thread overview]
Message-ID: <5505A50C.70802@cogentembedded.com> (raw)
In-Reply-To: <1426429695-2993-1-git-send-email-ykaneko0929@gmail.com>
Hello.
On 3/15/2015 5:28 PM, Yoshihiro Kaneko wrote:
> From: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> SCIFA and SCIFB can detect the overrun, but it does not support.
> This adds overrun handling of SCIFA and SCIFB.
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> This patch is based on the tty-next branch of Greg Kroah-Hartman's tty
> tree.
> drivers/tty/serial/sh-sci.c | 34 +++++++++++++++++++++++-----------
> 1 file changed, 23 insertions(+), 11 deletions(-)
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 5b50c79..d165b21 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -844,14 +844,26 @@ static int sci_handle_fifo_overrun(struct uart_port *port)
> struct tty_port *tport = &port->state->port;
> struct sci_port *s = to_sci_port(port);
> struct plat_sci_reg *reg;
> - int copied = 0;
> + int copied = 0, offset;
> + u16 status, bit;
> +
> + if (port->type == PORT_SCIF || port->type == PORT_HSCIF)
> + offset = SCLSR;
> + else if (port->type == PORT_SCIFA || port->type == PORT_SCIFB)
> + offset = SCxSR;
> + else
> + return 0;
This is asking to be a *switch* statement instead.
[...]
> @@ -1005,7 +1016,10 @@ static irqreturn_t sci_mpxed_interrupt(int irq, void *ptr)
> ssr_status = serial_port_in(port, SCxSR);
> scr_status = serial_port_in(port, SCSCR);
> if (port->type == PORT_SCIF || port->type == PORT_HSCIF)
> - slr_status = serial_port_in(port, SCLSR);
> + orer_status = serial_port_in(port, SCLSR);
> + else if (port->type == PORT_SCIFA || port->type == PORT_SCIFB)
> + orer_status = ssr_status;
This one too...
[...]
WBR, Sergei
next prev parent reply other threads:[~2015-03-15 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-15 14:28 [PATCH/RFC] serial: sh-sci: Add overrun handling of SCIFA and SCIFB Yoshihiro Kaneko
2015-03-15 14:28 ` Yoshihiro Kaneko
2015-03-15 15:28 ` Sergei Shtylyov [this message]
2015-03-15 15:28 ` Sergei Shtylyov
2015-03-16 13:55 ` Yoshihiro Kaneko
2015-03-16 13:55 ` Yoshihiro Kaneko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5505A50C.70802@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=horms@verge.net.au \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.