Re: [PATCH/RFC] media: soc_camera: rcar_vin: Fix wait_for_completion

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 03/15/2015 05:39 PM, Yoshihiro Kaneko wrote:

> From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>

> When stopping abnormally, a driver can't return from wait_for_completion.
> This patch resolved this problem by changing wait_for_completion_timeout
> from wait_for_completion.

> Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---

[...]

> diff --git a/drivers/media/platform/soc_camera/rcar_vin.c b/drivers/media/platform/soc_camera/rcar_vin.c
> index 279ab9f..ff0359b 100644
> --- a/drivers/media/platform/soc_camera/rcar_vin.c
> +++ b/drivers/media/platform/soc_camera/rcar_vin.c
[...]
> @@ -821,6 +823,10 @@ static void rcar_vin_wait_stop_streaming(struct rcar_vin_priv *priv)
>   			priv->request_to_stop = true;
>   			spin_unlock_irq(&priv->lock);
>   			wait_for_completion(&priv->capture_stop);

    You forgot to remove this line, as already noted.

> +			if (!wait_for_completion_timeout(
> +				&priv->capture_stop,
> +				msecs_to_jiffies(TIMEOUT_MS)))

    Please indent the above 2 lines more to the right, so that they're easier 
on the eyes with the following line.

> +				priv->state = STOPPED;
>   			spin_lock_irq(&priv->lock);
>   		}
>   	}

WBR, Sergei