* [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak
@ 2015-03-14 9:52 ` Shannon Zhao
0 siblings, 0 replies; 12+ messages in thread
From: Shannon Zhao @ 2015-03-14 9:52 UTC (permalink / raw)
To: qemu-devel
Cc: peter.maydell, hangaohuai, zhang.zhanghailiang, qemu-trivial, sw,
mjt, mdroth, peter.huangpeng, shannon.zhao, pbonzini
It's detected by coverity. Close the dirfd.
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
v1->v2: close after use [Stefan Weil]
---
qga/commands-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index d5bb5cb..ba8de62 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
buf = g_malloc0(20);
ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
+ close(dirfd);
if (local_err) {
g_free(buf);
error_propagate(errp, local_err);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* Re: [Qemu-trivial] [PATCH v2] qga/commands-posix: Fix resource leak
2015-03-14 9:52 ` [Qemu-devel] " Shannon Zhao
@ 2015-03-14 9:56 ` Stefan Weil
-1 siblings, 0 replies; 12+ messages in thread
From: Stefan Weil @ 2015-03-14 9:56 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel
Cc: peter.maydell, hangaohuai, zhang.zhanghailiang, qemu-trivial, mjt,
peter.huangpeng, shannon.zhao, pbonzini
Am 14.03.2015 um 10:52 schrieb Shannon Zhao:
> It's detected by coverity. Close the dirfd.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> v1->v2: close after use [Stefan Weil]
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index d5bb5cb..ba8de62 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>
> buf = g_malloc0(20);
> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
> + close(dirfd);
> if (local_err) {
> g_free(buf);
> error_propagate(errp, local_err);
Thanks.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak
@ 2015-03-14 9:56 ` Stefan Weil
0 siblings, 0 replies; 12+ messages in thread
From: Stefan Weil @ 2015-03-14 9:56 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel
Cc: peter.maydell, hangaohuai, zhang.zhanghailiang, qemu-trivial, mjt,
mdroth, peter.huangpeng, shannon.zhao, pbonzini
Am 14.03.2015 um 10:52 schrieb Shannon Zhao:
> It's detected by coverity. Close the dirfd.
>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> v1->v2: close after use [Stefan Weil]
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index d5bb5cb..ba8de62 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>
> buf = g_malloc0(20);
> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
> + close(dirfd);
> if (local_err) {
> g_free(buf);
> error_propagate(errp, local_err);
Thanks.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-trivial] [PATCH v2] qga/commands-posix: Fix resource leak
2015-03-14 9:56 ` [Qemu-devel] " Stefan Weil
@ 2015-03-16 4:17 ` Shannon Zhao
-1 siblings, 0 replies; 12+ messages in thread
From: Shannon Zhao @ 2015-03-16 4:17 UTC (permalink / raw)
To: Stefan Weil, qemu-devel
Cc: peter.maydell, hangaohuai, zhang.zhanghailiang, qemu-trivial, mjt,
peter.huangpeng, shannon.zhao, pbonzini
On 2015/3/14 17:56, Stefan Weil wrote:
> Am 14.03.2015 um 10:52 schrieb Shannon Zhao:
>> It's detected by coverity. Close the dirfd.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> v1->v2: close after use [Stefan Weil]
>> ---
>> qga/commands-posix.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>> index d5bb5cb..ba8de62 100644
>> --- a/qga/commands-posix.c
>> +++ b/qga/commands-posix.c
>> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>> buf = g_malloc0(20);
>> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
>> + close(dirfd);
>> if (local_err) {
>> g_free(buf);
>> error_propagate(errp, local_err);
>
> Thanks.
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
Hi Stefan,
Thanks for your review.
Shannon
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak
@ 2015-03-16 4:17 ` Shannon Zhao
0 siblings, 0 replies; 12+ messages in thread
From: Shannon Zhao @ 2015-03-16 4:17 UTC (permalink / raw)
To: Stefan Weil, qemu-devel
Cc: peter.maydell, hangaohuai, zhang.zhanghailiang, qemu-trivial, mjt,
mdroth, peter.huangpeng, shannon.zhao, pbonzini
On 2015/3/14 17:56, Stefan Weil wrote:
> Am 14.03.2015 um 10:52 schrieb Shannon Zhao:
>> It's detected by coverity. Close the dirfd.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> v1->v2: close after use [Stefan Weil]
>> ---
>> qga/commands-posix.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>> index d5bb5cb..ba8de62 100644
>> --- a/qga/commands-posix.c
>> +++ b/qga/commands-posix.c
>> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>> buf = g_malloc0(20);
>> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
>> + close(dirfd);
>> if (local_err) {
>> g_free(buf);
>> error_propagate(errp, local_err);
>
> Thanks.
>
> Reviewed-by: Stefan Weil <sw@weilnetz.de>
>
Hi Stefan,
Thanks for your review.
Shannon
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [PATCH v2] qga/commands-posix: Fix resource leak
2015-03-14 9:52 ` [Qemu-devel] " Shannon Zhao
@ 2015-03-16 1:27 ` zhanghailiang
-1 siblings, 0 replies; 12+ messages in thread
From: zhanghailiang @ 2015-03-16 1:27 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel
Cc: peter.maydell, hangaohuai, qemu-trivial, sw, mjt, peter.huangpeng,
shannon.zhao, pbonzini
On 2015/3/14 17:52, Shannon Zhao wrote:
> It's detected by coverity. Close the dirfd.
>
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> v1->v2: close after use [Stefan Weil]
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index d5bb5cb..ba8de62 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>
> buf = g_malloc0(20);
> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
> + close(dirfd);
> if (local_err) {
> g_free(buf);
> error_propagate(errp, local_err);
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak
@ 2015-03-16 1:27 ` zhanghailiang
0 siblings, 0 replies; 12+ messages in thread
From: zhanghailiang @ 2015-03-16 1:27 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel
Cc: peter.maydell, hangaohuai, qemu-trivial, sw, mjt, peter.huangpeng,
mdroth, shannon.zhao, pbonzini
On 2015/3/14 17:52, Shannon Zhao wrote:
> It's detected by coverity. Close the dirfd.
>
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
> ---
> v1->v2: close after use [Stefan Weil]
> ---
> qga/commands-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
> index d5bb5cb..ba8de62 100644
> --- a/qga/commands-posix.c
> +++ b/qga/commands-posix.c
> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>
> buf = g_malloc0(20);
> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
> + close(dirfd);
> if (local_err) {
> g_free(buf);
> error_propagate(errp, local_err);
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-trivial] [PATCH v2] qga/commands-posix: Fix resource leak
2015-03-16 1:27 ` [Qemu-devel] " zhanghailiang
@ 2015-03-16 4:18 ` Shannon Zhao
-1 siblings, 0 replies; 12+ messages in thread
From: Shannon Zhao @ 2015-03-16 4:18 UTC (permalink / raw)
To: zhanghailiang, qemu-devel
Cc: peter.maydell, hangaohuai, qemu-trivial, sw, mjt, peter.huangpeng,
shannon.zhao, pbonzini
On 2015/3/16 9:27, zhanghailiang wrote:
> On 2015/3/14 17:52, Shannon Zhao wrote:
>> It's detected by coverity. Close the dirfd.
>>
>
> Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>
Hi zhanghailiang,
Thanks for your review.
Shannon
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> v1->v2: close after use [Stefan Weil]
>> ---
>> qga/commands-posix.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>> index d5bb5cb..ba8de62 100644
>> --- a/qga/commands-posix.c
>> +++ b/qga/commands-posix.c
>> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>>
>> buf = g_malloc0(20);
>> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
>> + close(dirfd);
>> if (local_err) {
>> g_free(buf);
>> error_propagate(errp, local_err);
>>
>
>
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak
@ 2015-03-16 4:18 ` Shannon Zhao
0 siblings, 0 replies; 12+ messages in thread
From: Shannon Zhao @ 2015-03-16 4:18 UTC (permalink / raw)
To: zhanghailiang, qemu-devel
Cc: peter.maydell, hangaohuai, qemu-trivial, sw, mjt, peter.huangpeng,
mdroth, shannon.zhao, pbonzini
On 2015/3/16 9:27, zhanghailiang wrote:
> On 2015/3/14 17:52, Shannon Zhao wrote:
>> It's detected by coverity. Close the dirfd.
>>
>
> Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
>
Hi zhanghailiang,
Thanks for your review.
Shannon
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>> v1->v2: close after use [Stefan Weil]
>> ---
>> qga/commands-posix.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/qga/commands-posix.c b/qga/commands-posix.c
>> index d5bb5cb..ba8de62 100644
>> --- a/qga/commands-posix.c
>> +++ b/qga/commands-posix.c
>> @@ -2283,6 +2283,7 @@ GuestMemoryBlockInfo *qmp_guest_get_memory_block_info(Error **errp)
>>
>> buf = g_malloc0(20);
>> ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
>> + close(dirfd);
>> if (local_err) {
>> g_free(buf);
>> error_propagate(errp, local_err);
>>
>
>
>
> .
>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-trivial] [PATCH v2] qga/commands-posix: Fix resource leak
2015-03-14 9:52 ` [Qemu-devel] " Shannon Zhao
@ 2015-03-19 8:40 ` Michael Tokarev
-1 siblings, 0 replies; 12+ messages in thread
From: Michael Tokarev @ 2015-03-19 8:40 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel
Cc: peter.maydell, hangaohuai, zhang.zhanghailiang, qemu-trivial, sw,
peter.huangpeng, shannon.zhao, pbonzini
Applied to -trivial, thanks!
/mjt, who don't really expect another thanks! to his thanks!.. ;)
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH v2] qga/commands-posix: Fix resource leak
@ 2015-03-19 8:40 ` Michael Tokarev
0 siblings, 0 replies; 12+ messages in thread
From: Michael Tokarev @ 2015-03-19 8:40 UTC (permalink / raw)
To: Shannon Zhao, qemu-devel
Cc: peter.maydell, hangaohuai, zhang.zhanghailiang, qemu-trivial, sw,
peter.huangpeng, shannon.zhao, pbonzini
Applied to -trivial, thanks!
/mjt, who don't really expect another thanks! to his thanks!.. ;)
^ permalink raw reply [flat|nested] 12+ messages in thread