All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Holler <holler@ahsoftware.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [git pull] gadgetfs fixes
Date: Mon, 16 Mar 2015 11:11:49 +0100	[thread overview]
Message-ID: <5506AC65.4030703@ahsoftware.de> (raw)
In-Reply-To: <5505435D.5030103@ahsoftware.de>

Am 15.03.2015 um 09:31 schrieb Alexander Holler:
> Am 15.03.2015 um 09:17 schrieb Al Viro:
>> On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote:
>>
>>>> Umm...  If I'm not misparsing what you said, you are talking about the
>>>
>>> Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung mal
>>> mit meiner bevorzugten Sprache versuchen.
>>
>> Good.  I'll probably abstain from trying to mangle it, though.
>>
>> Another question, if you don't mind - does that series (i.e. what's
>> currently
>> in Linus' tree) fix the module refcount issues you'd been seeing?  I
>> agree
>> with your analysis of likely cause (->f_op reassignments with different
>> ->owner before and after) and these patches should have eliminated
>> that, but
>> confirmation would be nice...
>
> I haven't tried to apply the whole series to the 3.19.1 which I'm
> currently using. As mentioned before, something (a single patch I've
> tried before) didn't apply cleanly which means I need to have a deeper
> look at the stuff. E.g. I've just learned (through another problem),
> that (my version of) glibc still doesn't use the aio-syscalls the kernel
> provides (and instead uses pread/pwrite).
>
> I will look if I find the time today.

Also it's already merged, looks good. Please just don't forget to add that

value = -ENOMEM;

if commit f01d35a1 goes down the road without the following patches.

Thanks,

Alexander Holler


--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Holler <holler@ahsoftware.de>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [git pull] gadgetfs fixes
Date: Mon, 16 Mar 2015 11:11:49 +0100	[thread overview]
Message-ID: <5506AC65.4030703@ahsoftware.de> (raw)
In-Reply-To: <5505435D.5030103@ahsoftware.de>

Am 15.03.2015 um 09:31 schrieb Alexander Holler:
> Am 15.03.2015 um 09:17 schrieb Al Viro:
>> On Sun, Mar 15, 2015 at 07:35:20AM +0100, Alexander Holler wrote:
>>
>>>> Umm...  If I'm not misparsing what you said, you are talking about the
>>>
>>> Glücklicherweise nicht. Vielleicht sollten wir es zur Abwechslung mal
>>> mit meiner bevorzugten Sprache versuchen.
>>
>> Good.  I'll probably abstain from trying to mangle it, though.
>>
>> Another question, if you don't mind - does that series (i.e. what's
>> currently
>> in Linus' tree) fix the module refcount issues you'd been seeing?  I
>> agree
>> with your analysis of likely cause (->f_op reassignments with different
>> ->owner before and after) and these patches should have eliminated
>> that, but
>> confirmation would be nice...
>
> I haven't tried to apply the whole series to the 3.19.1 which I'm
> currently using. As mentioned before, something (a single patch I've
> tried before) didn't apply cleanly which means I need to have a deeper
> look at the stuff. E.g. I've just learned (through another problem),
> that (my version of) glibc still doesn't use the aio-syscalls the kernel
> provides (and instead uses pread/pwrite).
>
> I will look if I find the time today.

Also it's already merged, looks good. Please just don't forget to add that

value = -ENOMEM;

if commit f01d35a1 goes down the road without the following patches.

Thanks,

Alexander Holler



  reply	other threads:[~2015-03-16 10:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13 16:42 [git pull] gadgetfs fixes Al Viro
2015-03-15  0:39 ` Alexander Holler
2015-03-15  1:39   ` Al Viro
     [not found]     ` <20150315013948.GU29656-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2015-03-15  6:35       ` Alexander Holler
2015-03-15  6:35         ` Alexander Holler
2015-03-15  8:17         ` Al Viro
2015-03-15  8:31           ` Alexander Holler
2015-03-15  8:31             ` Alexander Holler
2015-03-16 10:11             ` Alexander Holler [this message]
2015-03-16 10:11               ` Alexander Holler
2015-03-15  8:50           ` Alexander Holler
2015-03-15  9:09             ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5506AC65.4030703@ahsoftware.de \
    --to=holler@ahsoftware.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.