All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: trigger panic on bad page or PTE states if panic_on_oops
Date: Mon, 16 Mar 2015 12:12:54 +0100	[thread overview]
Message-ID: <5506BAB6.3080104@de.ibm.com> (raw)
In-Reply-To: <20150316110033.GA20546@node.dhcp.inet.fi>

Am 16.03.2015 um 12:00 schrieb Kirill A. Shutemov:
> On Mon, Mar 16, 2015 at 09:37:01AM +0100, Christian Borntraeger wrote:
>> while debugging a memory management problem it helped a lot to
>> get a system dump as early as possible for bad page states.
>>
>> Lets assume that if panic_on_oops is set then the system should
>> not continue with broken mm data structures.
> 
> bed_pte is not an oops.

I know that this is not an oops, but semantically it is like one.  I certainly
want to a way to hard stop the system if something like that happens.

Would something like panic_on_mm_error be better?

> 
> Probably we should consider putting VM_BUG() at the end of these
> functions instead.

That is probably also a workable solution if I can reproduce the issue on
my system, but VM_BUG  defaults to off for many production systems (RHEL, SLES..)

Any other suggestion?

Christian

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: trigger panic on bad page or PTE states if panic_on_oops
Date: Mon, 16 Mar 2015 12:12:54 +0100	[thread overview]
Message-ID: <5506BAB6.3080104@de.ibm.com> (raw)
In-Reply-To: <20150316110033.GA20546@node.dhcp.inet.fi>

Am 16.03.2015 um 12:00 schrieb Kirill A. Shutemov:
> On Mon, Mar 16, 2015 at 09:37:01AM +0100, Christian Borntraeger wrote:
>> while debugging a memory management problem it helped a lot to
>> get a system dump as early as possible for bad page states.
>>
>> Lets assume that if panic_on_oops is set then the system should
>> not continue with broken mm data structures.
> 
> bed_pte is not an oops.

I know that this is not an oops, but semantically it is like one.  I certainly
want to a way to hard stop the system if something like that happens.

Would something like panic_on_mm_error be better?

> 
> Probably we should consider putting VM_BUG() at the end of these
> functions instead.

That is probably also a workable solution if I can reproduce the issue on
my system, but VM_BUG  defaults to off for many production systems (RHEL, SLES..)

Any other suggestion?

Christian


  reply	other threads:[~2015-03-16 11:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16  8:37 [PATCH] mm: trigger panic on bad page or PTE states if panic_on_oops Christian Borntraeger
2015-03-16  8:37 ` Christian Borntraeger
2015-03-16 11:00 ` Kirill A. Shutemov
2015-03-16 11:00   ` Kirill A. Shutemov
2015-03-16 11:12   ` Christian Borntraeger [this message]
2015-03-16 11:12     ` Christian Borntraeger
2015-03-16 12:15     ` Kirill A. Shutemov
2015-03-16 12:15       ` Kirill A. Shutemov
2015-03-17 17:19       ` Konstantin Khlebnikov
2015-03-17 17:19         ` Konstantin Khlebnikov
2015-03-17 19:40         ` Kirill A. Shutemov
2015-03-17 19:40           ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5506BAB6.3080104@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=kirill@shutemov.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.