From: "Andreas Färber" <afaerber@suse.de>
To: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Cc: Kukjin Kim <kgene@kernel.org>,
linux-samsung-soc@vger.kernel.org,
Doug Anderson <dianders@chromium.org>,
linux-kernel@vger.kernel.org, Andrzej Hajda <a.hajda@samsung.com>,
Olof Johansson <olof@lixom.net>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250
Date: Mon, 16 Mar 2015 13:15:01 +0100 [thread overview]
Message-ID: <5506C945.5030603@suse.de> (raw)
In-Reply-To: <1426320716-28137-1-git-send-email-javier.martinez@collabora.co.uk>
Am 14.03.2015 um 09:11 schrieb Javier Martinez Canillas:
> By making the DP controller a consumer of DISP1, the PD is powered
> off when the exynos-dp probe is deferred and powered on again when
> the exynos-drm driver is probed.
>
> But this causes the exynos-dp driver failing to obtain the stream
> clock since the FIMD has been powered off with the DISP1 PD:
>
> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok
> exynos-dp 145b0000.dp-controller: unable to config video
>
> The Exynos5250 documentation doesn't mention that the Display Port
> Transmitter module is included in the DISP1 PD so the device should
> not have a reference to this Power Domain.
>
> This patch fixes video display on an Exynos5250 Snow Chromebook.
>
> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250")
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Hello Andrzej and Marek,
>
> I need this patch to have display working on an Snow Chromebook
Tested-by: Andreas Färber <afaerber@suse.de>
This fixes the display on the Spring Chromebook as well!
Thanks,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG Nürnberg)
WARNING: multiple messages have this Message-ID (diff)
From: afaerber@suse.de (Andreas Färber)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250
Date: Mon, 16 Mar 2015 13:15:01 +0100 [thread overview]
Message-ID: <5506C945.5030603@suse.de> (raw)
In-Reply-To: <1426320716-28137-1-git-send-email-javier.martinez@collabora.co.uk>
Am 14.03.2015 um 09:11 schrieb Javier Martinez Canillas:
> By making the DP controller a consumer of DISP1, the PD is powered
> off when the exynos-dp probe is deferred and powered on again when
> the exynos-drm driver is probed.
>
> But this causes the exynos-dp driver failing to obtain the stream
> clock since the FIMD has been powered off with the DISP1 PD:
>
> exynos-dp 145b0000.dp-controller: Timeout of video streamclk ok
> exynos-dp 145b0000.dp-controller: unable to config video
>
> The Exynos5250 documentation doesn't mention that the Display Port
> Transmitter module is included in the DISP1 PD so the device should
> not have a reference to this Power Domain.
>
> This patch fixes video display on an Exynos5250 Snow Chromebook.
>
> Fixes: 2d2c9a8d0a4f ("ARM: dts: add display power domain for exynos5250")
> Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> ---
>
> Hello Andrzej and Marek,
>
> I need this patch to have display working on an Snow Chromebook
Tested-by: Andreas F?rber <afaerber@suse.de>
This fixes the display on the Spring Chromebook as well!
Thanks,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N?rnberg, Germany
GF: Felix Imend?rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu,
Graham Norton; HRB 21284 (AG N?rnberg)
next prev parent reply other threads:[~2015-03-16 12:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-14 8:11 [PATCH 1/1] ARM: dts: don't make DP a consumer of DISP1 on Exynos5250 Javier Martinez Canillas
2015-03-14 8:11 ` Javier Martinez Canillas
2015-03-14 8:11 ` Javier Martinez Canillas
2015-03-16 12:15 ` Andreas Färber [this message]
2015-03-16 12:15 ` Andreas Färber
2015-03-16 14:16 ` Javier Martinez Canillas
2015-03-16 14:16 ` Javier Martinez Canillas
2015-03-16 14:16 ` Javier Martinez Canillas
2015-03-16 17:36 ` Javier Martinez Canillas
2015-03-16 17:36 ` Javier Martinez Canillas
2015-03-23 16:11 ` Javier Martinez Canillas
2015-03-23 16:11 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5506C945.5030603@suse.de \
--to=afaerber@suse.de \
--cc=a.hajda@samsung.com \
--cc=dianders@chromium.org \
--cc=javier.martinez@collabora.co.uk \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.