Re: grub2: symlink on reiserfs: error: file not found

Re: grub2: symlink on reiserfs: error: file not found

[Christian Meyer]

Bean <bean123ch@gmail.com> schrieb am 25.02.2008 15:08:56:
> 
> On Mon, Feb 25, 2008 at 7:57 PM, Christian Meyer <c2h5oh@web.de> wrote:
> >
> >  The diskimage http://www.chbmeyer.de/1.reiserfs.gz has a size of 35 MB (compressed: 36kb).
> 
> The test file have problem, the link is pointed to /mnt/boot/test
> instead of /boot/test.

Oh, I'm really sorry about it, too stupid.
Fixed it with http://www.chbmeyer.de/1.reiserfs.gz

I used the symlink that caused the trouble:
cp -dp /media/hda3/vmlinuz /mnt/
and exchanged the kernel by a textfile.

Christian Meyer
_________________________________________________________________________
Mit der Gruppen-SMS von WEB.DE FreeMail können Sie eine SMS an alle 
Freunde gleichzeitig schicken: http://freemail.web.de/features/?mc=021179

Re: grub2: symlink on reiserfs: error: file not found

[Bean]

On Tue, Feb 26, 2008 at 3:09 AM, Christian Meyer <c2h5oh@web.de> wrote:
> Bean <bean123ch@gmail.com> schrieb am 25.02.2008 15:08:56:
>
> >
>  > On Mon, Feb 25, 2008 at 7:57 PM, Christian Meyer <c2h5oh@web.de> wrote:
>  > >
>
> > >  The diskimage http://www.chbmeyer.de/1.reiserfs.gz has a size of 35 MB (compressed: 36kb).
>  >
>
> > The test file have problem, the link is pointed to /mnt/boot/test
>  > instead of /boot/test.
>
>  Oh, I'm really sorry about it, too stupid.
>  Fixed it with http://www.chbmeyer.de/1.reiserfs.gz
>
>  I used the symlink that caused the trouble:
>  cp -dp /media/hda3/vmlinuz /mnt/
>  and exchanged the kernel by a textfile.

Ok, i found the bug, symbol link name in reiserfs is not null-ended,
so we need to add 0 at the end of string:

diff --git a/fs/reiserfs.c b/fs/reiserfs.c
index a4c60ca..60b6fe2 100644
--- a/fs/reiserfs.c
+++ b/fs/reiserfs.c
@@ -659,7 +659,7 @@ grub_reiserfs_read_symlink (grub_fshelp_node_t node)
            >> GRUB_DISK_SECTOR_BITS);
   offset = grub_le_to_cpu16 (found.header.item_location);

-  symlink_buffer = grub_malloc (len);
+  symlink_buffer = grub_malloc (len + 1);
   if (! symlink_buffer)
     goto fail;

@@ -667,6 +667,7 @@ grub_reiserfs_read_symlink (grub_fshelp_node_t node)
   if (grub_errno)
     goto fail;

+  symlink_buffer[len] = 0;
   return symlink_buffer;

  fail:



-- 
Bean

Re: grub2: symlink on reiserfs: error: file not found

[Yoshinori K. Okuji]

On Tuesday 26 February 2008 06:37, Bean wrote:
> On Tue, Feb 26, 2008 at 3:09 AM, Christian Meyer <c2h5oh@web.de> wrote:
> > Bean <bean123ch@gmail.com> schrieb am 25.02.2008 15:08:56:
> >  > On Mon, Feb 25, 2008 at 7:57 PM, Christian Meyer <c2h5oh@web.de> wrote:
> > > >  The diskimage http://www.chbmeyer.de/1.reiserfs.gz has a size of 35
> > > > MB (compressed: 36kb).
> > >
> > > The test file have problem, the link is pointed to /mnt/boot/test
> > >
> >  > instead of /boot/test.
> >
> >  Oh, I'm really sorry about it, too stupid.
> >  Fixed it with http://www.chbmeyer.de/1.reiserfs.gz
> >
> >  I used the symlink that caused the trouble:
> >  cp -dp /media/hda3/vmlinuz /mnt/
> >  and exchanged the kernel by a textfile.
>
> Ok, i found the bug, symbol link name in reiserfs is not null-ended,
> so we need to add 0 at the end of string:

Great. :)

Okuji

Re: grub2: symlink on reiserfs: error: file not found

[Bean]

Committed.

-- 
Bean

Re: grub2: symlink on reiserfs: error: file not found

[Christian Meyer]

Robert Millan <rmh@aybabtu.com> schrieb am 24.04.2008 10:17:32:
> On Tue, Apr 22, 2008 at 11:34:38PM +0200, Christian Meyer wrote:
> > Bean <bean123ch@gmail.com> schrieb am 26.02.2008 06:37:47:
> > 
> > > Ok, i found the bug, symbol link name in reiserfs is not null-ended,
> > > so we need to add 0 at the end of string:

> > I cannot confirm that the bug is gone

> Please provide a filesystem image where we can reproduce this

Here it is:
http://chbmeyer.de/image.reiserfs.gz

created with:
cp -dp /vmlinuz /mnt/
cp -dp /initrd.img /mnt/
echo "testfile 1" > /mnt/boot/vmlinuz-2.6.18-6-k7
echo "testfile 2" > /mnt/boot/initrd.img-2.6.18-6-k7

Christian
_______________________________________________________________
Schon gehört? Der neue WEB.DE MultiMessenger kann`s mit allen: 
http://www.produkte.web.de/messenger/?did=3016

Re: grub2: symlink on reiserfs: error: file not found

[Bean]

On Thu, Apr 24, 2008 at 5:38 PM, Christian Meyer <c2h5oh@web.de> wrote:
> Robert Millan <rmh@aybabtu.com> schrieb am 24.04.2008 10:17:32:
>
> > On Tue, Apr 22, 2008 at 11:34:38PM +0200, Christian Meyer wrote:
>  > > Bean <bean123ch@gmail.com> schrieb am 26.02.2008 06:37:47:
>  > >
>  > > > Ok, i found the bug, symbol link name in reiserfs is not null-ended,
>  > > > so we need to add 0 at the end of string:
>
>
> > > I cannot confirm that the bug is gone
>
>
> > Please provide a filesystem image where we can reproduce this
>
>  Here it is:
>  http://chbmeyer.de/image.reiserfs.gz
>
>  created with:
>  cp -dp /vmlinuz /mnt/
>  cp -dp /initrd.img /mnt/
>  echo "testfile 1" > /mnt/boot/vmlinuz-2.6.18-6-k7
>  echo "testfile 2" > /mnt/boot/initrd.img-2.6.18-6-k7

Hi,

I just test your image using qemu and it works well, are you sure it's
not working on your side ?

-- 
Bean

Re: grub2: symlink on reiserfs: error: file not found

[Christian Meyer]

Bean <bean123ch@gmail.com> schrieb am 26.02.2008 06:37:47:

> Ok, i found the bug, symbol link name in reiserfs is not null-ended,
> so we need to add 0 at the end of string:

I am no programmer, so I had to wait for this:
Robert Millan closed the bug at Debian bug tracking system:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467025
but I cannot confirm that the bug is gone in Debians current (sid) version: 1.96+20080413-1

The standard-install of the mentioned version links directly to kernel and ramdisk, so it works.
But if you change grub.cfg to load kernel and ramdisk via symlink the error still exists:

menuentry "Debian GNU/Linux (4.0) (on /dev/hda3)" {
	set root=(hd0,3)
	linux /vmlinuz root=/dev/hda3 ramdisk_size=100000 lang=de apm=power-off nomce vga=0x317 quiet noresume splash 
	initrd /initrd.img
}

results in:
error: you must load the kernel first

typing the commands manually at grub-prompt leads to
error: file not found
after the linux /vmlinuz ... line.


An interesting behavior of the older version (before February 25, 2008) seems to be gone:
(I discovered it after you committed your changes so I thought it is useless) 
If you waited for the boot-countdown the symlinks worked as expected (system-boot), but
if you selected the same line manually (e.g. by just pressing enter) leads to
error: you must load the kernel first

Please let me know if I can provide additional information.
Christian
_____________________________________________________________________
Unbegrenzter Speicherplatz für Ihr E-Mail Postfach? Jetzt aktivieren!
http://freemail.web.de/club/landingpage.htm/?mc=025555

Re: grub2: symlink on reiserfs: error: file not found

[Robert Millan]

On Tue, Apr 22, 2008 at 11:34:38PM +0200, Christian Meyer wrote:
> Bean <bean123ch@gmail.com> schrieb am 26.02.2008 06:37:47:
> 
> > Ok, i found the bug, symbol link name in reiserfs is not null-ended,
> > so we need to add 0 at the end of string:
> 
> I am no programmer, so I had to wait for this:
> Robert Millan closed the bug at Debian bug tracking system:
> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=467025
> but I cannot confirm that the bug is gone in Debians current (sid) version: 1.96+20080413-1
> 
> The standard-install of the mentioned version links directly to kernel and ramdisk, so it works.
> But if you change grub.cfg to load kernel and ramdisk via symlink the error still exists:
> 
> menuentry "Debian GNU/Linux (4.0) (on /dev/hda3)" {
> 	set root=(hd0,3)
> 	linux /vmlinuz root=/dev/hda3 ramdisk_size=100000 lang=de apm=power-off nomce vga=0x317 quiet noresume splash 
> 	initrd /initrd.img
> }
> 
> results in:
> error: you must load the kernel first
> 
> typing the commands manually at grub-prompt leads to
> error: file not found
> after the linux /vmlinuz ... line.
> 
> 
> An interesting behavior of the older version (before February 25, 2008) seems to be gone:
> (I discovered it after you committed your changes so I thought it is useless) 
> If you waited for the boot-countdown the symlinks worked as expected (system-boot), but
> if you selected the same line manually (e.g. by just pressing enter) leads to
> error: you must load the kernel first
> 
> Please let me know if I can provide additional information.

Please provide a filesystem image where we can reproduce this

-- 
Robert Millan

"The technological evasion of the license is as unacceptable as the
 legal evasion of the license [...].  That's the provision in section
 1 regarding keys. [...]  We say one thing: when you sell somebody a
 home... give him the keys"  -- Eben Moglen on GPLv3

Re: grub2: symlink on reiserfs: error: file not found

[Christian Meyer]

Vincent Pelletier <plr.vincent@gmail.com> schrieb am 25.02.2008 23:58:37:
> 
> Le Monday 25 February 2008 15:08:31 Bean, vous avez écrit :
> > The test file have problem, the link is pointed to /mnt/boot/test
> > instead of /boot/test.
> 
> BTW, I wonder if the initial problam is similar...
> Christian: can you double-check that the symlink is consistent with its 
> containing partition ?
> For example, having a partition mounted on /boot with symlinks inside it which 
> are absolute from OS point of view will be broken from grub point of view, as 
> it has no fstab notion.
> Of course, if you don't have a separate /boot partition, having an absolute 
> symlink should work, and if it doesn't it's a bug.

I want grub to be independent from any OS installed:
grub1 is on hda1, grub2 on hda9.

Debians '/boot/' and '/' (containing the symlink) lives on hda3
cat /etc/fstab | grep boot
cat /etc/fstab | grep hda1
cat /etc/fstab | grep hda9
there is no entry (boot, hda1 or hda9) in (hda3)/etc/fstab

grub1 (sees it from hda1) works with symlink 'vmlinuz', grub2 (from hda9) doesn't.
But grub2 works properly with symlink 'initrd.img' on the same partition, created by the same Debian-script.

Booting from hda3:
ls -l /
lrwxrwxrwx   1 root root     27 2008-01-30 18:21 initrd.img -> boot/initrd.img-2.6.18-6-k7
lrwxrwxrwx   1 root root     24 2008-01-30 18:21 vmlinuz -> boot/vmlinuz-2.6.18-6-k7

Booting from Kanotix-Live-CD:
ls -l /media/hda3
lrwxrwxrwx   1 root root     27 2008-01-30 18:21 initrd.img -> boot/initrd.img-2.6.18-6-k7
lrwxrwxrwx   1 root root     24 2008-01-30 18:21 vmlinuz -> boot/vmlinuz-2.6.18-6-k7

Christian
_______________________________________
GRATIS: Movie-FLAT. Jetzt freischalten!
http://freemail.web.de/club/maxdome.htm

grub2: symlink on reiserfs: error: file not found

[Christian Meyer]

>> I'm using grub-pc installed on hda9 and chainloaded from grub legacy on hda/hda1.
>> hda3 (Debian Etch) and hda9 (Debian Sid) have reiserfs (v3.6), both systems are configured to use the 
>> symlinks vmlinuz and initrd.img in their root directories (linking to the actual kernel and 
>> ramdisk). This works well using grub legacy from hda1 (so the symlinks are okay).
>> 
>> In grub2 both partitions are recognized (ls and tab completion) as reiserfs.
>> Selecting Sid (hda9) works as expected,
>> Selecting Etch (hda3) produces the error: You need to load the ramdisk first.
>> Typing on grub commandline: linux (hd0,3)/vmlinuz makes error: file not found
>> Typing: linux (hd0,3)/boot/vmlinuz-2.6.18-6-k7 loads the kernel.

Robert Millan asked me to produce a test case and send it to this mailinglist.
I'm not very familiar with doing so but this should work:

echo "Testfile" >/boot/test
ln -s /boot/test /test

The diskimage http://www.chbmeyer.de/1.reiserfs.gz has a size of 35 MB (compressed: 36kb).
"ls (hd0)/" works well
"cat (hd0)/test" produces: error: file not found

Thank you for your great work
Christian Meyer
_____________________________________________________________________
Unbegrenzter Speicherplatz für Ihr E-Mail Postfach? Jetzt aktivieren!
http://www.digitaledienste.web.de/freemail/club/lp/?lp=7

Re: grub2: symlink on reiserfs: error: file not found

[Bean]

On Mon, Feb 25, 2008 at 7:57 PM, Christian Meyer <c2h5oh@web.de> wrote:
> >> I'm using grub-pc installed on hda9 and chainloaded from grub legacy on hda/hda1.
>  >> hda3 (Debian Etch) and hda9 (Debian Sid) have reiserfs (v3.6), both systems are configured to use the
>  >> symlinks vmlinuz and initrd.img in their root directories (linking to the actual kernel and
>  >> ramdisk). This works well using grub legacy from hda1 (so the symlinks are okay).
>  >>
>  >> In grub2 both partitions are recognized (ls and tab completion) as reiserfs.
>  >> Selecting Sid (hda9) works as expected,
>  >> Selecting Etch (hda3) produces the error: You need to load the ramdisk first.
>  >> Typing on grub commandline: linux (hd0,3)/vmlinuz makes error: file not found
>  >> Typing: linux (hd0,3)/boot/vmlinuz-2.6.18-6-k7 loads the kernel.
>
>  Robert Millan asked me to produce a test case and send it to this mailinglist.
>  I'm not very familiar with doing so but this should work:
>
>  echo "Testfile" >/boot/test
>  ln -s /boot/test /test
>
>  The diskimage http://www.chbmeyer.de/1.reiserfs.gz has a size of 35 MB (compressed: 36kb).
>  "ls (hd0)/" works well
>  "cat (hd0)/test" produces: error: file not found
>

The test file have problem, the link is pointed to /mnt/boot/test
instead of /boot/test.

-- 
Bean

Re: grub2: symlink on reiserfs: error: file not found

[Vincent Pelletier]

Le Monday 25 February 2008 15:08:31 Bean, vous avez écrit :
> The test file have problem, the link is pointed to /mnt/boot/test
> instead of /boot/test.

BTW, I wonder if the initial problam is similar...
Christian: can you double-check that the symlink is consistent with its 
containing partition ?
For example, having a partition mounted on /boot with symlinks inside it which 
are absolute from OS point of view will be broken from grub point of view, as 
it has no fstab notion.
Of course, if you don't have a separate /boot partition, having an absolute 
symlink should work, and if it doesn't it's a bug.

Vincent