Re: [PATCH v2 2/4] xen: sched: make counters for vCPU sleep and wakeup generic

[George Dunlap <george.dunlap@eu.citrix.com>]

On 03/17/2015 10:48 AM, Dario Faggioli wrote:
> On Mon, 2015-03-16 at 17:18 +0000, George Dunlap wrote:
>> On 02/27/2015 04:51 PM, Dario Faggioli wrote:
> 
> 
>>> diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
>>> index ad0a5d4..2b852cc 100644
>>> --- a/xen/common/sched_credit2.c
>>> +++ b/xen/common/sched_credit2.c
>>> @@ -931,6 +931,7 @@ csched2_vcpu_sleep(const struct scheduler *ops, struct vcpu *vc)
>>>      struct csched2_vcpu * const svc = CSCHED2_VCPU(vc);
>>>  
>>>      BUG_ON( is_idle_vcpu(vc) );
>>> +    SCHED_STAT_CRANK(vcpu_sleep);
>>>  
>>>      if ( per_cpu(schedule_data, vc->processor).curr == vc )
>>>          cpu_raise_softirq(vc->processor, SCHEDULE_SOFTIRQ);
>>> @@ -956,19 +957,22 @@ csched2_vcpu_wake(const struct scheduler *ops, struct vcpu *vc)
>>>  
>>>      BUG_ON( is_idle_vcpu(vc) );
>>>  
>>> -    /* Make sure svc priority mod happens before runq check */
>>>      if ( unlikely(per_cpu(schedule_data, vc->processor).curr == vc) )
>>>      {
>>> +        SCHED_STAT_CRANK(vcpu_wake_running);
>>>          goto out;
>>>      }
>>> -
>>>      if ( unlikely(__vcpu_on_runq(svc)) )
>>
>> Does this make the 'if' butt right up against the '{'?  Is that bad?
>>
>> Other than that:
>>
>> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
>>
> As far as I can see, the series is in:
> 
> http://xenbits.xen.org/gitweb/?p=xen.git;a=commit;h=8b0e94da0e23221a6d7ea19bfbd24a407db44de8
> 
> and whoever committed it (Jan, probably?), took care of leaving that
> blank line in place, which I'm fine with, of course. :-)

Sweet. :-)

 -George