From: Kukjin Kim <kgene@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH v4 1/3] ARM: EXYNOS: Add missing static to file-scope declarations
Date: Wed, 18 Mar 2015 02:33:53 +0900 [thread overview]
Message-ID: <55086581.3010106@kernel.org> (raw)
In-Reply-To: <1426072121-6822-1-git-send-email-k.kozlowski@samsung.com>
On 03/11/15 20:08, Krzysztof Kozlowski wrote:
> The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs'
> and 'exynos5420_release_ret_regs' are not exported nor used outside of
> suspend.c file. Make them static.
>
> This fixes following sparse warnings:
> arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static?
> arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static?
> arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static?
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
Applied this whole series.
Thanks,
Kukjin
WARNING: multiple messages have this Message-ID (diff)
From: kgene@kernel.org (Kukjin Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] ARM: EXYNOS: Add missing static to file-scope declarations
Date: Wed, 18 Mar 2015 02:33:53 +0900 [thread overview]
Message-ID: <55086581.3010106@kernel.org> (raw)
In-Reply-To: <1426072121-6822-1-git-send-email-k.kozlowski@samsung.com>
On 03/11/15 20:08, Krzysztof Kozlowski wrote:
> The 'pm_data', 'exynos_release_ret_regs', 'exynos3250_release_ret_regs'
> and 'exynos5420_release_ret_regs' are not exported nor used outside of
> suspend.c file. Make them static.
>
> This fixes following sparse warnings:
> arch/arm/mach-exynos/suspend.c:83:23: warning: symbol 'pm_data' was not declared. Should it be static?
> arch/arm/mach-exynos/suspend.c:106:14: warning: symbol 'exynos_release_ret_regs' was not declared. Should it be static?
> arch/arm/mach-exynos/suspend.c:117:14: warning: symbol 'exynos5420_release_ret_regs' was not declared. Should it be static?
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
Applied this whole series.
Thanks,
Kukjin
next prev parent reply other threads:[~2015-03-17 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 11:08 [PATCH v4 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Krzysztof Kozlowski
2015-03-11 11:08 ` Krzysztof Kozlowski
2015-03-11 11:08 ` [PATCH v4 2/3] ARM: EXYNOS: Constify exynos_pm_data array Krzysztof Kozlowski
2015-03-11 11:08 ` Krzysztof Kozlowski
2015-03-11 11:08 ` [PATCH v4 3/3] ARM: EXYNOS: Remove left over 'extra_save' Krzysztof Kozlowski
2015-03-11 11:08 ` Krzysztof Kozlowski
2015-03-17 17:33 ` Kukjin Kim [this message]
2015-03-17 17:33 ` [PATCH v4 1/3] ARM: EXYNOS: Add missing static to file-scope declarations Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55086581.3010106@kernel.org \
--to=kgene@kernel.org \
--cc=arnd@arndb.de \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=olof@lixom.net \
--cc=pankaj.dubey@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.