All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com,
	qemu-trivial@nongnu.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
	peter.huangpeng@huawei.com, shannon.zhao@linaro.org,
	pbonzini@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/net/e1000: fix integer endianness
Date: Wed, 18 Mar 2015 09:28:36 +0800	[thread overview]
Message-ID: <5508D4C4.5030509@huawei.com> (raw)
In-Reply-To: <20150317170545.GA13669@stefanha-thinkpad.redhat.com>

On 2015/3/18 1:05, Stefan Hajnoczi wrote:
> On Fri, Mar 13, 2015 at 01:21:59PM +0800, Shannon Zhao wrote:
>> It's detected by coverity.In is_vlan_packet s->mac_reg[VET] is
>> unsigned int but is dereferenced as a narrower unsigned short.
>> This may lead to unexpected results depending on machine
>> endianness.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>>  hw/net/e1000.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Thanks, applied to my net tree:
> https://github.com/stefanha/qemu/commits/net
> 

Thanks :-)

Shannon



WARNING: multiple messages have this Message-ID (diff)
From: Shannon Zhao <zhaoshenglong@huawei.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com,
	qemu-trivial@nongnu.org, mjt@tls.msk.ru, qemu-devel@nongnu.org,
	peter.huangpeng@huawei.com, shannon.zhao@linaro.org,
	pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH] hw/net/e1000: fix integer endianness
Date: Wed, 18 Mar 2015 09:28:36 +0800	[thread overview]
Message-ID: <5508D4C4.5030509@huawei.com> (raw)
In-Reply-To: <20150317170545.GA13669@stefanha-thinkpad.redhat.com>

On 2015/3/18 1:05, Stefan Hajnoczi wrote:
> On Fri, Mar 13, 2015 at 01:21:59PM +0800, Shannon Zhao wrote:
>> It's detected by coverity.In is_vlan_packet s->mac_reg[VET] is
>> unsigned int but is dereferenced as a narrower unsigned short.
>> This may lead to unexpected results depending on machine
>> endianness.
>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>>  hw/net/e1000.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Thanks, applied to my net tree:
> https://github.com/stefanha/qemu/commits/net
> 

Thanks :-)

Shannon

  reply	other threads:[~2015-03-18  1:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-13  5:21 [Qemu-trivial] [PATCH] hw/net/e1000: fix integer endianness Shannon Zhao
2015-03-13  5:21 ` [Qemu-devel] " Shannon Zhao
2015-03-13 12:51 ` [Qemu-trivial] " Paolo Bonzini
2015-03-13 12:51   ` [Qemu-devel] " Paolo Bonzini
2015-03-17 17:05 ` [Qemu-trivial] " Stefan Hajnoczi
2015-03-17 17:05   ` Stefan Hajnoczi
2015-03-18  1:28   ` Shannon Zhao [this message]
2015-03-18  1:28     ` Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5508D4C4.5030509@huawei.com \
    --to=zhaoshenglong@huawei.com \
    --cc=hangaohuai@huawei.com \
    --cc=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=peter.huangpeng@huawei.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=shannon.zhao@linaro.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.