From: Vlastimil Babka <vbabka@suse.cz>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/1 linux-next] mm/page_alloc.c: don't redeclare mt in get_pageblock_migratetype()
Date: Wed, 18 Mar 2015 14:44:25 +0100 [thread overview]
Message-ID: <55098139.7090206@suse.cz> (raw)
In-Reply-To: <1426097333-24131-1-git-send-email-fabf@skynet.be>
On 03/11/2015 07:08 PM, Fabian Frederick wrote:
> mt is already declared above and global value not used after loop.
> This fixes a shadow warning.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1b84950..4ec8c23 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1653,7 +1653,7 @@ int __isolate_free_page(struct page *page, unsigned int order)
> if (order >= pageblock_order - 1) {
> struct page *endpage = page + (1 << order) - 1;
> for (; page < endpage; page += pageblock_nr_pages) {
> - int mt = get_pageblock_migratetype(page);
> + mt = get_pageblock_migratetype(page);
> if (!is_migrate_isolate(mt) && !is_migrate_cma(mt))
> set_pageblock_migratetype(page,
> MIGRATE_MOVABLE);
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: Re: [PATCH 1/1 linux-next] mm/page_alloc.c: don't redeclare mt in get_pageblock_migratetype()
Date: Wed, 18 Mar 2015 14:44:25 +0100 [thread overview]
Message-ID: <55098139.7090206@suse.cz> (raw)
In-Reply-To: <1426097333-24131-1-git-send-email-fabf@skynet.be>
On 03/11/2015 07:08 PM, Fabian Frederick wrote:
> mt is already declared above and global value not used after loop.
> This fixes a shadow warning.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
> ---
> mm/page_alloc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 1b84950..4ec8c23 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -1653,7 +1653,7 @@ int __isolate_free_page(struct page *page, unsigned int order)
> if (order >= pageblock_order - 1) {
> struct page *endpage = page + (1 << order) - 1;
> for (; page < endpage; page += pageblock_nr_pages) {
> - int mt = get_pageblock_migratetype(page);
> + mt = get_pageblock_migratetype(page);
> if (!is_migrate_isolate(mt) && !is_migrate_cma(mt))
> set_pageblock_migratetype(page,
> MIGRATE_MOVABLE);
>
next prev parent reply other threads:[~2015-03-18 13:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 18:08 [PATCH 1/1 linux-next] mm/page_alloc.c: don't redeclare mt in get_pageblock_migratetype() Fabian Frederick
2015-03-11 18:08 ` Fabian Frederick
2015-03-18 13:44 ` Vlastimil Babka [this message]
2015-03-18 13:44 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55098139.7090206@suse.cz \
--to=vbabka@suse.cz \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.