From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error
Date: Wed, 18 Mar 2015 10:23:36 -0400 [thread overview]
Message-ID: <55098A68.2090907@redhat.com> (raw)
In-Reply-To: <871tkmkcej.fsf@blackfin.pond.sub.org>
On 03/18/2015 03:11 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
>
>> A thinko that clang 3.5.0 caught.
>> Thankfully does not introduce any new failures.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
> How you caught the bug is interesting enough to be mentioned in the
> commit message, but the nature of the bug surely is more interesting
> than that. Suggest to change the subject to
>
> qtest/ahci: Fix a bit mask expression
>
> Perhaps it can be fixed up on commit.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
If it goes in through trivial,
can we change this to Markus's suggestion?
Thank you,
--js
WARNING: multiple messages have this Message-ID (diff)
From: John Snow <jsnow@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] qtest/ahci: Fix clang 3.5.0 error
Date: Wed, 18 Mar 2015 10:23:36 -0400 [thread overview]
Message-ID: <55098A68.2090907@redhat.com> (raw)
In-Reply-To: <871tkmkcej.fsf@blackfin.pond.sub.org>
On 03/18/2015 03:11 AM, Markus Armbruster wrote:
> John Snow <jsnow@redhat.com> writes:
>
>> A thinko that clang 3.5.0 caught.
>> Thankfully does not introduce any new failures.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>
> How you caught the bug is interesting enough to be mentioned in the
> commit message, but the nature of the bug surely is more interesting
> than that. Suggest to change the subject to
>
> qtest/ahci: Fix a bit mask expression
>
> Perhaps it can be fixed up on commit.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
>
If it goes in through trivial,
can we change this to Markus's suggestion?
Thank you,
--js
next prev parent reply other threads:[~2015-03-18 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 20:58 [Qemu-trivial] [PATCH] qtest/ahci: Fix clang 3.5.0 error John Snow
2015-03-17 20:58 ` [Qemu-devel] " John Snow
2015-03-18 7:11 ` [Qemu-trivial] [Qemu-block] " Markus Armbruster
2015-03-18 7:11 ` [Qemu-devel] " Markus Armbruster
2015-03-18 14:23 ` John Snow [this message]
2015-03-18 14:23 ` John Snow
2015-03-19 8:28 ` [Qemu-trivial] " Michael Tokarev
2015-03-19 8:28 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55098A68.2090907@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.