From: Alexander Sverdlin <alexander.sverdlin@nokia.com>
To: ext David Daney <ddaney@caviumnetworks.com>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, David Daney <ddaney@cavium.com>,
ddaney.cavm@gmail.com, "ext Daney,
David" <David.Daney@caviumnetworks.com>,
Rob Herring <robh@kernel.org>, Jiri Kosina <jkosina@suse.cz>,
Randy Dunlap <rdunlap@infradead.org>,
Masanari Iida <standby24x7@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rulf, Mathias (Nokia - DE/Ulm)" <mathias.rulf@nokia.com>
Subject: Re: [PATCH] pci: octeon: Remove udelay() causing huge IRQ latency
Date: Wed, 18 Mar 2015 17:17:04 +0100 [thread overview]
Message-ID: <5509A500.7020109@nokia.com> (raw)
In-Reply-To: <5509A39C.6010707@caviumnetworks.com>
Hello David,
On 18/03/15 17:11, ext David Daney wrote:
>> udelay() in PCI/PCIe read/write callbacks cause 30ms IRQ latency on Octeon
>> platforms because these operations are called from PCI_OP_READ() and
>> PCI_OP_WRITE() under raw_spin_lock_irqsave().
>>
>> Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
>
> Can you say how it was tested. In principle I have no objections, but it would be nice to know how it was validated.
What do you want to know, how we've debugged IRQ latency and found the root cause or how we figured out
that delay is not necessary? I'm pretty sure that there is HW which requires it. Maybe it's even Octeon itself...
But putting udelay() in this callbacks is wrong wrong wrong.
--
Best regards,
Alexander Sverdlin.
next prev parent reply other threads:[~2015-03-18 16:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 13:05 [PATCH] pci: octeon: Remove udelay() causing huge IRQ latency Alexander Sverdlin
2015-03-18 13:11 ` Jiri Kosina
2015-03-18 14:15 ` Alexander Sverdlin
2015-03-18 16:11 ` David Daney
2015-03-18 16:11 ` David Daney
2015-03-18 16:17 ` Alexander Sverdlin [this message]
2015-03-18 18:06 ` Aaro Koskinen
2015-03-19 14:55 ` Alexander Sverdlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5509A500.7020109@nokia.com \
--to=alexander.sverdlin@nokia.com \
--cc=David.Daney@caviumnetworks.com \
--cc=bhelgaas@google.com \
--cc=ddaney.cavm@gmail.com \
--cc=ddaney@cavium.com \
--cc=ddaney@caviumnetworks.com \
--cc=jkosina@suse.cz \
--cc=linux-mips@linux-mips.org \
--cc=mathias.rulf@nokia.com \
--cc=ralf@linux-mips.org \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
--cc=standby24x7@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.