All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] vl: fix resource leak with monitor_fdset_add_fd
Date: Thu, 19 Mar 2015 11:22:45 +0300	[thread overview]
Message-ID: <550A8755.60308@msgid.tls.msk.ru> (raw)
In-Reply-To: <1426172243-7830-1-git-send-email-pbonzini@redhat.com>

12.03.2015 17:57, Paolo Bonzini wrote:
> monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
> command add_fd).  Free it.

Applied to -trivial, with a tiny change:

> +    fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : false,
> +                                  fd_opaque, NULL);

    fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id,
                                  fd_opaque ? true : false, fd_opaque, NULL);

(this fits in 80 chars a line).  Another variant is to use `fd_opaque != NULL' here
instead of this ?true:false construct.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vl: fix resource leak with monitor_fdset_add_fd
Date: Thu, 19 Mar 2015 11:22:45 +0300	[thread overview]
Message-ID: <550A8755.60308@msgid.tls.msk.ru> (raw)
In-Reply-To: <1426172243-7830-1-git-send-email-pbonzini@redhat.com>

12.03.2015 17:57, Paolo Bonzini wrote:
> monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
> command add_fd).  Free it.

Applied to -trivial, with a tiny change:

> +    fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id, fd_opaque ? true : false,
> +                                  fd_opaque, NULL);

    fdinfo = monitor_fdset_add_fd(dupfd, true, fdset_id,
                                  fd_opaque ? true : false, fd_opaque, NULL);

(this fits in 80 chars a line).  Another variant is to use `fd_opaque != NULL' here
instead of this ?true:false construct.

Thanks,

/mjt

  parent reply	other threads:[~2015-03-19  8:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-12 14:57 [Qemu-trivial] [PATCH] vl: fix resource leak with monitor_fdset_add_fd Paolo Bonzini
2015-03-12 14:57 ` [Qemu-devel] " Paolo Bonzini
2015-03-12 16:42 ` [Qemu-trivial] " Eric Blake
2015-03-12 16:42   ` Eric Blake
2015-03-12 23:37 ` [Qemu-trivial] " Fam Zheng
2015-03-12 23:37   ` Fam Zheng
2015-03-13  3:45 ` Patchew Tool
2015-03-13  5:17 ` [Qemu-trivial] " Shannon Zhao
2015-03-13  5:17   ` Shannon Zhao
2015-03-13 12:53   ` [Qemu-trivial] " Paolo Bonzini
2015-03-13 12:53     ` Paolo Bonzini
2015-03-19  8:22 ` Michael Tokarev [this message]
2015-03-19  8:22   ` Michael Tokarev
  -- strict thread matches above, loose matches on Subject: below --
2015-03-13 12:55 [Qemu-trivial] " Paolo Bonzini
2015-03-14  1:15 ` Shannon Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550A8755.60308@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.