* [Qemu-trivial] [PATCH] pcspk: Fix I/O port name
@ 2015-03-19 12:08 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2015-03-19 12:08 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
Probably a copy&paste bug. Fixing it helps identifying the device model
behind port 0x61.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/audio/pcspk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
index 1d81bbe..5266fb5 100644
--- a/hw/audio/pcspk.c
+++ b/hw/audio/pcspk.c
@@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
{
PCSpkState *s = PC_SPEAKER(obj);
- memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
+ memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
}
static void pcspk_realizefn(DeviceState *dev, Error **errp)
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] pcspk: Fix I/O port name
@ 2015-03-19 12:08 ` Jan Kiszka
0 siblings, 0 replies; 6+ messages in thread
From: Jan Kiszka @ 2015-03-19 12:08 UTC (permalink / raw)
To: qemu-trivial; +Cc: qemu-devel
Probably a copy&paste bug. Fixing it helps identifying the device model
behind port 0x61.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/audio/pcspk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
index 1d81bbe..5266fb5 100644
--- a/hw/audio/pcspk.c
+++ b/hw/audio/pcspk.c
@@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
{
PCSpkState *s = PC_SPEAKER(obj);
- memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
+ memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
}
static void pcspk_realizefn(DeviceState *dev, Error **errp)
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] pcspk: Fix I/O port name
2015-03-19 12:08 ` [Qemu-devel] " Jan Kiszka
@ 2015-03-20 1:11 ` Gonglei
-1 siblings, 0 replies; 6+ messages in thread
From: Gonglei @ 2015-03-20 1:11 UTC (permalink / raw)
To: Jan Kiszka, qemu-trivial; +Cc: qemu-devel
On 2015/3/19 20:08, Jan Kiszka wrote:
> Probably a copy&paste bug. Fixing it helps identifying the device model
> behind port 0x61.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/audio/pcspk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
> diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
> index 1d81bbe..5266fb5 100644
> --- a/hw/audio/pcspk.c
> +++ b/hw/audio/pcspk.c
> @@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
> {
> PCSpkState *s = PC_SPEAKER(obj);
>
> - memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
> + memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
> }
>
> static void pcspk_realizefn(DeviceState *dev, Error **errp)
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] pcspk: Fix I/O port name
@ 2015-03-20 1:11 ` Gonglei
0 siblings, 0 replies; 6+ messages in thread
From: Gonglei @ 2015-03-20 1:11 UTC (permalink / raw)
To: Jan Kiszka, qemu-trivial; +Cc: qemu-devel
On 2015/3/19 20:08, Jan Kiszka wrote:
> Probably a copy&paste bug. Fixing it helps identifying the device model
> behind port 0x61.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> hw/audio/pcspk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Gonglei <arei.gonglei@huawei.com>
> diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c
> index 1d81bbe..5266fb5 100644
> --- a/hw/audio/pcspk.c
> +++ b/hw/audio/pcspk.c
> @@ -167,7 +167,7 @@ static void pcspk_initfn(Object *obj)
> {
> PCSpkState *s = PC_SPEAKER(obj);
>
> - memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "elcr", 1);
> + memory_region_init_io(&s->ioport, OBJECT(s), &pcspk_io_ops, s, "pcspk", 1);
> }
>
> static void pcspk_realizefn(DeviceState *dev, Error **errp)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] pcspk: Fix I/O port name
2015-03-19 12:08 ` [Qemu-devel] " Jan Kiszka
@ 2015-03-25 15:15 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-03-25 15:15 UTC (permalink / raw)
To: Jan Kiszka, qemu-trivial; +Cc: qemu-devel
19.03.2015 15:08, Jan Kiszka wrote:
> Probably a copy&paste bug. Fixing it helps identifying the device model
> behind port 0x61.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-03-25 15:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-19 12:08 [Qemu-trivial] [PATCH] pcspk: Fix I/O port name Jan Kiszka
2015-03-19 12:08 ` [Qemu-devel] " Jan Kiszka
2015-03-20 1:11 ` [Qemu-trivial] " Gonglei
2015-03-20 1:11 ` Gonglei
2015-03-25 15:15 ` [Qemu-trivial] " Michael Tokarev
2015-03-25 15:15 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.