* [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node
@ 2015-03-20 1:29 Tobias Jakobi
2015-03-20 1:38 ` Chanwoo Choi
0 siblings, 1 reply; 4+ messages in thread
From: Tobias Jakobi @ 2015-03-20 1:29 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: m.reichl, javier.martinez
From: Markus Reichl <m.reichl@fivetechno.de>
The Exynos4412 SoC has a s3c6410 RTC where the source clock
is now a mandatory property.
This patch fixes probe failure of s3c-rtc on Odroid-X2/U2/U3 boards.
Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
Tested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
---
arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
index 1ff4c88..0a8e6aa4 100644
--- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
+++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
@@ -9,6 +9,7 @@
#include <dt-bindings/sound/samsung-i2s.h>
#include <dt-bindings/input/input.h>
+#include <dt-bindings/clock/maxim,max77686.h>
#include "exynos4412.dtsi"
/ {
@@ -143,6 +144,8 @@
rtc@10070000 {
status = "okay";
+ clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
+ clock-names = "rtc", "rtc_src";
};
g2d@10800000 {
--
2.0.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node
2015-03-20 1:29 [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node Tobias Jakobi
@ 2015-03-20 1:38 ` Chanwoo Choi
2015-03-20 8:56 ` Javier Martinez Canillas
0 siblings, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2015-03-20 1:38 UTC (permalink / raw)
To: Tobias Jakobi; +Cc: linux-samsung-soc, m.reichl, javier.martinez
On 03/20/2015 10:29 AM, Tobias Jakobi wrote:
> From: Markus Reichl <m.reichl@fivetechno.de>
>
> The Exynos4412 SoC has a s3c6410 RTC where the source clock
> is now a mandatory property.
>
> This patch fixes probe failure of s3c-rtc on Odroid-X2/U2/U3 boards.
>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> Tested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> index 1ff4c88..0a8e6aa4 100644
> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
> @@ -9,6 +9,7 @@
>
> #include <dt-bindings/sound/samsung-i2s.h>
> #include <dt-bindings/input/input.h>
> +#include <dt-bindings/clock/maxim,max77686.h>
> #include "exynos4412.dtsi"
>
> / {
> @@ -143,6 +144,8 @@
>
> rtc@10070000 {
> status = "okay";
> + clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
> + clock-names = "rtc", "rtc_src";
> };
>
> g2d@10800000 {
>
Exynos's RTC need the XrtcXTI source clock (32.768kHz). Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node
2015-03-20 1:38 ` Chanwoo Choi
@ 2015-03-20 8:56 ` Javier Martinez Canillas
2015-04-03 8:25 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-03-20 8:56 UTC (permalink / raw)
To: Chanwoo Choi, Tobias Jakobi; +Cc: linux-samsung-soc, m.reichl
Hello,
On 03/20/2015 02:38 AM, Chanwoo Choi wrote:
> On 03/20/2015 10:29 AM, Tobias Jakobi wrote:
>> From: Markus Reichl <m.reichl@fivetechno.de>
>>
>> The Exynos4412 SoC has a s3c6410 RTC where the source clock
>> is now a mandatory property.
>>
>> This patch fixes probe failure of s3c-rtc on Odroid-X2/U2/U3 boards.
>>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>> Tested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
>> ---
>> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> index 1ff4c88..0a8e6aa4 100644
>> --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi
>> @@ -9,6 +9,7 @@
>>
>> #include <dt-bindings/sound/samsung-i2s.h>
>> #include <dt-bindings/input/input.h>
>> +#include <dt-bindings/clock/maxim,max77686.h>
>> #include "exynos4412.dtsi"
>>
>> / {
>> @@ -143,6 +144,8 @@
>>
>> rtc@10070000 {
>> status = "okay";
>> + clocks = <&clock CLK_RTC>, <&max77686 MAX77686_CLK_AP>;
>> + clock-names = "rtc", "rtc_src";
>> };
>>
>> g2d@10800000 {
>>
>
> Exynos's RTC need the XrtcXTI source clock (32.768kHz). Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
Yes, I also think this is the correct fix for these boards.
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Thanks,
> Chanwoo Choi
>
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node
2015-03-20 8:56 ` Javier Martinez Canillas
@ 2015-04-03 8:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-04-03 8:25 UTC (permalink / raw)
To: Tobias Jakobi, m.reichl
Cc: Chanwoo Choi, Javier Martinez Canillas, linux-samsung-soc,
Kukjin Kim, linux-kernel
2015-03-20 9:56 GMT+01:00 Javier Martinez Canillas
<javier.martinez@collabora.co.uk>:
>
> Hello,
>
> On 03/20/2015 02:38 AM, Chanwoo Choi wrote:
> > On 03/20/2015 10:29 AM, Tobias Jakobi wrote:
> >> From: Markus Reichl <m.reichl@fivetechno.de>
> >>
> >> The Exynos4412 SoC has a s3c6410 RTC where the source clock
> >> is now a mandatory property.
> >>
> >> This patch fixes probe failure of s3c-rtc on Odroid-X2/U2/U3 boards.
> >>
> >> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> >> Tested-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> >> ---
> >> arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 3 +++
> >> 1 file changed, 3 insertions(+)
Tested on Odroid-U3 board:
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
+CC Kukjin, linux-kernel, devicetree list.
Why this was not sent to Samsung-soc maintainer? Please, use
scripts/get_maintaiiner.pl script for getting the recipients list.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-04-03 8:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-20 1:29 [PATCH] ARM: dts: exynos4412-odroid: add 'rtc_src' clock to rtc node Tobias Jakobi
2015-03-20 1:38 ` Chanwoo Choi
2015-03-20 8:56 ` Javier Martinez Canillas
2015-04-03 8:25 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.