From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Richard Weinberger <richard@nod.at>, linux-kernel@vger.kernel.org
Cc: linux-iio@vger.kernel.org, linux-pm@vger.kernel.org,
dwmw2@infradead.org, dbaryshkov@gmail.com, sre@kernel.org,
jassisinghbrar@gmail.com, pmeerw@pmeerw.net, lars@metafoo.de,
knaack.h@gmx.de, jic23@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH 2/6] clocksource/sh_mtu2.c: Fix !HAS_IOMEM build
Date: Fri, 20 Mar 2015 15:04:52 +0100 [thread overview]
Message-ID: <550C2904.3040702@linaro.org> (raw)
In-Reply-To: <1426541230-928-2-git-send-email-richard@nod.at>
On 03/16/2015 10:27 PM, Richard Weinberger wrote:
> Fixes:
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_map_memory’:
> drivers/clocksource/sh_mtu2.c:391:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
> mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
> ^
> drivers/clocksource/sh_mtu2.c:391:15: warning: assignment makes pointer from integer without a cast [enabled by default]
> mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
> ^
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_setup’:
> drivers/clocksource/sh_mtu2.c:448:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(mtu->mapbase);
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
Thanks applied to my tree for v4.0 fix.
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index c948f4e..c4063a6 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -202,6 +202,7 @@ config SH_TIMER_CMT
> config SH_TIMER_MTU2
> bool "Renesas MTU2 timer driver" if COMPILE_TEST
> depends on GENERIC_CLOCKEVENTS
> + depends on HAS_IOMEM
> default SYS_SUPPORTS_SH_MTU2
> help
> This enables build of a clockevent driver for the Multi-Function
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org,
dbaryshkov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
jassisinghbrar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
knaack.h-Mmb7MZpHnFY@public.gmane.org,
jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org
Subject: Re: [PATCH 2/6] clocksource/sh_mtu2.c: Fix !HAS_IOMEM build
Date: Fri, 20 Mar 2015 15:04:52 +0100 [thread overview]
Message-ID: <550C2904.3040702@linaro.org> (raw)
In-Reply-To: <1426541230-928-2-git-send-email-richard-/L3Ra7n9ekc@public.gmane.org>
On 03/16/2015 10:27 PM, Richard Weinberger wrote:
> Fixes:
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_map_memory’:
> drivers/clocksource/sh_mtu2.c:391:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
> mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
> ^
> drivers/clocksource/sh_mtu2.c:391:15: warning: assignment makes pointer from integer without a cast [enabled by default]
> mtu->mapbase = ioremap_nocache(res->start, resource_size(res));
> ^
> drivers/clocksource/sh_mtu2.c: In function ‘sh_mtu2_setup’:
> drivers/clocksource/sh_mtu2.c:448:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
> iounmap(mtu->mapbase);
>
> Signed-off-by: Richard Weinberger <richard-/L3Ra7n9ekc@public.gmane.org>
> ---
Thanks applied to my tree for v4.0 fix.
> drivers/clocksource/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index c948f4e..c4063a6 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -202,6 +202,7 @@ config SH_TIMER_CMT
> config SH_TIMER_MTU2
> bool "Renesas MTU2 timer driver" if COMPILE_TEST
> depends on GENERIC_CLOCKEVENTS
> + depends on HAS_IOMEM
> default SYS_SUPPORTS_SH_MTU2
> help
> This enables build of a clockevent driver for the Multi-Function
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2015-03-20 14:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-16 21:27 [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build Richard Weinberger
2015-03-16 21:27 ` [PATCH 2/6] clocksource/sh_mtu2.c: " Richard Weinberger
2015-03-17 8:19 ` Geert Uytterhoeven
2015-03-17 8:19 ` Geert Uytterhoeven
2015-03-20 14:04 ` Daniel Lezcano [this message]
2015-03-20 14:04 ` Daniel Lezcano
2015-03-16 21:27 ` [PATCH 3/6] clocksource/sh_tmu.c: " Richard Weinberger
2015-03-17 8:19 ` Geert Uytterhoeven
2015-03-20 14:05 ` Daniel Lezcano
2015-03-16 21:27 ` [PATCH 4/6] power/reset/rmobile-reset.c: " Richard Weinberger
2015-03-17 8:19 ` Geert Uytterhoeven
2015-03-20 12:31 ` Sebastian Reichel
2015-03-16 21:27 ` [PATCH 5/6] mailbox/altera.c: " Richard Weinberger
2015-03-16 21:27 ` [PATCH 6/6] iio/adc/cc10001_adc.c: " Richard Weinberger
2015-03-21 11:35 ` Jonathan Cameron
2015-03-21 11:35 ` Jonathan Cameron
2015-03-30 19:40 ` Jonathan Cameron
2015-03-30 19:40 ` Jonathan Cameron
2015-03-17 8:18 ` [PATCH 1/6] clocksource/sh_cmt.c: " Geert Uytterhoeven
2015-03-17 8:18 ` Geert Uytterhoeven
2015-03-20 14:05 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C2904.3040702@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=jassisinghbrar@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=richard@nod.at \
--cc=sre@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.