From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] mkfs: default to CRC enabled filesystems
Date: Fri, 20 Mar 2015 16:56:53 -0500 [thread overview]
Message-ID: <550C97A5.1040807@sandeen.net> (raw)
In-Reply-To: <20150320214719.GJ28621@dastard>
On 3/20/15 4:47 PM, Dave Chinner wrote:
> On Fri, Mar 20, 2015 at 10:26:49AM -0500, Eric Sandeen wrote:
...
>> I don't see how this requires xfstests rework, though?
>
> About 50 tests fail with:
> +warning: finobt not supported without CRC support, disabled.
> When run with MKFS_OPTIONS="-m crc=0".
Ok, I didn't mean it shouldn't be automatically disabled, I just meant
it should probably reject invalid option combinations on the cmdline.
> i.e. finobt is not specified, but mkfs issues warnings about it.
>
> I've reworked the patch, anyway, so there's no need to continue the
> discussion on this...
Heh, ok. <EOM>
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2015-03-20 21:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 23:22 [PATCH] mkfs: default to CRC enabled filesystems Dave Chinner
2015-03-19 14:55 ` Eric Sandeen
2015-03-19 14:58 ` Eric Sandeen
2015-03-19 23:13 ` Dave Chinner
2015-03-20 15:26 ` Eric Sandeen
2015-03-20 21:47 ` Dave Chinner
2015-03-20 21:56 ` Eric Sandeen [this message]
2015-03-20 2:27 ` Linda Walsh
2015-03-20 2:44 ` Greg Freemyer
2015-03-20 18:38 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C97A5.1040807@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.