From: Paolo Bonzini <pbonzini@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH] translate-all: remove superfluous #ifdef FOO || 1
Date: Sat, 21 Mar 2015 15:28:36 +0100 [thread overview]
Message-ID: <550D8014.2020000@redhat.com> (raw)
In-Reply-To: <1426919112-20726-1-git-send-email-cota@braap.org>
On 21/03/2015 07:25, Emilio G. Cota wrote:
> It always evaluates to true.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> translate-all.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index 9f47ce7..11763c6 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
> invalidate_page_bitmap(p);
>
> -#if defined(TARGET_HAS_SMC) || 1
> -
> #if defined(CONFIG_USER_ONLY)
> if (p->flags & PAGE_WRITE) {
> target_ulong addr;
> @@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> tlb_protect_code(page_addr);
> }
> #endif
> -
> -#endif /* TARGET_HAS_SMC */
> }
>
> /* add a new TB and link it to the physical page tables. phys_page2 is
>
You are removing the last use of TARGET_HAS_SMC, please remove the
definition as well.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Emilio G. Cota" <cota@braap.org>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] translate-all: remove superfluous #ifdef FOO || 1
Date: Sat, 21 Mar 2015 15:28:36 +0100 [thread overview]
Message-ID: <550D8014.2020000@redhat.com> (raw)
In-Reply-To: <1426919112-20726-1-git-send-email-cota@braap.org>
On 21/03/2015 07:25, Emilio G. Cota wrote:
> It always evaluates to true.
>
> Signed-off-by: Emilio G. Cota <cota@braap.org>
> ---
> translate-all.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/translate-all.c b/translate-all.c
> index 9f47ce7..11763c6 100644
> --- a/translate-all.c
> +++ b/translate-all.c
> @@ -1334,8 +1334,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> p->first_tb = (TranslationBlock *)((uintptr_t)tb | n);
> invalidate_page_bitmap(p);
>
> -#if defined(TARGET_HAS_SMC) || 1
> -
> #if defined(CONFIG_USER_ONLY)
> if (p->flags & PAGE_WRITE) {
> target_ulong addr;
> @@ -1371,8 +1369,6 @@ static inline void tb_alloc_page(TranslationBlock *tb,
> tlb_protect_code(page_addr);
> }
> #endif
> -
> -#endif /* TARGET_HAS_SMC */
> }
>
> /* add a new TB and link it to the physical page tables. phys_page2 is
>
You are removing the last use of TARGET_HAS_SMC, please remove the
definition as well.
Paolo
next prev parent reply other threads:[~2015-03-21 14:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 6:25 [Qemu-trivial] [PATCH] translate-all: remove superfluous #ifdef FOO || 1 Emilio G. Cota
2015-03-21 6:25 ` [Qemu-devel] " Emilio G. Cota
2015-03-21 14:28 ` Paolo Bonzini [this message]
2015-03-21 14:28 ` Paolo Bonzini
2015-03-21 17:29 ` [Qemu-trivial] [PATCH] target-i386: remove superfluous TARGET_HAS_SMC macro Emilio G. Cota
2015-03-21 17:29 ` [Qemu-devel] " Emilio G. Cota
2015-03-21 18:45 ` [Qemu-trivial] " Paolo Bonzini
2015-03-21 18:45 ` [Qemu-devel] " Paolo Bonzini
2015-03-25 15:16 ` [Qemu-trivial] " Michael Tokarev
2015-03-25 15:16 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550D8014.2020000@redhat.com \
--to=pbonzini@redhat.com \
--cc=cota@braap.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.