From: Alexei Starovoitov <ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
To: Ingo Molnar <mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Steven Rostedt <rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org>,
Namhyung Kim <namhyung-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Arnaldo Carvalho de Melo
<acme-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>,
Jiri Olsa <jolsa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
Masami Hiramatsu
<masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>,
"David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Daniel Borkmann <daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org>,
Peter Zijlstra
<a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org>,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v9 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()
Date: Sun, 22 Mar 2015 11:05:41 -0700 [thread overview]
Message-ID: <550F0475.7020206@plumgrid.com> (raw)
In-Reply-To: <20150322111040.GA18695-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On 3/22/15 4:10 AM, Ingo Molnar wrote:
>
> * Alexei Starovoitov <ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org> wrote:
>
>> +static const struct bpf_func_proto bpf_trace_printk_proto = {
>> + .func = bpf_trace_printk,
>> + .gpl_only = true,
>> + .ret_type = RET_INTEGER,
>> + .arg1_type = ARG_PTR_TO_STACK,
>> + .arg2_type = ARG_CONST_STACK_SIZE,
>> +};
>
> A nit, please align such initializations vertically, for more
> readability:
>
> static const struct bpf_func_proto bpf_trace_printk_proto = {
> .func = bpf_trace_printk,
> .gpl_only = true,
> .ret_type = RET_INTEGER,
> .arg1_type = ARG_PTR_TO_STACK,
> .arg2_type = ARG_CONST_STACK_SIZE,
> };
sure. will respin.
WARNING: multiple messages have this Message-ID (diff)
From: Alexei Starovoitov <ast@plumgrid.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Jiri Olsa <jolsa@redhat.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"David S. Miller" <davem@davemloft.net>,
Daniel Borkmann <daniel@iogearbox.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
linux-api@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk()
Date: Sun, 22 Mar 2015 11:05:41 -0700 [thread overview]
Message-ID: <550F0475.7020206@plumgrid.com> (raw)
In-Reply-To: <20150322111040.GA18695@gmail.com>
On 3/22/15 4:10 AM, Ingo Molnar wrote:
>
> * Alexei Starovoitov <ast@plumgrid.com> wrote:
>
>> +static const struct bpf_func_proto bpf_trace_printk_proto = {
>> + .func = bpf_trace_printk,
>> + .gpl_only = true,
>> + .ret_type = RET_INTEGER,
>> + .arg1_type = ARG_PTR_TO_STACK,
>> + .arg2_type = ARG_CONST_STACK_SIZE,
>> +};
>
> A nit, please align such initializations vertically, for more
> readability:
>
> static const struct bpf_func_proto bpf_trace_printk_proto = {
> .func = bpf_trace_printk,
> .gpl_only = true,
> .ret_type = RET_INTEGER,
> .arg1_type = ARG_PTR_TO_STACK,
> .arg2_type = ARG_CONST_STACK_SIZE,
> };
sure. will respin.
next prev parent reply other threads:[~2015-03-22 18:05 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 23:30 [PATCH v9 tip 0/9] tracing: attach eBPF programs to kprobes Alexei Starovoitov
2015-03-20 23:30 ` [PATCH v9 tip 1/9] bpf: make internal bpf API independent of CONFIG_BPF_SYSCALL ifdefs Alexei Starovoitov
2015-03-21 12:16 ` Masami Hiramatsu
2015-03-20 23:30 ` [PATCH v9 tip 2/9] tracing: add kprobe flag Alexei Starovoitov
[not found] ` <1426894210-27441-3-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-21 12:16 ` Masami Hiramatsu
2015-03-21 12:16 ` Masami Hiramatsu
2015-03-20 23:30 ` [PATCH v9 tip 3/9] tracing: attach BPF programs to kprobes Alexei Starovoitov
[not found] ` <1426894210-27441-4-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-21 12:14 ` Masami Hiramatsu
2015-03-21 12:14 ` Masami Hiramatsu
2015-03-21 16:02 ` Alexei Starovoitov
[not found] ` <550D962E.7010400-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-22 10:06 ` Masami Hiramatsu
2015-03-22 10:06 ` Masami Hiramatsu
2015-03-22 18:03 ` Alexei Starovoitov
[not found] ` <550F0402.80900-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-23 2:17 ` Masami Hiramatsu
2015-03-23 2:17 ` Masami Hiramatsu
2015-03-23 4:57 ` bpf+tracing next steps. Was: " Alexei Starovoitov
[not found] ` <550F9D20.7070006-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-23 9:27 ` Masami Hiramatsu
2015-03-23 9:27 ` Masami Hiramatsu
2015-03-25 0:40 ` Alexei Starovoitov
[not found] ` <5512040B.3020605-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-25 12:07 ` Masami Hiramatsu
2015-03-25 12:07 ` Masami Hiramatsu
[not found] ` <1426894210-27441-1-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-20 23:30 ` [PATCH v9 tip 4/9] tracing: allow BPF programs to call bpf_ktime_get_ns() Alexei Starovoitov
2015-03-20 23:30 ` Alexei Starovoitov
2015-03-20 23:30 ` [PATCH v9 tip 5/9] tracing: allow BPF programs to call bpf_trace_printk() Alexei Starovoitov
2015-03-20 23:30 ` Alexei Starovoitov
[not found] ` <1426894210-27441-6-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-22 11:10 ` Ingo Molnar
2015-03-22 11:10 ` Ingo Molnar
[not found] ` <20150322111040.GA18695-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-22 18:05 ` Alexei Starovoitov [this message]
2015-03-22 18:05 ` Alexei Starovoitov
2015-03-20 23:30 ` [PATCH v9 tip 9/9] samples: bpf: kmem_alloc/free tracker Alexei Starovoitov
2015-03-20 23:30 ` Alexei Starovoitov
2015-03-20 23:30 ` [PATCH v9 tip 6/9] samples: bpf: simple non-portable kprobe filter example Alexei Starovoitov
[not found] ` <1426894210-27441-7-git-send-email-ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org>
2015-03-23 7:29 ` Ingo Molnar
2015-03-23 7:29 ` Ingo Molnar
[not found] ` <20150323072929.GB25184-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-23 17:23 ` Alexei Starovoitov
2015-03-23 17:23 ` Alexei Starovoitov
2015-03-23 7:35 ` Ingo Molnar
[not found] ` <20150323073506.GC25184-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-03-23 17:32 ` Alexei Starovoitov
2015-03-23 17:32 ` Alexei Starovoitov
2015-03-20 23:30 ` [PATCH v9 tip 7/9] samples: bpf: counting example for kfree_skb and write syscall Alexei Starovoitov
2015-03-20 23:30 ` [PATCH v9 tip 8/9] samples: bpf: IO latency analysis (iosnoop/heatmap) Alexei Starovoitov
2015-03-23 7:40 ` Ingo Molnar
2015-03-23 17:41 ` Alexei Starovoitov
2015-03-21 4:08 ` [PATCH v9 tip 0/9] tracing: attach eBPF programs to kprobes Steven Rostedt
[not found] ` <20150321000812.606ef8cb-2kNGR76GQU9OHLTnHDQRgA@public.gmane.org>
2015-03-23 7:36 ` Ingo Molnar
2015-03-23 7:36 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550F0475.7020206@plumgrid.com \
--to=ast-uqk4ao+rvk5wk0htik3j/w@public.gmane.org \
--cc=a.p.zijlstra-/NLkJaSkS4VmR6Xm/wNWPw@public.gmane.org \
--cc=acme-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=daniel-FeC+5ew28dpmcu3hnIyYJQ@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=jolsa-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=masami.hiramatsu.pt-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=namhyung-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=rostedt-nx8X9YLhiw1AfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.