All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: Jonathan Richardson <jonathar@broadcom.com>,
	Dmitry Torokhov <dtor@google.com>,
	Anatol Pomazau <anatol@google.com>
Cc: Scott Branden <sbranden@broadcom.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	devicetree@vger.kernel.org, Joe Perches <joe@perches.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver
Date: Mon, 23 Mar 2015 18:14:17 +0800	[thread overview]
Message-ID: <550FE779.8010703@atmel.com> (raw)
In-Reply-To: <1426899446-16873-2-git-send-email-jonathar@broadcom.com>

Hi Jonathan Richardson,

On 03/21/2015 08:57 AM, Jonathan Richardson wrote:
> +static struct platform_driver iproc_ts_driver = {
> +	.probe = iproc_ts_probe,

Just a little curious, is the .remove function missing or it doesn't 
need it.

Thanks.

> +	.driver = {
> +		.name	= IPROC_TS_NAME,
> +		.of_match_table = of_match_ptr(iproc_ts_of_match),
> +	},
> +};
> +
> +module_platform_driver(iproc_ts_driver);
> +
> +MODULE_DESCRIPTION("IPROC Touchscreen driver");
> +MODULE_AUTHOR("Broadcom");
> +MODULE_LICENSE("GPL v2");

Best Regards,
Bo Shen

WARNING: multiple messages have this Message-ID (diff)
From: Bo Shen <voice.shen@atmel.com>
To: Jonathan Richardson <jonathar@broadcom.com>,
	Dmitry Torokhov <dtor@google.com>,
	Anatol Pomazau <anatol@google.com>
Cc: Scott Branden <sbranden@broadcom.com>,
	Grant Likely <grant.likely@linaro.org>,
	Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
	<linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	<devicetree@vger.kernel.org>, "Joe Perches" <joe@perches.com>,
	Pawel Moll <pawel.moll@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Ian Campbell <ijc+devicetree@hellion.org.uk>,
	"Kumar Gala" <galak@codeaurora.org>
Subject: Re: [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver
Date: Mon, 23 Mar 2015 18:14:17 +0800	[thread overview]
Message-ID: <550FE779.8010703@atmel.com> (raw)
In-Reply-To: <1426899446-16873-2-git-send-email-jonathar@broadcom.com>

Hi Jonathan Richardson,

On 03/21/2015 08:57 AM, Jonathan Richardson wrote:
> +static struct platform_driver iproc_ts_driver = {
> +	.probe = iproc_ts_probe,

Just a little curious, is the .remove function missing or it doesn't 
need it.

Thanks.

> +	.driver = {
> +		.name	= IPROC_TS_NAME,
> +		.of_match_table = of_match_ptr(iproc_ts_of_match),
> +	},
> +};
> +
> +module_platform_driver(iproc_ts_driver);
> +
> +MODULE_DESCRIPTION("IPROC Touchscreen driver");
> +MODULE_AUTHOR("Broadcom");
> +MODULE_LICENSE("GPL v2");

Best Regards,
Bo Shen

  parent reply	other threads:[~2015-03-23 10:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-21  0:57 [PATCH v5 0/2] Add support for Broadcom iProc touchscreen Jonathan Richardson
2015-03-21  0:57 ` Jonathan Richardson
2015-03-21  0:57 ` [PATCH v5 1/2] Input: touchscreen-iproc: Add Broadcom iProc touchscreen driver Jonathan Richardson
2015-03-21  0:57   ` Jonathan Richardson
     [not found]   ` <1426899446-16873-2-git-send-email-jonathar-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-22  4:24     ` Dmitry Torokhov
2015-03-22  4:24       ` Dmitry Torokhov
2015-03-23 17:57       ` Jonathan Richardson
2015-03-23 17:57         ` Jonathan Richardson
     [not found]         ` <551053F1.7070308-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2015-03-23 18:05           ` Dmitry Torokhov
2015-03-23 18:05             ` Dmitry Torokhov
2015-03-23 10:14   ` Bo Shen [this message]
2015-03-23 10:14     ` Bo Shen
2015-03-23 16:01     ` Dmitry Torokhov
2015-03-21  0:57 ` [PATCH v5 2/2] Input: touchscreen-iproc: add device tree bindings Jonathan Richardson
2015-03-21  0:57   ` Jonathan Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=550FE779.8010703@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=anatol@google.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dtor@google.com \
    --cc=galak@codeaurora.org \
    --cc=grant.likely@linaro.org \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=joe@perches.com \
    --cc=jonathar@broadcom.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=rjui@broadcom.com \
    --cc=robh+dt@kernel.org \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.