From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Greg Bellows" <greg.bellows@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] RFC: memory API changes
Date: Mon, 23 Mar 2015 16:47:43 +0100 [thread overview]
Message-ID: <5510359F.8080400@redhat.com> (raw)
In-Reply-To: <CAFEAcA9cOcEBUuEvThGbdX-Vda-hAJHgorAEdECy72qTiuahrA@mail.gmail.com>
On 23/03/2015 16:39, Peter Maydell wrote:
> > Not necessarily, for example PCI devices can certainly
> > use the short name.
>
> PCI devices should all be using ld*_pci_dma and st*_pci_dma
> so they go through the correct address space for the PCIDevice.
> Any PCI device making direct calls to ld*_phys/st*_phys
> is broken...
Ok, so most ld*_phys users are already using cs->as. The remaining ones
are:
hw/alpha/typhoon.c
hw/display/sm501_template.h
hw/dma/pl080.c
hw/dma/sun4m_iommu.c
hw/net/vmware_utils.h
hw/pci-host/apb.c
hw/s390x/css.c
hw/s390x/s390-pci-bus.c
hw/s390x/s390-virtio-bus.c
hw/s390x/virtio-ccw.c
hw/scsi/megasas.c
hw/scsi/vmw_pvscsi.c
So let's keep ld*_phys in cpu-common.h, fix the uses above, and then
move it to cpu-all.h (cpu-common.h probably should die).
Paolo
next prev parent reply other threads:[~2015-03-23 15:47 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 12:24 [Qemu-devel] RFC: memory API changes Peter Maydell
2015-03-23 12:30 ` Andreas Färber
2015-03-23 12:33 ` Peter Maydell
2015-03-23 14:39 ` Paolo Bonzini
2015-03-23 15:11 ` Peter Maydell
2015-03-23 15:18 ` Paolo Bonzini
2015-03-23 15:26 ` Peter Maydell
2015-03-23 15:27 ` Paolo Bonzini
2015-03-23 15:39 ` Peter Maydell
2015-03-23 15:47 ` Paolo Bonzini [this message]
2015-03-23 16:00 ` Peter Maydell
2015-03-23 16:30 ` Paolo Bonzini
2015-03-23 16:43 ` Peter Maydell
2015-03-23 16:32 ` Andreas Färber
2015-03-25 10:56 ` Igor Mammedov
2015-03-23 17:51 ` Andreas Färber
2015-03-23 17:59 ` Peter Maydell
2015-03-24 13:47 ` Peter Maydell
2015-03-24 14:45 ` Paolo Bonzini
2015-03-24 14:53 ` Peter Maydell
2015-03-24 15:08 ` Paolo Bonzini
2015-03-24 15:12 ` Peter Maydell
2015-03-24 16:23 ` Paolo Bonzini
2015-03-24 16:35 ` Peter Maydell
2015-03-24 17:51 ` Paolo Bonzini
2015-03-24 18:06 ` Peter Maydell
2015-03-24 20:00 ` Paolo Bonzini
2015-03-24 23:41 ` Peter Maydell
2015-03-25 11:34 ` Paolo Bonzini
2015-03-25 11:43 ` Peter Maydell
2015-03-25 11:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5510359F.8080400@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=greg.bellows@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.