From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Greg Bellows" <greg.bellows@linaro.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Andreas Färber" <afaerber@suse.de>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] RFC: memory API changes
Date: Mon, 23 Mar 2015 17:30:31 +0100 [thread overview]
Message-ID: <55103FA7.10402@redhat.com> (raw)
In-Reply-To: <CAFEAcA_r3_b3z34nMQ9GCTXYDhd8qLASpQHMFDVJ-4nN4R+_QQ@mail.gmail.com>
On 23/03/2015 17:00, Peter Maydell wrote:
> On 23 March 2015 at 15:47, Paolo Bonzini <pbonzini@redhat.com> wrote:
>> Ok, so most ld*_phys users are already using cs->as.
>
> But this is only because when the AddressSpace* argument
> to ld*_phys was introduced we made it be cs->as for
> existing callers, to retain the existing behaviour.
> That doesn't mean that callers using cs->as are doing
> the right thing. In general I would expect that any
> caller that's not part of the CPU itself should not be
> rummaging around inside the CPU struct to find an
> AddressSpace to use...
None of them does, uses of ld*_phys(cs->as, ...) are almost all in
target-* already.
There's just hw/ppc/spapr_hcall.c and hw/ppc/spapr_iommu.c that are
using cs->as in hw/, but they are correct because these are hypercalls.
The others use &address_space_memory. I sent a patch to fix megasas and
vmware.
Paolo
next prev parent reply other threads:[~2015-03-23 16:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 12:24 [Qemu-devel] RFC: memory API changes Peter Maydell
2015-03-23 12:30 ` Andreas Färber
2015-03-23 12:33 ` Peter Maydell
2015-03-23 14:39 ` Paolo Bonzini
2015-03-23 15:11 ` Peter Maydell
2015-03-23 15:18 ` Paolo Bonzini
2015-03-23 15:26 ` Peter Maydell
2015-03-23 15:27 ` Paolo Bonzini
2015-03-23 15:39 ` Peter Maydell
2015-03-23 15:47 ` Paolo Bonzini
2015-03-23 16:00 ` Peter Maydell
2015-03-23 16:30 ` Paolo Bonzini [this message]
2015-03-23 16:43 ` Peter Maydell
2015-03-23 16:32 ` Andreas Färber
2015-03-25 10:56 ` Igor Mammedov
2015-03-23 17:51 ` Andreas Färber
2015-03-23 17:59 ` Peter Maydell
2015-03-24 13:47 ` Peter Maydell
2015-03-24 14:45 ` Paolo Bonzini
2015-03-24 14:53 ` Peter Maydell
2015-03-24 15:08 ` Paolo Bonzini
2015-03-24 15:12 ` Peter Maydell
2015-03-24 16:23 ` Paolo Bonzini
2015-03-24 16:35 ` Peter Maydell
2015-03-24 17:51 ` Paolo Bonzini
2015-03-24 18:06 ` Peter Maydell
2015-03-24 20:00 ` Paolo Bonzini
2015-03-24 23:41 ` Peter Maydell
2015-03-25 11:34 ` Paolo Bonzini
2015-03-25 11:43 ` Peter Maydell
2015-03-25 11:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55103FA7.10402@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=edgar.iglesias@gmail.com \
--cc=greg.bellows@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.