From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: gaohaifeng
<gaohaifeng.gao-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>,
jerry.lilijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org,
dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] eal_common_options.c: set create_uio_dev option to no argument
Date: Mon, 23 Mar 2015 17:13:56 +0100 [thread overview]
Message-ID: <55103BC4.5030600@6wind.com> (raw)
In-Reply-To: <1427098299-20876-1-git-send-email-gaohaifeng.gao-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Hi,
On 03/23/2015 09:11 AM, gaohaifeng wrote:
> From: Haifeng Gao <gaohaifeng.gao-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
>
> eal options OPT_CREATE_UIO_DEV does not need argument so set it to zero.
> It needs to reset create_uio_dev explicitly.
>
> Signed-off-by: Haifeng Gao <gaohaifeng.gao-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Acked-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Thank you for fixing this.
Note for Thomas: the bug is there since my initial commit adding
the feature, you may want to add this to the commit log:
Fixes: f7f97c16048e (" pci: add option --create-uio-dev to run without
hotplug")
Regards,
Olivier
next prev parent reply other threads:[~2015-03-23 16:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-23 8:11 [PATCH] eal_common_options.c: set create_uio_dev option to no argument gaohaifeng
[not found] ` <1427098299-20876-1-git-send-email-gaohaifeng.gao-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2015-03-23 16:13 ` Olivier MATZ [this message]
[not found] ` <55103BC4.5030600-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2015-03-23 16:37 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55103BC4.5030600@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=gaohaifeng.gao-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=jerry.lilijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.