From: Gioh Kim <gioh.kim@lge.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, vbabka@suse.cz,
iamjoonsoo.kim@lge.com, mgorman@suse.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, gunho.lee@lge.com,
Gioh Kim <gioh.kim@lge.c>
Subject: Re: [PATCH] mm/compaction: reset compaction scanner positions
Date: Tue, 24 Mar 2015 10:23:56 +0900 [thread overview]
Message-ID: <5510BCAC.5010101@lge.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1503231613320.24576@chino.kir.corp.google.com>
2015-03-24 i??i ? 8:16i?? David Rientjes i?'(e??) i?' e,?:
> On Sat, 21 Mar 2015, Gioh Kim wrote:
>
>> When the compaction is activated via /proc/sys/vm/compact_memory
>> it would better scan the whole zone.
>> And some platform, for instance ARM, has the start_pfn of a zone is zero.
>> Therefore the first try to compaction via /proc doesn't work.
>> It needs to force to reset compaction scanner position at first.
>>
>> Signed-off-by: Gioh Kim <gioh.kim@lge.c>
>
> That shouldn't be a valid email address.
It's my fault. I'm going to send patch again.
>
>> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> I was thinking that maybe this would be better handled as part of the
> comapct_zone() logic, i.e. set cc->free_pfn and cc->migrate_pfn based on a
> helper function that understands cc->order == -1 should compact the entire
> zone. However, after scanning the entire zone as a result of this write,
> the existing cached pfns probably don't matter anymore. So this seems
> fine.
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Gioh Kim <gioh.kim@lge.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, vbabka@suse.cz,
iamjoonsoo.kim@lge.com, mgorman@suse.de, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, gunho.lee@lge.com,
Gioh Kim <gioh.kim@lge.c>
Subject: Re: [PATCH] mm/compaction: reset compaction scanner positions
Date: Tue, 24 Mar 2015 10:23:56 +0900 [thread overview]
Message-ID: <5510BCAC.5010101@lge.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1503231613320.24576@chino.kir.corp.google.com>
2015-03-24 오전 8:16에 David Rientjes 이(가) 쓴 글:
> On Sat, 21 Mar 2015, Gioh Kim wrote:
>
>> When the compaction is activated via /proc/sys/vm/compact_memory
>> it would better scan the whole zone.
>> And some platform, for instance ARM, has the start_pfn of a zone is zero.
>> Therefore the first try to compaction via /proc doesn't work.
>> It needs to force to reset compaction scanner position at first.
>>
>> Signed-off-by: Gioh Kim <gioh.kim@lge.c>
>
> That shouldn't be a valid email address.
It's my fault. I'm going to send patch again.
>
>> Acked-by: Vlastimil Babka <vbabka@suse.cz>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> I was thinking that maybe this would be better handled as part of the
> comapct_zone() logic, i.e. set cc->free_pfn and cc->migrate_pfn based on a
> helper function that understands cc->order == -1 should compact the entire
> zone. However, after scanning the entire zone as a result of this write,
> the existing cached pfns probably don't matter anymore. So this seems
> fine.
>
next prev parent reply other threads:[~2015-03-24 1:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-21 11:58 [PATCH] mm/compaction: reset compaction scanner positions Gioh Kim
2015-03-21 11:58 ` Gioh Kim
2015-03-23 23:16 ` David Rientjes
2015-03-23 23:16 ` David Rientjes
2015-03-24 1:23 ` Gioh Kim [this message]
2015-03-24 1:23 ` Gioh Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5510BCAC.5010101@lge.com \
--to=gioh.kim@lge.com \
--cc=akpm@linux-foundation.org \
--cc=gioh.kim@lge.c \
--cc=gunho.lee@lge.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.