All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tero Kristo <t-kristo@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>,
	mturquette@linaro.org, sboyd@codeaurora.org
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes
Date: Tue, 24 Mar 2015 20:50:20 +0200	[thread overview]
Message-ID: <5511B1EC.7080406@ti.com> (raw)
In-Reply-To: <1426502458-6124-1-git-send-email-peter.ujfalusi@ti.com>

On 03/16/2015 12:40 PM, Peter Ujfalusi wrote:
> Hi,
>
> This series will fix the following error during boot (both DT and legacy boot):
> [    0.307739] omap_hwmod: mcbsp2: _wait_target_ready failed: -16
> [    0.307769] omap_hwmod: mcbsp2: cannot be enabled for reset (3)
>
> The clock definitions/aliases for McBSP ports were not correct.
>
> In case of DT boot we still have the following warning printed from hwmod:
> [    0.222900] omap_hwmod: mcbsp2_sidetone using broken dt data from mcbsp
> [    0.225311] omap_hwmod: mcbsp3_sidetone using broken dt data from mcbsp
>
> These are there because mcbsp is using two hwmods in the DT and hwmod prints
> out a warning for these. In legacy mode we also have 2 hwmods for McBSP2/3.
> One for the McBSP itself and the other for the sidetone block attached to them.
> I'll try to look into this one next.
>
> Since this series fixes the _wait_target_ready issue, can this be sent for 4.0?

I don't think this is a critical fix, the wait_target_ready issue has 
been around for ages. Queued for 4.1 though, thanks.

-Tero

>
> Regards,
> Peter
> ---
> Peter Ujfalusi (2):
>    clk: ti: clk-3xxx: Correct McBSP related DT clock definitions
>    clk: ti: clk-3xxx-legacy: Correct McBSP related clock aliases
>
>   drivers/clk/ti/clk-3xxx-legacy.c | 16 +++++++++-------
>   drivers/clk/ti/clk-3xxx.c        | 19 +++++++------------
>   2 files changed, 16 insertions(+), 19 deletions(-)
>

WARNING: multiple messages have this Message-ID (diff)
From: Tero Kristo <t-kristo@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>, <mturquette@linaro.org>,
	<sboyd@codeaurora.org>
Cc: <tony@atomide.com>, <linux-omap@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes
Date: Tue, 24 Mar 2015 20:50:20 +0200	[thread overview]
Message-ID: <5511B1EC.7080406@ti.com> (raw)
In-Reply-To: <1426502458-6124-1-git-send-email-peter.ujfalusi@ti.com>

On 03/16/2015 12:40 PM, Peter Ujfalusi wrote:
> Hi,
>
> This series will fix the following error during boot (both DT and legacy boot):
> [    0.307739] omap_hwmod: mcbsp2: _wait_target_ready failed: -16
> [    0.307769] omap_hwmod: mcbsp2: cannot be enabled for reset (3)
>
> The clock definitions/aliases for McBSP ports were not correct.
>
> In case of DT boot we still have the following warning printed from hwmod:
> [    0.222900] omap_hwmod: mcbsp2_sidetone using broken dt data from mcbsp
> [    0.225311] omap_hwmod: mcbsp3_sidetone using broken dt data from mcbsp
>
> These are there because mcbsp is using two hwmods in the DT and hwmod prints
> out a warning for these. In legacy mode we also have 2 hwmods for McBSP2/3.
> One for the McBSP itself and the other for the sidetone block attached to them.
> I'll try to look into this one next.
>
> Since this series fixes the _wait_target_ready issue, can this be sent for 4.0?

I don't think this is a critical fix, the wait_target_ready issue has 
been around for ages. Queued for 4.1 though, thanks.

-Tero

>
> Regards,
> Peter
> ---
> Peter Ujfalusi (2):
>    clk: ti: clk-3xxx: Correct McBSP related DT clock definitions
>    clk: ti: clk-3xxx-legacy: Correct McBSP related clock aliases
>
>   drivers/clk/ti/clk-3xxx-legacy.c | 16 +++++++++-------
>   drivers/clk/ti/clk-3xxx.c        | 19 +++++++------------
>   2 files changed, 16 insertions(+), 19 deletions(-)
>


  parent reply	other threads:[~2015-03-24 18:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-16 10:40 [PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes Peter Ujfalusi
2015-03-16 10:40 ` Peter Ujfalusi
2015-03-16 10:40 ` [PATCH 1/2] clk: ti: clk-3xxx: Correct McBSP related DT clock definitions Peter Ujfalusi
2015-03-16 10:40   ` Peter Ujfalusi
2015-03-16 10:40 ` [PATCH 2/2] clk: ti: clk-3xxx-legacy: Correct McBSP related clock aliases Peter Ujfalusi
2015-03-16 10:40   ` Peter Ujfalusi
2015-03-24 18:50 ` Tero Kristo [this message]
2015-03-24 18:50   ` [PATCH 0/2] clk: ti: OMAP3: McBSP clock fixes Tero Kristo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5511B1EC.7080406@ti.com \
    --to=t-kristo@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mturquette@linaro.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=sboyd@codeaurora.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.