From: Jens Axboe <axboe@kernel.dk>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>,
linux-kernel@vger.kernel.org, drbd-user@lists.linbit.com,
Lars Ellenberg <drbd-dev@lists.linbit.com>
Subject: Re: [Drbd-dev] [patch resend 2/3] block, drbd: fix drbd_req_new() initialization
Date: Tue, 24 Mar 2015 20:01:47 -0600 [thread overview]
Message-ID: <5512170B.1090003@kernel.dk> (raw)
In-Reply-To: <alpine.DEB.2.10.1503241622090.21805@chino.kir.corp.google.com>
On 03/24/2015 05:22 PM, David Rientjes wrote:
> mempool_alloc() does not support __GFP_ZERO since elements may come from
> memory that has already been released by mempool_free().
>
> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly
> initialize it to 0.
This (and the other drbd patch) queued up in for-4.1/drivers, thanks.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: David Rientjes <rientjes@google.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Tejun Heo <tj@kernel.org>,
Lars Ellenberg <drbd-dev@lists.linbit.com>,
drbd-user@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [patch resend 2/3] block, drbd: fix drbd_req_new() initialization
Date: Tue, 24 Mar 2015 20:01:47 -0600 [thread overview]
Message-ID: <5512170B.1090003@kernel.dk> (raw)
In-Reply-To: <alpine.DEB.2.10.1503241622090.21805@chino.kir.corp.google.com>
On 03/24/2015 05:22 PM, David Rientjes wrote:
> mempool_alloc() does not support __GFP_ZERO since elements may come from
> memory that has already been released by mempool_free().
>
> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly
> initialize it to 0.
This (and the other drbd patch) queued up in for-4.1/drivers, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2015-03-25 2:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-24 23:21 [Drbd-dev] [patch resend 1/3] block: allocate request memory local to request queue David Rientjes
2015-03-24 23:21 ` David Rientjes
2015-03-24 23:22 ` [Drbd-dev] [patch resend 2/3] block, drbd: fix drbd_req_new() initialization David Rientjes
2015-03-24 23:22 ` David Rientjes
2015-03-25 2:01 ` Jens Axboe [this message]
2015-03-25 2:01 ` Jens Axboe
2015-03-24 23:22 ` [Drbd-dev] [patch resend 3/3] block, drbd: use mempool_create_slab_pool() David Rientjes
2015-03-24 23:22 ` David Rientjes
2015-03-25 2:01 ` [Drbd-dev] [patch resend 1/3] block: allocate request memory local to request queue Jens Axboe
2015-03-25 2:01 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5512170B.1090003@kernel.dk \
--to=axboe@kernel.dk \
--cc=akpm@linux-foundation.org \
--cc=drbd-dev@lists.linbit.com \
--cc=drbd-user@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.