Re: [PATCH 06/13] wlcore: enable sleep during AP mode operation

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 2562 bytes --]

On 12/29/2014 07:24 AM, Eliad Peller wrote:
> From: Kobi L <kobi.lev100@gmail.com>
> 
> Enable ELP authorization in AP mode and enable the use
> of the wakeup bit in the ELP register.
> 
> Introduce AP role sleep configuration which is disabled
> by default. When configured, it allows the AP to sleep
> when ELP is authorized for it.
> 
> Signed-off-by: Kobi Leibovitch <kobi.lev100@gmail.com>
> Signed-off-by: Arik Nemtsov <arik@wizery.com>
> Signed-off-by: Eliad Peller <eliad@wizery.com>

[...]

> diff --git a/drivers/net/wireless/ti/wl18xx/conf.h b/drivers/net/wireless/ti/wl18xx/conf.h
> index e34302e..71f1ec4 100644
> --- a/drivers/net/wireless/ti/wl18xx/conf.h
> +++ b/drivers/net/wireless/ti/wl18xx/conf.h
> @@ -23,7 +23,7 @@
>  #define __WL18XX_CONF_H__
>  
>  #define WL18XX_CONF_MAGIC	0x10e100ca
> -#define WL18XX_CONF_VERSION	(WLCORE_CONF_VERSION | 0x0006)
> +#define WL18XX_CONF_VERSION	(WLCORE_CONF_VERSION | 0x0007)
>  #define WL18XX_CONF_MASK	0x0000ffff
>  #define WL18XX_CONF_SIZE	(WLCORE_CONF_SIZE + \
>  				 sizeof(struct wl18xx_priv_conf))
> @@ -110,12 +110,33 @@ struct wl18xx_ht_settings {
>  	u8 mode;
>  } __packed;
>  
> +struct conf_ap_sleep_settings {
> +	/* Duty Cycle (20-80% of staying Awake) for IDLE AP
> +	 * (0: disable)
> +	 */
> +	u8 idle_duty_cycle;
> +	/* Duty Cycle (20-80% of staying Awake) for Connected AP
> +	 * (0: disable)
> +	 */
> +	u8 connected_duty_cycle;
> +	/* Maximum stations that are allowed to be connected to AP
> +	 *  (255: no limit)
> +	 */
> +	u8 max_stations_thresh;
> +	/* Timeout till enabling the Sleep Mechanism after data stops
> +	 * [unit: 100 msec]
> +	 */
> +	u8 idle_conn_thresh;
> +} __packed;
> +
>  struct wl18xx_priv_conf {
>  	/* Module params structures */
>  	struct wl18xx_ht_settings ht;
>  
>  	/* this structure is copied wholesale to FW */
>  	struct wl18xx_mac_and_phy_params phy;
> +
> +	struct conf_ap_sleep_settings ap_sleep;
>  } __packed;

This patch requires a new firmware, loading of "wl18xx-conf.bin" from
[1] fails with:

> wlcore: ERROR configuration binary file size is wrong, expected 1226 got 1221

regards,
Marc

[1]
http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.git/tree/ti-connectivity

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]