From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Eliad Peller <eliad@wizery.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Kobi Leibovitch <kobi.lev100@gmail.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH 06/13] wlcore: enable sleep during AP mode operation
Date: Wed, 25 Mar 2015 14:24:02 +0100 [thread overview]
Message-ID: <5512B6F2.8090407@pengutronix.de> (raw)
In-Reply-To: <CAB3XZEfw5EurqA2jZypAj4LkQwwAiVeKd5wKKsxpOAh-RrCq0w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1992 bytes --]
On 03/25/2015 01:58 PM, Eliad Peller wrote:
> hi Marc,
>
> On Wed, Mar 25, 2015 at 2:27 PM, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>> On 12/29/2014 07:24 AM, Eliad Peller wrote:
>>> From: Kobi L <kobi.lev100@gmail.com>
>>>
>>> Enable ELP authorization in AP mode and enable the use
>>> of the wakeup bit in the ELP register.
>>>
>>> Introduce AP role sleep configuration which is disabled
>>> by default. When configured, it allows the AP to sleep
>>> when ELP is authorized for it.
>>>
>>> Signed-off-by: Kobi Leibovitch <kobi.lev100@gmail.com>
>>> Signed-off-by: Arik Nemtsov <arik@wizery.com>
>>> Signed-off-by: Eliad Peller <eliad@wizery.com>
>>
>> [...]
>>
>>
>> This patch requires a new firmware, loading of "wl18xx-conf.bin" from
>> [1] fails with:
>>
>>> wlcore: ERROR configuration binary file size is wrong, expected 1226 got 1221
>>
> thanks. seems you're right.
>
> anyway, note that this file is not actual fw, but only the default
> configuration params.
> you can just delete it, and the driver will load just fine.
> you can then recreate it with something like:
> cat /sys/kernel/debug/ieee80211/phy0/wlcore/wl18xx/conf >
> /lib/firmware/ti-connectivity/wl18xx-conf.bin
>
> actually, i don't think it makes much sense to have this file in the
> linux-firmware git at all.
> i'll try handling it.
Thanks, there are more file with size of ~1k, are they optional, too?
What's the "error" message if these optional files are not present?
From working with $CUSTOMERS I gained the impression, messages like
"error failed to load...." for optional file don't shine the best light
on Linux, a neutral "using default values" is far better.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-25 13:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-29 6:24 [PATCH 01/13] wlcore: fix WLCORE_VENDOR_ATTR_GROUP_KEY policy Eliad Peller
2014-12-29 6:24 ` [PATCH 02/13] wlcore: fix sparse warning Eliad Peller
2014-12-29 6:24 ` [PATCH 03/13] wlcore/wl18xx: handle rc updates in a separate work Eliad Peller
2014-12-29 6:24 ` [PATCH 04/13] wlcore: add ability to reduce FW interrupts during suspend Eliad Peller
2014-12-29 6:24 ` [PATCH 05/13] wlcore: enable AP wowlan Eliad Peller
2014-12-29 6:24 ` [PATCH 06/13] wlcore: enable sleep during AP mode operation Eliad Peller
2015-03-25 12:27 ` Marc Kleine-Budde
2015-03-25 12:58 ` Eliad Peller
2015-03-25 13:24 ` Marc Kleine-Budde [this message]
2015-03-25 13:45 ` Eliad Peller
2015-05-04 9:16 ` Yegor Yefremov
2015-05-06 8:32 ` Eliad Peller
2015-05-06 9:03 ` Yegor Yefremov
2014-12-29 6:24 ` [PATCH 07/13] wl18xx: add radar detection implementation Eliad Peller
2014-12-29 6:24 ` [PATCH 08/13] wl18xx: add debugfs file to emulate radar event Eliad Peller
2014-12-29 6:24 ` [PATCH 09/13] wlcore: add support for ap csa Eliad Peller
2014-12-29 6:24 ` [PATCH 10/13] wlcore: add dfs master restart calls Eliad Peller
2014-12-29 6:24 ` [PATCH 11/13] wlcore: allow using dfs channels Eliad Peller
2014-12-29 6:24 ` [PATCH 12/13] wlcore: add dfs region to reg domain update cmd Eliad Peller
2014-12-29 6:24 ` [PATCH 13/13] wl18xx: declare radar_detect_widths support for ap interfaces Eliad Peller
2015-01-07 17:55 ` [PATCH 01/13] wlcore: fix WLCORE_VENDOR_ATTR_GROUP_KEY policy Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5512B6F2.8090407@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=eliad@wizery.com \
--cc=kernel@pengutronix.de \
--cc=kobi.lev100@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.