From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: tony@atomide.com, linux@arm.linux.org.uk,
grant.likely@linaro.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
robh+dt@kernel.org, nm@ti.com
Subject: Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count
Date: Thu, 26 Mar 2015 14:32:58 +0200 [thread overview]
Message-ID: <5513FC7A.7090708@ti.com> (raw)
In-Reply-To: <20150326105712.GL32683@intel.com>
On 03/26/2015 12:57 PM, Vinod Koul wrote:
> On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote:
>> Instead of magic numbers in the code, use define for number of logical DMA
>> channels and DMA requests.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> drivers/dma/omap-dma.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
>> index 7dd6dd121681..56c33e93dd24 100644
>> --- a/drivers/dma/omap-dma.c
>> +++ b/drivers/dma/omap-dma.c
>> @@ -22,6 +22,9 @@
>>
>> #include "virt-dma.h"
>>
>> +#define OMAP_SDMA_REQUESTS 127
>> +#define OMAP_SDMA_CHANNELS 32
> Again why dont we put these things in DT ?
They are in DT, the next patch will take the needed information from there and
uses these values as fallback values in case they are missing for some reason.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count
Date: Thu, 26 Mar 2015 14:32:58 +0200 [thread overview]
Message-ID: <5513FC7A.7090708@ti.com> (raw)
In-Reply-To: <20150326105712.GL32683@intel.com>
On 03/26/2015 12:57 PM, Vinod Koul wrote:
> On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote:
>> Instead of magic numbers in the code, use define for number of logical DMA
>> channels and DMA requests.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> drivers/dma/omap-dma.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
>> index 7dd6dd121681..56c33e93dd24 100644
>> --- a/drivers/dma/omap-dma.c
>> +++ b/drivers/dma/omap-dma.c
>> @@ -22,6 +22,9 @@
>>
>> #include "virt-dma.h"
>>
>> +#define OMAP_SDMA_REQUESTS 127
>> +#define OMAP_SDMA_CHANNELS 32
> Again why dont we put these things in DT ?
They are in DT, the next patch will take the needed information from there and
uses these values as fallback values in case they are missing for some reason.
--
P?ter
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod Koul <vinod.koul@intel.com>
Cc: <tony@atomide.com>, <linux@arm.linux.org.uk>,
<grant.likely@linaro.org>, <dmaengine@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <robh+dt@kernel.org>,
<nm@ti.com>
Subject: Re: [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count
Date: Thu, 26 Mar 2015 14:32:58 +0200 [thread overview]
Message-ID: <5513FC7A.7090708@ti.com> (raw)
In-Reply-To: <20150326105712.GL32683@intel.com>
On 03/26/2015 12:57 PM, Vinod Koul wrote:
> On Wed, Mar 11, 2015 at 03:23:27PM +0200, Peter Ujfalusi wrote:
>> Instead of magic numbers in the code, use define for number of logical DMA
>> channels and DMA requests.
>>
>> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>> ---
>> drivers/dma/omap-dma.c | 7 +++++--
>> 1 file changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
>> index 7dd6dd121681..56c33e93dd24 100644
>> --- a/drivers/dma/omap-dma.c
>> +++ b/drivers/dma/omap-dma.c
>> @@ -22,6 +22,9 @@
>>
>> #include "virt-dma.h"
>>
>> +#define OMAP_SDMA_REQUESTS 127
>> +#define OMAP_SDMA_CHANNELS 32
> Again why dont we put these things in DT ?
They are in DT, the next patch will take the needed information from there and
uses these values as fallback values in case they are missing for some reason.
--
Péter
next prev parent reply other threads:[~2015-03-26 12:33 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 13:23 [PATCH v2 0/7] dmaengine/dra7x: DMA router (crossbar support) Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` [PATCH v2 1/7] dmaengine: of_dma: Support for DMA routers Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
[not found] ` <1426080210-841-2-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-03-26 10:50 ` Vinod Koul
2015-03-26 10:50 ` Vinod Koul
2015-03-26 10:50 ` Vinod Koul
2015-03-26 12:11 ` Peter Ujfalusi
2015-03-26 12:11 ` Peter Ujfalusi
2015-03-26 12:11 ` Peter Ujfalusi
2015-03-26 15:32 ` Vinod Koul
2015-03-26 15:32 ` Vinod Koul
2015-03-27 12:25 ` Peter Ujfalusi
2015-03-27 12:25 ` Peter Ujfalusi
2015-03-27 12:25 ` Peter Ujfalusi
[not found] ` <55154C39.3030602-l0cyMroinI0@public.gmane.org>
2015-03-30 17:20 ` Vinod Koul
2015-03-30 17:20 ` Vinod Koul
2015-03-30 17:20 ` Vinod Koul
2015-03-11 13:23 ` [PATCH v2 2/7] Documentation: devicetree: dma: Binding documentation for TI DMA crossbar Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` [PATCH v2 3/7] dmaengine: Add driver for TI DMA crossbar on DRA7x Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
[not found] ` <1426080210-841-4-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-03-26 10:56 ` Vinod Koul
2015-03-26 10:56 ` Vinod Koul
2015-03-26 10:56 ` Vinod Koul
2015-03-26 12:31 ` Peter Ujfalusi
2015-03-26 12:31 ` Peter Ujfalusi
2015-03-26 12:31 ` Peter Ujfalusi
[not found] ` <5513FC22.2030304-l0cyMroinI0@public.gmane.org>
2015-03-26 15:22 ` Tony Lindgren
2015-03-26 15:22 ` Tony Lindgren
2015-03-26 15:22 ` Tony Lindgren
2015-03-26 15:37 ` Vinod Koul
2015-03-26 15:37 ` Vinod Koul
2015-03-11 13:23 ` [PATCH v2 4/7] dmaengine: omap-dma: Use defines for dma channels and request count Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-26 10:57 ` Vinod Koul
2015-03-26 10:57 ` Vinod Koul
2015-03-26 12:32 ` Peter Ujfalusi [this message]
2015-03-26 12:32 ` Peter Ujfalusi
2015-03-26 12:32 ` Peter Ujfalusi
[not found] ` <1426080210-841-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
2015-03-11 13:23 ` [PATCH v2 5/7] dmaengine: omap-dma: Take DMA request number from DT if it is available Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` [PATCH v2 6/7] dmaengine: omap-dma: Remove mapping between virtual channels and requests Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` [PATCH v2 7/7] ARM: DTS: dra7x: Integrate sDMA crossbar Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
2015-03-11 13:23 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5513FC7A.7090708@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.