All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] ARM: dts: sun4i: Add A10 SRAM and SRAM controller
Date: Thu, 26 Mar 2015 15:42:31 +0100	[thread overview]
Message-ID: <55141AD7.1040701@redhat.com> (raw)
In-Reply-To: <20150324152034.GB4951@lukather>

Hi,

On 24-03-15 16:20, Maxime Ripard wrote:
> On Fri, Mar 20, 2015 at 07:52:46PM +0100, Hans de Goede wrote:
>> The A10 has a few SRAM that can be mapped either to a device or to the CPU,
>> with the mapping being controlled by a SRAM controller.
>>
>> Since most of the time these SRAM won't be accessible by the CPU,
>> we can't use the mmio-sram driver and compatible.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   arch/arm/boot/dts/sun4i-a10.dtsi | 34 ++++++++++++++++++++++++++++++++++
>>   1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
>> index b66ebb3..88f57b4 100644
>> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
>> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
>> @@ -451,12 +451,46 @@
>>   		};
>>   	};
>>
>> +	/*
>> +	 * Note we use the address were mmio registers start, not where the
>                                     ^ where
>

Fixed in patches 2 to 4.

Regards,

Hans


>> +	 * SRAM blocks start, this cannot be changed because that would be
>> +	 * a devicetree ABI change.
>> +	 */
>>   	soc at 01c00000 {
>>   		compatible = "simple-bus";
>>   		#address-cells = <1>;
>>   		#size-cells = <1>;
>>   		ranges;
>>
>> +		sram at 00000000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00000000 0x4000>;
>> +			allwinner,sram-name = "A1";
>> +		};
>> +
>> +		sram at 00004000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00004000 0x4000>;
>> +			allwinner,sram-name = "A2";
>> +		};
>> +
>> +		sram at 00008000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00008000 0x4000>;
>> +			allwinner,sram-name = "A3-A4";
>> +		};
>> +
>> +		sram at 00010000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00010000 0x1000>;
>> +			allwinner,sram-name = "D";
>> +		};
>> +
>> +		sram-controller at 01c00000 {
>> +			compatible = "allwinner,sun4i-a10-sram-controller";
>> +			reg = <0x01c00000 0x30>;
>> +		};
>> +
>>   		dma: dma-controller at 01c02000 {
>>   			compatible = "allwinner,sun4i-a10-dma";
>>   			reg = <0x01c02000 0x1000>;
>> --
>> 2.3.3
>>
>

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
	Jens Kuske <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 2/5] ARM: dts: sun4i: Add A10 SRAM and SRAM controller
Date: Thu, 26 Mar 2015 15:42:31 +0100	[thread overview]
Message-ID: <55141AD7.1040701@redhat.com> (raw)
In-Reply-To: <20150324152034.GB4951@lukather>

Hi,

On 24-03-15 16:20, Maxime Ripard wrote:
> On Fri, Mar 20, 2015 at 07:52:46PM +0100, Hans de Goede wrote:
>> The A10 has a few SRAM that can be mapped either to a device or to the CPU,
>> with the mapping being controlled by a SRAM controller.
>>
>> Since most of the time these SRAM won't be accessible by the CPU,
>> we can't use the mmio-sram driver and compatible.
>>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>> ---
>>   arch/arm/boot/dts/sun4i-a10.dtsi | 34 ++++++++++++++++++++++++++++++++++
>>   1 file changed, 34 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
>> index b66ebb3..88f57b4 100644
>> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
>> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
>> @@ -451,12 +451,46 @@
>>   		};
>>   	};
>>
>> +	/*
>> +	 * Note we use the address were mmio registers start, not where the
>                                     ^ where
>

Fixed in patches 2 to 4.

Regards,

Hans


>> +	 * SRAM blocks start, this cannot be changed because that would be
>> +	 * a devicetree ABI change.
>> +	 */
>>   	soc@01c00000 {
>>   		compatible = "simple-bus";
>>   		#address-cells = <1>;
>>   		#size-cells = <1>;
>>   		ranges;
>>
>> +		sram@00000000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00000000 0x4000>;
>> +			allwinner,sram-name = "A1";
>> +		};
>> +
>> +		sram@00004000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00004000 0x4000>;
>> +			allwinner,sram-name = "A2";
>> +		};
>> +
>> +		sram@00008000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00008000 0x4000>;
>> +			allwinner,sram-name = "A3-A4";
>> +		};
>> +
>> +		sram@00010000 {
>> +			compatible = "allwinner,sun4i-a10-sram";
>> +			reg = <0x00010000 0x1000>;
>> +			allwinner,sram-name = "D";
>> +		};
>> +
>> +		sram-controller@01c00000 {
>> +			compatible = "allwinner,sun4i-a10-sram-controller";
>> +			reg = <0x01c00000 0x30>;
>> +		};
>> +
>>   		dma: dma-controller@01c02000 {
>>   			compatible = "allwinner,sun4i-a10-dma";
>>   			reg = <0x01c02000 0x1000>;
>> --
>> 2.3.3
>>
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-03-26 14:42 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-20 18:52 [PATCH 0/5] ARM: sunxi: SRAM mapping support Hans de Goede
2015-03-20 18:52 ` Hans de Goede
2015-03-20 18:52 ` [PATCH 1/5] drivers: soc: sunxi: Introduce SoC driver to map SRAMs Hans de Goede
2015-03-20 18:52   ` Hans de Goede
2015-03-24 15:19   ` Maxime Ripard
2015-03-24 15:19     ` Maxime Ripard
2015-03-26 14:37     ` Hans de Goede
2015-03-26 14:37       ` Hans de Goede
2015-03-20 18:52 ` [PATCH 2/5] ARM: dts: sun4i: Add A10 SRAM and SRAM controller Hans de Goede
2015-03-20 18:52   ` Hans de Goede
2015-03-24 15:20   ` Maxime Ripard
2015-03-24 15:20     ` Maxime Ripard
2015-03-26 14:42     ` Hans de Goede [this message]
2015-03-26 14:42       ` Hans de Goede
2015-03-20 18:52 ` [PATCH 3/5] ARM: dts: sun5i: Add A13 and A10s " Hans de Goede
2015-03-20 18:52   ` Hans de Goede
2015-03-20 18:52 ` [PATCH 4/5] ARM: dts: sun7i: Add A20 " Hans de Goede
2015-03-20 18:52   ` Hans de Goede
2015-03-20 18:52 ` [PATCH 5/5] net: allwinner: emac: Claim our SRAM Hans de Goede
2015-03-20 18:52   ` Hans de Goede
2015-03-20 18:53   ` Hans de Goede
2015-03-20 18:53     ` Hans de Goede
2015-03-24 15:22   ` Maxime Ripard
2015-03-24 15:22     ` Maxime Ripard
2015-03-26 14:44     ` Hans de Goede
2015-03-26 14:44       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55141AD7.1040701@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.