Re: [PATCH] xf86drmMode.h: inline -> __inline for use with gcc -std=c89 -pedantic

From: Emil Velikov <emil.l.velikov@gmail.com>
To: Daniel Kurtz <djkurtz@chromium.org>,
	dri-devel@lists.freedesktop.org, Rob Clark <robdclark@gmail.com>
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH] xf86drmMode.h: inline -> __inline for use with gcc -std=c89 -pedantic
Date: Thu, 26 Mar 2015 15:12:59 +0000	[thread overview]
Message-ID: <551421FB.2020905@gmail.com> (raw)
In-Reply-To: <1427245262-28865-1-git-send-email-djkurtz@chromium.org>

Hi Daniel,
On 25/03/15 01:01, Daniel Kurtz wrote:
> Unfortunately, there are some users of libdrm installed headers that like
> to be built with -std=c89 -pedantic, which does not like "inline".
> 
> However, __inline works.
> 
> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>

> ---
>  xf86drmMode.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xf86drmMode.h b/xf86drmMode.h
> index 856a6bb..2d30184 100644
> --- a/xf86drmMode.h
> +++ b/xf86drmMode.h
> @@ -240,7 +240,7 @@ typedef struct _drmModeProperty {
>  	uint32_t *blob_ids; /* store the blob IDs */
>  } drmModePropertyRes, *drmModePropertyPtr;
>  
> -static inline int drm_property_type_is(drmModePropertyPtr property,
> +static __inline int drm_property_type_is(drmModePropertyPtr property,

Can you share the name of those users ?

From a quick look clang and gcc are ok with this change, although some
versions of the Sun compiler are not. Considering that most programs try
to use c99 and later, might I suggest that you add a trivial wrapper in
your program ? Something along the lines of

#ifndef inline
#define inline __inline
#endif

-Emil

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel