All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: randyf@sibernet.com
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	Niveditha Rau <niveditha.rau@oracle.com>,
	emil.l.velikov@gmail.com,
	Stuart Kreitman <stuart.kreitman@oracle.com>
Subject: Re: [PATCH] xf86drmMode.h: inline -> __inline for use with gcc -std=c89 -pedantic
Date: Sun, 29 Mar 2015 16:20:08 +0000	[thread overview]
Message-ID: <55182638.5090709@gmail.com> (raw)
In-Reply-To: <alpine.SOC.2.00.1503260940050.2840@sibernet.com>

On 26/03/15 16:57, randyf@sibernet.com wrote:
[...]
>>> Alternatively can we:
>>>  (1) move the wrapper to xf86drmMode.h itself, or
>>>  (2) move this inline helper function out of xf86drmMode.h and into
>>> the two libdrm tests that use it (or a shared test helper .h [0])
>>>  (3) remove the inline and make drm_property_type_is a non-inline
>>> function in xf86drmMode.c
>>>
>>> [0] I think Thierry already has a patch set that rearranges the tests
>>> to use some shared headers.  Perhaps this will work well once his set
>>> lands.
>>>
>> Fwiw I would opt for 1 or 3 (leaning towards 1), as 2 might lead to:
>> - Everyone coming up with their own "helper", or
>> - Ignoring DRM_MODE_PROP_EXTENDED_TYPE checking
>> drmModePropertyPtr::flags, thus causing all sorts of chaos.
>>
>>
>> Randy, Niveditha, Stuart,
>>
>> Does the compiler(s) used to build libdrm and friends support __inline ?
> 
>   It should.  I can't be 100% sure as there was just recently a new
> compiler release, but I would also suspect if this support was broken or
> dropped, then lots of stuff would break.
> 
> 
Thanks for the information Randy.

Daniel
Based Randy's input we can go with the original solution :-) Will leave
the patch around for a week or so, for others to comment, before pushing
it. If someone else beats me to it, feel free to add:

Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>

Cheers,
Emil

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-03-29 16:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-25  1:01 [PATCH] xf86drmMode.h: inline -> __inline for use with gcc -std=c89 -pedantic Daniel Kurtz
2015-03-26 15:12 ` Emil Velikov
2015-03-26 15:38   ` Daniel Kurtz
2015-03-26 16:21     ` Emil Velikov
2015-03-26 16:57       ` randyf
2015-03-29 16:20         ` Emil Velikov [this message]
2015-04-05 14:32 ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55182638.5090709@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=niveditha.rau@oracle.com \
    --cc=randyf@sibernet.com \
    --cc=stuart.kreitman@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.