Re: [PATCH 1/6] restructure of_phy_register_fixed_link() for further modifications

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 03/26/2015 06:58 PM, Stas Sergeev wrote:

> -=-=-=-=-=-=-=-=-=# Don't remove this line #=-=-=-=-=-=-=-=-=-

    Hm, why? You could have put a proper change log here...
    Also, threading the patches one after the other is a bad idea, please post 
them all as a replies to the patchset summary (0/6).

> Signed-off-by: Stas Sergeev <stsp@users.sourceforge.net>
> ---
>   drivers/of/of_mdio.c |   32 ++++++++++++++++++--------------
>   1 file changed, 18 insertions(+), 14 deletions(-)

> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index 1bd4305..b3dc1e6 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
> @@ -301,22 +301,26 @@ int of_phy_register_fixed_link(struct device_node *np)
>                                 "asym-pause");
>           of_node_put(fixed_link_node);
>           phy = fixed_phy_register(PHY_POLL, &status, np);
> -        return IS_ERR(phy) ? PTR_ERR(phy) : 0;
> -    }

    Unfortunately, your patch has been whitespace-damaged by your mailer, with 
all tabs converted to spaces.

WBR, Sergei