From: Dave Hansen <dave.hansen@intel.com>
To: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
Mel Gorman <mgorman@suse.de>
Cc: Rik van Riel <riel@redhat.com>,
anton@sambar.org, linux-kernel@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>,
linux-mm@kvack.org, Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
linuxppc-dev@lists.ozlabs.org, Dan Streetman <ddstreet@ieee.org>
Subject: Re: [PATCH] mm: vmscan: do not throttle based on pfmemalloc reserves if node has no reclaimable zones
Date: Fri, 27 Mar 2015 13:17:59 -0700 [thread overview]
Message-ID: <5515BAF7.6070604@intel.com> (raw)
In-Reply-To: <20150327192850.GA18701@linux.vnet.ibm.com>
On 03/27/2015 12:28 PM, Nishanth Aravamudan wrote:
> @@ -2585,7 +2585,7 @@ static bool pfmemalloc_watermark_ok(pg_data_t *pgdat)
>
> for (i = 0; i <= ZONE_NORMAL; i++) {
> zone = &pgdat->node_zones[i];
> - if (!populated_zone(zone))
> + if (!populated_zone(zone) || !zone_reclaimable(zone))
> continue;
>
> pfmemalloc_reserve += min_wmark_pages(zone);
Do you really want zone_reclaimable()? Or do you want something more
direct like "zone_reclaimable_pages(zone) == 0"?
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
Mel Gorman <mgorman@suse.de>
Cc: anton@sambar.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Rik van Riel <riel@redhat.com>,
Dan Streetman <ddstreet@ieee.org>
Subject: Re: [PATCH] mm: vmscan: do not throttle based on pfmemalloc reserves if node has no reclaimable zones
Date: Fri, 27 Mar 2015 13:17:59 -0700 [thread overview]
Message-ID: <5515BAF7.6070604@intel.com> (raw)
In-Reply-To: <20150327192850.GA18701@linux.vnet.ibm.com>
On 03/27/2015 12:28 PM, Nishanth Aravamudan wrote:
> @@ -2585,7 +2585,7 @@ static bool pfmemalloc_watermark_ok(pg_data_t *pgdat)
>
> for (i = 0; i <= ZONE_NORMAL; i++) {
> zone = &pgdat->node_zones[i];
> - if (!populated_zone(zone))
> + if (!populated_zone(zone) || !zone_reclaimable(zone))
> continue;
>
> pfmemalloc_reserve += min_wmark_pages(zone);
Do you really want zone_reclaimable()? Or do you want something more
direct like "zone_reclaimable_pages(zone) == 0"?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Nishanth Aravamudan <nacc@linux.vnet.ibm.com>,
Mel Gorman <mgorman@suse.de>
Cc: anton@sambar.org, linuxppc-dev@lists.ozlabs.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>, Rik van Riel <riel@redhat.com>,
Dan Streetman <ddstreet@ieee.org>
Subject: Re: [PATCH] mm: vmscan: do not throttle based on pfmemalloc reserves if node has no reclaimable zones
Date: Fri, 27 Mar 2015 13:17:59 -0700 [thread overview]
Message-ID: <5515BAF7.6070604@intel.com> (raw)
In-Reply-To: <20150327192850.GA18701@linux.vnet.ibm.com>
On 03/27/2015 12:28 PM, Nishanth Aravamudan wrote:
> @@ -2585,7 +2585,7 @@ static bool pfmemalloc_watermark_ok(pg_data_t *pgdat)
>
> for (i = 0; i <= ZONE_NORMAL; i++) {
> zone = &pgdat->node_zones[i];
> - if (!populated_zone(zone))
> + if (!populated_zone(zone) || !zone_reclaimable(zone))
> continue;
>
> pfmemalloc_reserve += min_wmark_pages(zone);
Do you really want zone_reclaimable()? Or do you want something more
direct like "zone_reclaimable_pages(zone) == 0"?
next prev parent reply other threads:[~2015-03-27 20:18 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-27 19:28 [PATCH] mm: vmscan: do not throttle based on pfmemalloc reserves if node has no reclaimable zones Nishanth Aravamudan
2015-03-27 19:28 ` Nishanth Aravamudan
2015-03-27 19:28 ` Nishanth Aravamudan
2015-03-27 19:39 ` Nishanth Aravamudan
2015-03-27 19:39 ` Nishanth Aravamudan
2015-03-27 19:39 ` Nishanth Aravamudan
2015-03-27 19:58 ` Dan Streetman
2015-03-27 19:58 ` Dan Streetman
2015-03-27 19:58 ` Dan Streetman
2015-03-27 20:17 ` Dave Hansen [this message]
2015-03-27 20:17 ` Dave Hansen
2015-03-27 20:17 ` Dave Hansen
2015-03-27 22:23 ` [PATCH v2] mm: vmscan: do not throttle based on pfmemalloc reserves if node has no reclaimable pages Nishanth Aravamudan
2015-03-27 22:23 ` Nishanth Aravamudan
2015-03-27 22:23 ` Nishanth Aravamudan
2015-03-31 9:48 ` Michal Hocko
2015-03-31 9:48 ` Michal Hocko
2015-03-31 9:48 ` Michal Hocko
2015-04-03 7:57 ` Vlastimil Babka
2015-04-03 7:57 ` Vlastimil Babka
2015-04-03 7:57 ` Vlastimil Babka
2015-04-03 17:45 ` Nishanth Aravamudan
2015-04-03 17:45 ` Nishanth Aravamudan
2015-04-03 17:45 ` Nishanth Aravamudan
2015-05-05 22:09 ` Nishanth Aravamudan
2015-05-05 22:09 ` Nishanth Aravamudan
2015-05-05 22:09 ` Nishanth Aravamudan
2015-05-06 9:28 ` Vlastimil Babka
2015-05-06 9:28 ` Vlastimil Babka
2015-05-06 9:28 ` Vlastimil Babka
2015-05-08 22:47 ` Andrew Morton
2015-05-08 22:47 ` Andrew Morton
2015-05-08 22:47 ` Andrew Morton
2015-05-08 23:18 ` Nishanth Aravamudan
2015-05-08 23:18 ` Nishanth Aravamudan
2015-05-08 23:18 ` Nishanth Aravamudan
2015-04-03 17:43 ` Nishanth Aravamudan
2015-04-03 17:43 ` Nishanth Aravamudan
2015-04-03 17:43 ` Nishanth Aravamudan
2015-04-03 18:24 ` Michal Hocko
2015-04-03 18:24 ` Michal Hocko
2015-04-03 18:24 ` Michal Hocko
2015-04-03 18:50 ` Nishanth Aravamudan
2015-04-03 18:50 ` Nishanth Aravamudan
2015-04-03 18:50 ` Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5515BAF7.6070604@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=anton@sambar.org \
--cc=ddstreet@ieee.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=nacc@linux.vnet.ibm.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.