All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/7] dt-bindings: gpu: mali-utgard: add optional supply regulator
Date: Wed, 13 Sep 2017 00:12:24 +0200	[thread overview]
Message-ID: <5517832.4TA9c0NYD6@diego> (raw)
In-Reply-To: <20170912220920.nfg33wbqikja3gml@rob-hp-laptop>

Hi Rob,

Am Dienstag, 12. September 2017, 17:09:20 CEST schrieb Rob Herring:
> On Tue, Sep 05, 2017 at 12:57:34PM +0200, Heiko Stuebner wrote:
> > Mali GPUs have a separate supplying regulator in a lot of socs,
> > so describe a mali-supply property. The already described
> > operating points will likely also need access to this regulator.
> > 
> > Signed-off-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
> > ---
> > 
> >  Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
> > b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt index
> > 3b7f6f72f032..bcaa640c883f 100644
> > --- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
> > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
> > 
> > @@ -39,6 +39,9 @@ Optional properties:
> >      Memory region to allocate from, as defined in
> >      Documentation/devicetree/bindi/reserved-memory/reserved-memory.txt
> > 
> > +  - mali-supply : Phandle to regulator for the Mali device. Refer to
> > +    Documentation/devicetree/bindings/regulator/regulator.txt for
> > details.
> 
> Wouldn't a power domain be more appropriate?

At least on Rockchip socs there is a power-domain, but also the separate 
additional regulator. See the similar mali-midgard binding.


Heiko
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] dt-bindings: gpu: mali-utgard: add optional supply regulator
Date: Wed, 13 Sep 2017 00:12:24 +0200	[thread overview]
Message-ID: <5517832.4TA9c0NYD6@diego> (raw)
In-Reply-To: <20170912220920.nfg33wbqikja3gml@rob-hp-laptop>

Hi Rob,

Am Dienstag, 12. September 2017, 17:09:20 CEST schrieb Rob Herring:
> On Tue, Sep 05, 2017 at 12:57:34PM +0200, Heiko Stuebner wrote:
> > Mali GPUs have a separate supplying regulator in a lot of socs,
> > so describe a mali-supply property. The already described
> > operating points will likely also need access to this regulator.
> > 
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > 
> >  Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
> > b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt index
> > 3b7f6f72f032..bcaa640c883f 100644
> > --- a/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
> > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-utgard.txt
> > 
> > @@ -39,6 +39,9 @@ Optional properties:
> >      Memory region to allocate from, as defined in
> >      Documentation/devicetree/bindi/reserved-memory/reserved-memory.txt
> > 
> > +  - mali-supply : Phandle to regulator for the Mali device. Refer to
> > +    Documentation/devicetree/bindings/regulator/regulator.txt for
> > details.
> 
> Wouldn't a power domain be more appropriate?

At least on Rockchip socs there is a power-domain, but also the separate 
additional regulator. See the similar mali-midgard binding.


Heiko

  reply	other threads:[~2017-09-12 22:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-05 10:57 [PATCH 0/7] ARM: dts: rockchip: add Utgard Mali nodes for some socs Heiko Stuebner
2017-09-05 10:57 ` Heiko Stuebner
     [not found] ` <20170905105739.8330-1-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-09-05 10:57   ` [PATCH 1/7] dt-bindings: gpu: mali-utgard: Add Rockchip Utgard Malis Heiko Stuebner
2017-09-05 10:57     ` Heiko Stuebner
     [not found]     ` <20170905105739.8330-2-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-09-12 22:02       ` Rob Herring
2017-09-12 22:02         ` Rob Herring
2017-09-05 10:57   ` [PATCH 2/7] dt-bindings: gpu: mali-utgard: add optional supply regulator Heiko Stuebner
2017-09-05 10:57     ` Heiko Stuebner
     [not found]     ` <20170905105739.8330-3-heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
2017-09-12 22:09       ` Rob Herring
2017-09-12 22:09         ` Rob Herring
2017-09-12 22:12         ` Heiko Stübner [this message]
2017-09-12 22:12           ` Heiko Stübner
2017-09-13 14:34           ` Rob Herring
2017-09-13 14:34             ` Rob Herring
2017-09-15  9:01             ` Heiko Stuebner
2017-09-15  9:01               ` Heiko Stuebner
2017-09-05 10:57   ` [PATCH 3/7] ARM: dts: rockchip: add rk3036 gpu node Heiko Stuebner
2017-09-05 10:57     ` Heiko Stuebner
2017-09-05 10:57   ` [PATCH 4/7] ARM: dts: rockchip: enable the gpu on rk3036-kylin boards Heiko Stuebner
2017-09-05 10:57     ` Heiko Stuebner
2017-09-05 10:57   ` [PATCH 5/7] ARM: dts: rockchip: add rk322x gpu node Heiko Stuebner
2017-09-05 10:57     ` Heiko Stuebner
2017-09-05 10:57   ` [PATCH 6/7] ARM: dts: rockchip: add gpu nodes on rk3066/rk3188 Heiko Stuebner
2017-09-05 10:57     ` Heiko Stuebner
2017-09-05 10:57   ` [PATCH 7/7] ARM: dts: rockchip: enable gpu on rk3188-radxarock Heiko Stuebner
2017-09-05 10:57     ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5517832.4TA9c0NYD6@diego \
    --to=heiko-4mtyjxux2i+zqb+pc5nmwq@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.