All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Gonglei <arei.gonglei@huawei.com>,
	 "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-trivial] [PATCH v2] microblaze: fix memory leak
Date: Sun, 29 Mar 2015 20:09:25 +0300	[thread overview]
Message-ID: <551831C5.5020807@msgid.tls.msk.ru> (raw)
In-Reply-To: <55165C4A.5080800@huawei.com>

28.03.2015 10:46, Gonglei wrote:
[]
>> Can this go through -trivial?
>>
> It's ok, but I don't know if -trivial branch maintainer has a plan to send a pull request
> for rc2.

I do have plan to send a pull request, but this thing is ugly.  The
original code is ugly, and your patch does not make it better.  I
wanted to make some changes myself but didn't find fime for that.

Ofcourse it is okay to apply your change to plug the leak, but..
oh well... :(  And if we do, we'll sure forget about that completely.
Now at least you're pinging me from time to time... ;))

Thanks,

/mjt



WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Gonglei <arei.gonglei@huawei.com>,
	"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Cc: qemu-trivial@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
	qemu-devel@nongnu.org,
	"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak
Date: Sun, 29 Mar 2015 20:09:25 +0300	[thread overview]
Message-ID: <551831C5.5020807@msgid.tls.msk.ru> (raw)
In-Reply-To: <55165C4A.5080800@huawei.com>

28.03.2015 10:46, Gonglei wrote:
[]
>> Can this go through -trivial?
>>
> It's ok, but I don't know if -trivial branch maintainer has a plan to send a pull request
> for rc2.

I do have plan to send a pull request, but this thing is ugly.  The
original code is ugly, and your patch does not make it better.  I
wanted to make some changes myself but didn't find fime for that.

Ofcourse it is okay to apply your change to plug the leak, but..
oh well... :(  And if we do, we'll sure forget about that completely.
Now at least you're pinging me from time to time... ;))

Thanks,

/mjt

  reply	other threads:[~2015-03-29 17:09 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-05  3:05 [Qemu-trivial] [PATCH v2] microblaze: fix memory leak arei.gonglei
2015-03-05  3:05 ` [Qemu-devel] " arei.gonglei
2015-03-17  7:15 ` [Qemu-trivial] " Gonglei
2015-03-17  7:15   ` [Qemu-devel] " Gonglei
2015-03-28  2:37   ` [Qemu-trivial] " Gonglei
2015-03-28  2:37     ` [Qemu-devel] " Gonglei
2015-03-28  7:31     ` [Qemu-trivial] " Edgar E. Iglesias
2015-03-28  7:31       ` [Qemu-devel] " Edgar E. Iglesias
2015-03-28  7:46       ` [Qemu-trivial] " Gonglei
2015-03-28  7:46         ` [Qemu-devel] " Gonglei
2015-03-29 17:09         ` Michael Tokarev [this message]
2015-03-29 17:09           ` Michael Tokarev
2015-04-28  9:27           ` [Qemu-trivial] " Gonglei
2015-04-28  9:27             ` [Qemu-devel] " Gonglei
2015-03-28  2:55 ` [Qemu-trivial] " Max Filippov
2015-03-28  2:55   ` Max Filippov
2015-04-29 17:10 ` [Qemu-trivial] " Peter Crosthwaite
2015-04-29 17:10   ` Peter Crosthwaite
2015-04-29 17:17 ` [Qemu-trivial] " Michael Tokarev
2015-04-29 17:17   ` [Qemu-devel] " Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=551831C5.5020807@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=arei.gonglei@huawei.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.