From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: qemu-ppc Mailing List <qemu-ppc@nongnu.org>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
BALATON Zoltan <balaton@eik.bme.hu>
Subject: Re: [Qemu-devel] ppc vga output breakage since commit c3c1bb99
Date: Mon, 30 Mar 2015 13:47:34 +0200 [thread overview]
Message-ID: <551937D6.6060904@redhat.com> (raw)
In-Reply-To: <CAEgOgz4MLwU+WjBsnE0nSjgLfTh1==q9RQ0TkssydqF3_gf8ug@mail.gmail.com>
On 30/03/2015 13:45, Peter Crosthwaite wrote:
> Can the address_space_translate_address() length clamp be made
> conditional on non-MMIO access as the RC fix? I submitted
> c3c1bb99d1c11978d9ce94d1bdcf0705378c1459 as I think its the right
> thing to do regardless of memory type, but in reality it only fixes a
> bug I encountered with RAM memory regions. The original code ignores
> address_space_translate_internal() return-by-pointer length value
> absolutely and the new code uses it absolutely. Should we just if the
> whole thing, old vs new behaviour on MMIO vs non-MMIO?
>
> Happy to submit that fixup if that's the accepted plan.
I submitted what I think is the right fix (sorry Mark for misspelling
your email address). I think you're patch is correct, so I'd rather not
introduce hacks for the release; we can either revert it, or fix ioport.c.
Paolo
next prev parent reply other threads:[~2015-03-30 11:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-28 19:04 [Qemu-devel] ppc vga output breakage since commit c3c1bb99 BALATON Zoltan
2015-03-28 19:19 ` Mark Cave-Ayland
2015-03-30 9:51 ` Paolo Bonzini
2015-03-30 10:20 ` Mark Cave-Ayland
2015-03-30 10:28 ` Paolo Bonzini
2015-03-30 11:45 ` Peter Crosthwaite
2015-03-30 11:47 ` Paolo Bonzini [this message]
2015-03-31 22:34 ` Mark Cave-Ayland
2015-04-01 7:55 ` Paolo Bonzini
2015-04-02 11:45 ` Mark Cave-Ayland
2015-04-02 13:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551937D6.6060904@redhat.com \
--to=pbonzini@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.