All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH V2 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node
@ 2015-03-30 14:16 Markus Reichl
  2015-03-30 14:43 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 2+ messages in thread
From: Markus Reichl @ 2015-03-30 14:16 UTC (permalink / raw)
  To: linux-samsung-soc; +Cc: Krzysztof Kozlowski, Anand Moon

The Exynos5422 SoC has a s3c6410 RTC where the source clock
is now a mandatory property.

This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
It is based in v4.0-rc2.

Tested-by: Anand Moon <linux.amoon@gmail.com>
Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
---
Changes since v1:
1. Dropped Documentation.
2. Split into 2 parts.
---

 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index a519c86..ac663ec 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -11,6 +11,7 @@
 */
 
 /dts-v1/;
+#include <dt-bindings/clock/samsung,s2mps11.h>
 #include "exynos5800.dtsi"
 
 / {
@@ -44,7 +45,7 @@
 	hsi2c_4: i2c@12CA0000 {
 		status = "okay";
 
-		s2mps11_pmic@66 {
+		s2mps11: s2mps11_pmic@66 {
 			compatible = "samsung,s2mps11-pmic";
 			reg = <0x66>;
 			s2mps11,buck2-ramp-delay = <12>;
@@ -274,10 +275,6 @@
 			reg = <0x50>;
 		};
 	};
-
-	rtc@101E0000 {
-		status = "okay";
-	};
 };
 
 &hdmi {
@@ -369,3 +366,9 @@
 		shunt-resistor = <10000>;
 	};
 };
+
+&rtc {
+	status = "okay";
+	clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
+	clock-names = "rtc", "rtc_src";
+};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH V2 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node
  2015-03-30 14:16 [PATCH V2 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node Markus Reichl
@ 2015-03-30 14:43 ` Krzysztof Kozlowski
  0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-03-30 14:43 UTC (permalink / raw)
  To: Markus Reichl; +Cc: linux-samsung-soc, Krzysztof Kozlowski, Anand Moon

2015-03-30 16:16 GMT+02:00 Markus Reichl <m.reichl@fivetechno.de>:
> The Exynos5422 SoC has a s3c6410 RTC where the source clock
> is now a mandatory property.
>
> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
> It is based in v4.0-rc2.
>
> Tested-by: Anand Moon <linux.amoon@gmail.com>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> Changes since v1:
> 1. Dropped Documentation.
> 2. Split into 2 parts.
> ---
>
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index a519c86..ac663ec 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -11,6 +11,7 @@
>  */
>
>  /dts-v1/;
> +#include <dt-bindings/clock/samsung,s2mps11.h>
>  #include "exynos5800.dtsi"
>
>  / {
> @@ -44,7 +45,7 @@
>         hsi2c_4: i2c@12CA0000 {
>                 status = "okay";
>
> -               s2mps11_pmic@66 {
> +               s2mps11: s2mps11_pmic@66 {

Why this is needed? This phandle is not used later.

Rest looks fine.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-03-30 14:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 14:16 [PATCH V2 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node Markus Reichl
2015-03-30 14:43 ` Krzysztof Kozlowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.