Question on ar->max_num_vdevs and WMI ops config.

Question on ar->max_num_vdevs and WMI ops config.

[Ben Greear]

I'm porting forward my changes to the 4.0-rc6 kernel, and I notice
something a bit confusing to me.

It seems some upstream patch has added ar->max_num_vdevs and some related
fields.

But, in places like this:

static struct sk_buff *ath10k_wmi_op_gen_init(struct ath10k *ar)
{
	struct wmi_init_cmd *cmd;
	struct sk_buff *buf;
	struct wmi_resource_config config = {};
	u32 len, val;

	config.num_vdevs = __cpu_to_le32(TARGET_NUM_VDEVS);
	config.num_peers = __cpu_to_le32(TARGET_NUM_PEERS);
	config.num_offload_peers = __cpu_to_le32(TARGET_NUM_OFFLOAD_PEERS);


We are still using constants instead of ar->max_num_vdevs.

Was this done on purpose for some reason?

It will make my patches to support CT features a bit cleaner if we use the
values stored in ar->max_num_vdevs etc.


Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

Re: Question on ar->max_num_vdevs and WMI ops config.

[Michal Kazior]

On 30 March 2015 at 23:09, Ben Greear <greearb@candelatech.com> wrote:
> I'm porting forward my changes to the 4.0-rc6 kernel, and I notice
> something a bit confusing to me.
>
> It seems some upstream patch has added ar->max_num_vdevs and some related
> fields.
>
> But, in places like this:
>
> static struct sk_buff *ath10k_wmi_op_gen_init(struct ath10k *ar)
> {
>         struct wmi_init_cmd *cmd;
>         struct sk_buff *buf;
>         struct wmi_resource_config config = {};
>         u32 len, val;
>
>         config.num_vdevs = __cpu_to_le32(TARGET_NUM_VDEVS);
>         config.num_peers = __cpu_to_le32(TARGET_NUM_PEERS);
>         config.num_offload_peers = __cpu_to_le32(TARGET_NUM_OFFLOAD_PEERS);
>
>
> We are still using constants instead of ar->max_num_vdevs.
>
> Was this done on purpose for some reason?

An oversight I guess.


Michał

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k