* [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node
@ 2015-03-30 15:38 Markus Reichl
2015-03-30 15:39 ` Krzysztof Kozlowski
2015-03-31 4:05 ` Chanwoo Choi
0 siblings, 2 replies; 4+ messages in thread
From: Markus Reichl @ 2015-03-30 15:38 UTC (permalink / raw)
To: linux-samsung-soc; +Cc: Krzysztof Kozlowski, Anand Moon
The Exynos5422 SoC has a s3c6410 RTC where the source clock
is now a mandatory property.
This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
It is based in v4.0-rc2.
Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
---
Changes since v2:
1. Dropped unused phandle.
Changes since v1:
1. Dropped Documentation.
2. Split into 2 parts.
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 0408ec0..4a7ca15 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -274,10 +274,6 @@
reg = <0x50>;
};
};
-
- rtc@101E0000 {
- status = "okay";
- };
};
&hdmi {
@@ -374,3 +370,9 @@
shunt-resistor = <10000>;
};
};
+
+&rtc {
+ status = "okay";
+ clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
+ clock-names = "rtc", "rtc_src";
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node
2015-03-30 15:38 [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node Markus Reichl
@ 2015-03-30 15:39 ` Krzysztof Kozlowski
2015-03-31 4:05 ` Chanwoo Choi
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2015-03-30 15:39 UTC (permalink / raw)
To: Markus Reichl; +Cc: linux-samsung-soc, Krzysztof Kozlowski, Anand Moon
2015-03-30 17:38 GMT+02:00 Markus Reichl <m.reichl@fivetechno.de>:
> The Exynos5422 SoC has a s3c6410 RTC where the source clock
> is now a mandatory property.
>
> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
> It is based in v4.0-rc2.
>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> Changes since v2:
> 1. Dropped unused phandle.
> Changes since v1:
> 1. Dropped Documentation.
> 2. Split into 2 parts.
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node
2015-03-30 15:38 [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node Markus Reichl
2015-03-30 15:39 ` Krzysztof Kozlowski
@ 2015-03-31 4:05 ` Chanwoo Choi
2015-03-31 6:40 ` Javier Martinez Canillas
1 sibling, 1 reply; 4+ messages in thread
From: Chanwoo Choi @ 2015-03-31 4:05 UTC (permalink / raw)
To: Markus Reichl; +Cc: linux-samsung-soc, Krzysztof Kozlowski, Anand Moon
Hi,
On 03/31/2015 12:38 AM, Markus Reichl wrote:
> The Exynos5422 SoC has a s3c6410 RTC where the source clock
> is now a mandatory property.
>
> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
> It is based in v4.0-rc2.
>
> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
> ---
> Changes since v2:
> 1. Dropped unused phandle.
> Changes since v1:
> 1. Dropped Documentation.
> 2. Split into 2 parts.
> ---
> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index 0408ec0..4a7ca15 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -274,10 +274,6 @@
> reg = <0x50>;
> };
> };
> -
> - rtc@101E0000 {
> - status = "okay";
> - };
> };
>
> &hdmi {
> @@ -374,3 +370,9 @@
> shunt-resistor = <10000>;
> };
> };
> +
> +&rtc {
> + status = "okay";
> + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
> + clock-names = "rtc", "rtc_src";
> +};
>
Exynos's RTC must need the XrtcXTI source clock (32.768kHz). Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node
2015-03-31 4:05 ` Chanwoo Choi
@ 2015-03-31 6:40 ` Javier Martinez Canillas
0 siblings, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-03-31 6:40 UTC (permalink / raw)
To: Chanwoo Choi
Cc: Markus Reichl, linux-samsung-soc@vger.kernel.org,
Krzysztof Kozlowski, Anand Moon
On Tue, Mar 31, 2015 at 6:05 AM, Chanwoo Choi <cw00.choi@samsung.com> wrote:
> Hi,
>
> On 03/31/2015 12:38 AM, Markus Reichl wrote:
>> The Exynos5422 SoC has a s3c6410 RTC where the source clock
>> is now a mandatory property.
>>
>> This patch fixes probe failure of s3c-rtc on Odroid-XU3 boards.
>> It is based in v4.0-rc2.
>>
>> Signed-off-by: Markus Reichl <m.reichl@fivetechno.de>
>> ---
>> Changes since v2:
>> 1. Dropped unused phandle.
>> Changes since v1:
>> 1. Dropped Documentation.
>> 2. Split into 2 parts.
>> ---
>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 10 ++++++----
>> 1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index 0408ec0..4a7ca15 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -274,10 +274,6 @@
>> reg = <0x50>;
>> };
>> };
>> -
>> - rtc@101E0000 {
>> - status = "okay";
>> - };
>> };
>>
>> &hdmi {
>> @@ -374,3 +370,9 @@
>> shunt-resistor = <10000>;
>> };
>> };
>> +
>> +&rtc {
>> + status = "okay";
>> + clocks = <&clock CLK_RTC>, <&s2mps11_osc S2MPS11_CLK_AP>;
>> + clock-names = "rtc", "rtc_src";
>> +};
>>
>
> Exynos's RTC must need the XrtcXTI source clock (32.768kHz). Looks good to me.
>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
>
> Thanks,
> Chanwoo Choi
>
Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
Best regards,
Javier
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-31 6:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-30 15:38 [PATCH V3 2/2] ARM: dts: exynos5422-odroidxu3: add 'rtc_src' clock to rtc node Markus Reichl
2015-03-30 15:39 ` Krzysztof Kozlowski
2015-03-31 4:05 ` Chanwoo Choi
2015-03-31 6:40 ` Javier Martinez Canillas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.