From: Lars-Peter Clausen <lars@metafoo.de>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Mark Brown <broonie@kernel.org>, Bo Shen <voice.shen@atmel.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [alsa-devel] [PATCH] ASoC: atmel-pcm-dma: increase buffer_bytes_max
Date: Tue, 31 Mar 2015 09:39:30 +0200 [thread overview]
Message-ID: <551A4F32.10608@metafoo.de> (raw)
In-Reply-To: <1427744437-14610-1-git-send-email-alexandre.belloni@free-electrons.com>
On 03/30/2015 09:40 PM, Alexandre Belloni wrote:
> atmel-pcm-dma is not limited to a buffer size of 64kB like atmel-pcm-pdc.
> Increase buffer_bytes_max to 512kB to allow for higher bit rates (i.e. 32bps at
> 192kHz) to work correctly. By default, keep the prealloc at 64kB.
Patch per se looks good. But can you test if it works to just throw
atmel_pcm_dma_hardware away completely and rely on the dmaengine PCM driver
getting the capabilities directly from the DMA driver. Since the DMA driver
now reports its capabilities I think it should work, and if it does that's
the preferred solution.
- Lars
WARNING: multiple messages have this Message-ID (diff)
From: lars@metafoo.de (Lars-Peter Clausen)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] [PATCH] ASoC: atmel-pcm-dma: increase buffer_bytes_max
Date: Tue, 31 Mar 2015 09:39:30 +0200 [thread overview]
Message-ID: <551A4F32.10608@metafoo.de> (raw)
In-Reply-To: <1427744437-14610-1-git-send-email-alexandre.belloni@free-electrons.com>
On 03/30/2015 09:40 PM, Alexandre Belloni wrote:
> atmel-pcm-dma is not limited to a buffer size of 64kB like atmel-pcm-pdc.
> Increase buffer_bytes_max to 512kB to allow for higher bit rates (i.e. 32bps at
> 192kHz) to work correctly. By default, keep the prealloc at 64kB.
Patch per se looks good. But can you test if it works to just throw
atmel_pcm_dma_hardware away completely and rely on the dmaengine PCM driver
getting the capabilities directly from the DMA driver. Since the DMA driver
now reports its capabilities I think it should work, and if it does that's
the preferred solution.
- Lars
next prev parent reply other threads:[~2015-03-31 7:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 19:40 [PATCH] ASoC: atmel-pcm-dma: increase buffer_bytes_max Alexandre Belloni
2015-03-30 19:40 ` Alexandre Belloni
2015-03-31 7:39 ` Lars-Peter Clausen [this message]
2015-03-31 7:39 ` [alsa-devel] " Lars-Peter Clausen
2015-04-01 20:33 ` Mark Brown
2015-04-01 20:33 ` Mark Brown
2015-04-02 8:13 ` Alexandre Belloni
2015-04-02 8:13 ` Alexandre Belloni
2015-04-02 8:13 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551A4F32.10608@metafoo.de \
--to=lars@metafoo.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.